From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D037C54EE9 for ; Tue, 27 Sep 2022 07:34:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D969910E0C0; Tue, 27 Sep 2022 07:34:47 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E95010E0C0 for ; Tue, 27 Sep 2022 07:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664264084; x=1695800084; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=seRz00gR5ZCyfR9Av3m54a9Qc+WmUp7nSvP3jbOmS8Y=; b=eqC+PC+t10Gpe5LImFj1wjDSKQ82j/zQvVOHxQFy4xF1JFzwT76anaEW 7GOKh9lseWlvN/81/cKrWDN+bwoC2C9c5xCxTu6ZEye/CCXxeyKQsZjes UOlj+z9Et/6xA/Cq4+IcMBPbPVLQ+YRE7mYSwRgSNvID3m2s9Or2Ignpr 6msRZox+UgCGhhsmNMOQcqnc2aqbOD+VT8txzrYzXebPMTsV1XJX3vmgQ UorLZ9SDqsbv6iFJYUfoDxAsoWb4ImckzZcji95bSqkuuCRHBXijrGNao BjmmIa0fR6IyWw7XalFEuKgIlxnHrXTNRzyToWMxb+jXSzNmIVc6570CK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="363085935" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="363085935" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 00:34:43 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="623662557" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="623662557" Received: from bvoinov-mobl1.ger.corp.intel.com (HELO [10.213.221.221]) ([10.213.221.221]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 00:34:42 -0700 Message-ID: Date: Tue, 27 Sep 2022 08:34:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org References: <20220927054016.21474-1-niranjana.vishwanathapura@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20220927054016.21474-1-niranjana.vishwanathapura@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chris@chris-wilson.co.uk Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 27/09/2022 06:40, Niranjana Vishwanathapura wrote: > In await_fence_array(), unpacking syncobj pointer is not needed. > Remove it. > > Signed-off-by: Niranjana Vishwanathapura > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index cd75b0ca2555..8f5796cf9c9c 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb, > int err; > > for (n = 0; n < eb->num_fences; n++) { > - struct drm_syncobj *syncobj; > - unsigned int flags; > - > - syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2); > - Seems it was left hanging unused since 13149e8bafc4 ("drm/i915: add syncobj timeline support"). Reviewed-by: Tvrtko Ursulin Regards, Tvrtko > if (!eb->fences[n].dma_fence) > continue; >