intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9
Date: Wed, 29 Nov 2017 15:54:21 +0200	[thread overview]
Message-ID: <a79787b8-eb3c-4641-92a2-d1aea7eb6f84@gmail.com> (raw)
In-Reply-To: <24010dcb-cbaf-4e51-445f-16b11ea805fe@linux.intel.com>

On 28.11.2017 13:53, Maarten Lankhorst wrote:
> Hey,
> 
> Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila:
>> Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format.
>>
>> v2 (Ville Syrjälä):
>> As a side effect to keep bad-pixel-format test valid on all supported
>> platforms it need to use DRM_FORMAT_C8 now.
>>
>> While at it clean up kms_rotation_crc test a bit, take out
>> test_plane_rotation_ytiled_obj() function as
>> test_plane_rotation() can basically do the same.
>>
>> v3 (Ville Syrjälä):
>> repurpose test_plane_rotation_ytiled_obj() function for
>> bad pixel testing with DRM_FORMAT_C8 as igt doesn't
>> support this format.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> At this point there is no correct order to apply the tests then.
> 
> What I would like to see is the bad-pixel-format changes in a separate commit, so we can commit that first, and then commit kernel change, watch CI results for regressions and then add the new IGT test..
> 
> With that fixed the patches can be applied. :)
> 

Hei, thanks for the comment Maarten. I'll make the change and add you as 
cc once done. :)

/Juha-Pekka

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-29 13:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 14:02 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila
2017-11-21 14:02 ` Juha-Pekka Heikkila
2017-11-28 11:53   ` Maarten Lankhorst
2017-11-29 13:54     ` Juha-Pekka Heikkila [this message]
2017-11-21 14:22 ` ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) Patchwork
2017-11-21 16:34 ` ✗ Fi.CI.IGT: warning " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-11-03 14:26 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila
2017-11-03 16:25 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a79787b8-eb3c-4641-92a2-d1aea7eb6f84@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).