From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E07EC433F5 for ; Mon, 10 Oct 2022 12:11:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A05C410E4BF; Mon, 10 Oct 2022 12:11:04 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30E7210E144 for ; Mon, 10 Oct 2022 12:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665403856; x=1696939856; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+7iCPWnmbJAUOTEWx6U878iQD9S3SDNSufytTDUJa4k=; b=bN7WyZ2e8XGXlgf/RNMFzYU4h5kUdz9SmaQ+0fbrpyGy4SoyXjDYu1qP kGwO9BCZsdAkTtqHSDL7YESTIEcl0mlsID3/RqDnEF0KKhJN7jqXWI1bD WQra5dCsYdsbUYZHUlRMxqtlnlhheoTumYypi0JnNzc52Dqgg3mD+22fW LT/vcXJGCYasqYnaAKU/ycxaDpceh4yTID6lL0oz428wTkhJ0SnJ25f78 1E3w1scnNigF6+YR4rrZWepus1Qr1Lu7cUtHmVX64CTeMZ94a7GrjJ6wD AbDbosp14xikWOWI2wh2KwhGekgVJnOJGdw/r43bxI4uRCf6F9rYVTlDe Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="305804670" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="305804670" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 05:10:55 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="871080489" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="871080489" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.10.52]) ([10.213.10.52]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 05:10:54 -0700 Message-ID: Date: Mon, 10 Oct 2022 14:10:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.3.1 Content-Language: en-US To: Vinod Govindapillai , intel-gfx@lists.freedesktop.org References: <20221010083447.139768-1-vinod.govindapillai@intel.com> <20221010083447.139768-3-vinod.govindapillai@intel.com> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20221010083447.139768-3-vinod.govindapillai@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10.10.2022 10:34, Vinod Govindapillai wrote: > Knob to control ignoring the long hpds. Set this to true will > start ignoring the long HPDs generated by the displays. Useful > for use cases like CI systems where we dont expect to disconnect > the panels. > > v2: Address patch styling comments (Jani Nikula) > > Signed-off-by: Vinod Govindapillai Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/i915/display/intel_hotplug.c | 25 ++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c > index 352a1b53b63e..45c67f0f1c9f 100644 > --- a/drivers/gpu/drm/i915/display/intel_hotplug.c > +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c > @@ -936,6 +936,29 @@ static const struct file_operations i915_hpd_short_storm_ctl_fops = { > .write = i915_hpd_short_storm_ctl_write, > }; > > +static int i915_ignore_long_hpd_set(void *data, u64 val) > +{ > + struct drm_i915_private *i915 = data; > + > + drm_dbg_kms(&i915->drm, "Ignoring long HPDs: %s\n", str_yes_no(val)); > + > + i915->display.hotplug.ignore_long_hpd = val; > + > + return 0; > +} > + > +static int i915_ignore_long_hpd_get(void *data, u64 *val) > +{ > + struct drm_i915_private *i915 = data; > + > + *val = i915->display.hotplug.ignore_long_hpd; > + > + return 0; > +} > + > +DEFINE_SIMPLE_ATTRIBUTE(i915_ignore_long_hpd_fops, i915_ignore_long_hpd_get, > + i915_ignore_long_hpd_set, "%llu\n"); > + > void intel_hpd_debugfs_register(struct drm_i915_private *i915) > { > struct drm_minor *minor = i915->drm.primary; > @@ -944,4 +967,6 @@ void intel_hpd_debugfs_register(struct drm_i915_private *i915) > i915, &i915_hpd_storm_ctl_fops); > debugfs_create_file("i915_hpd_short_storm_ctl", 0644, minor->debugfs_root, > i915, &i915_hpd_short_storm_ctl_fops); > + debugfs_create_file("i915_ignore_long_hpd", 0644, minor->debugfs_root, > + i915, &i915_ignore_long_hpd_fops); > }