From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 08/29] drm/i915: Introduce struct intel_wakeref Date: Wed, 10 Apr 2019 10:49:35 +0100 Message-ID: References: <20190408091728.20207-1-chris@chris-wilson.co.uk> <20190408091728.20207-8-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1883689123 for ; Wed, 10 Apr 2019 09:49:38 +0000 (UTC) In-Reply-To: <20190408091728.20207-8-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzA0LzIwMTkgMTA6MTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBGb3IgY29udHJvbGxp bmcgcnVudGltZSBwbSBvZiB0aGUgR1QgYW5kIGVuZ2luZXMsIHdlIHdvdWxkIGxpa2UgdG8gaGF2 ZQo+IGEgY2FsbGJhY2sgdG8gZG8gZXh0cmEgd29yayB0aGUgZmlyc3QgdGltZSB3ZSB3YWtlIHVw IGFuZCB0aGUgbGFzdCB0aW1lCj4gd2UgZHJvcCB0aGUgd2FrZXJlZi4gVGhpcyBmaXJzdC9sYXN0 IGFjY2VzcyBuZWVkcyBzZXJpYWxpc2F0aW9uIGFuZCBzbwo+IHdlIGVuY29tcGFzcyBhIG11dGV4 IHdpdGggdGhlIHJlZ3VsYXIgaW50ZWxfd2FrZXJlZl90IHRyYWNrZXIuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZSAgICAgICAgICAgICB8ICAxICsKPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlLmhlYWRlci10ZXN0IHwgIDMgKy0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgIHwgIDMgKy0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYyAgICAgIHwgNTEgKysrKysrKysrKysrKysrCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93YWtlcmVmLmggICAgICB8IDc3ICsrKysrKysrKysr KysrKysrKysrKysrCj4gICA1IGZpbGVzIGNoYW5nZWQsIDEzMiBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3dha2VyZWYuYwo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3dha2VyZWYuaAo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9N YWtlZmlsZSBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlCj4gaW5kZXggNDAxMzBjZjVj MDAzLi4yMzNiYWQ1ZTM2MWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFr ZWZpbGUKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZQo+IEBAIC01MCw2ICs1 MCw3IEBAIGk5MTUteSArPSBpOTE1X2Rydi5vIFwKPiAgIAkgIGludGVsX2RldmljZV9pbmZvLm8g XAo+ICAgCSAgaW50ZWxfcG0ubyBcCj4gICAJICBpbnRlbF9ydW50aW1lX3BtLm8gXAo+ICsJICBp bnRlbF93YWtlcmVmLm8gXAo+ICAgCSAgaW50ZWxfdW5jb3JlLm8KPiAgIAo+ICAgIyBjb3JlIGxp YnJhcnkgY29kZQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZS5o ZWFkZXItdGVzdCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlLmhlYWRlci10ZXN0Cj4g aW5kZXggOTZhNWQ5MDYyOWVjLi5lNmIzZTc1ODg4NjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvTWFrZWZpbGUuaGVhZGVyLXRlc3QKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9NYWtlZmlsZS5oZWFkZXItdGVzdAo+IEBAIC0zMSw3ICszMSw4IEBAIGhlYWRlcl90ZXN0 IDo9IFwKPiAgIAlpbnRlbF9wc3IuaCBcCj4gICAJaW50ZWxfc2R2by5oIFwKPiAgIAlpbnRlbF9z cHJpdGUuaCBcCj4gLQlpbnRlbF90di5oCj4gKwlpbnRlbF90di5oIFwKPiArCWludGVsX3dha2Vy ZWYuaAo+ICAgCj4gICBxdWlldF9jbWRfaGVhZGVyX3Rlc3QgPSBIRFJURVNUICRACj4gICAgICAg ICBjbWRfaGVhZGVyX3Rlc3QgPSBlY2hvICJcI2luY2x1ZGUgXCIkKDxGKVwiIiA+ICRACj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZmFkNTMwNmYwN2RhLi42MmE3ZTkxYWNkN2YgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtNzQsNiArNzQsNyBAQAo+ICAgI2luY2x1 ZGUgImludGVsX29wcmVnaW9uLmgiCj4gICAjaW5jbHVkZSAiaW50ZWxfdWMuaCIKPiAgICNpbmNs dWRlICJpbnRlbF91bmNvcmUuaCIKPiArI2luY2x1ZGUgImludGVsX3dha2VyZWYuaCIKPiAgICNp bmNsdWRlICJpbnRlbF93b3BjbS5oIgo+ICAgCj4gICAjaW5jbHVkZSAiaTkxNV9nZW0uaCIKPiBA QCAtMTM0LDggKzEzNSw2IEBAIGJvb2wgaTkxNV9lcnJvcl9pbmplY3RlZCh2b2lkKTsKPiAgIAlf X2k5MTVfcHJpbnRrKGk5MTUsIGk5MTVfZXJyb3JfaW5qZWN0ZWQoKSA/IEtFUk5fREVCVUcgOiBL RVJOX0VSUiwgXAo+ICAgCQkgICAgICBmbXQsICMjX19WQV9BUkdTX18pCj4gICAKPiAtdHlwZWRl ZiBkZXBvdF9zdGFja19oYW5kbGVfdCBpbnRlbF93YWtlcmVmX3Q7Cj4gLQo+ICAgZW51bSBocGRf cGluIHsKPiAgIAlIUERfTk9ORSA9IDAsCj4gICAJSFBEX1RWID0gSFBEX05PTkUsICAgICAvKiBU ViBpcyBrbm93biB0byBiZSB1bnJlbGlhYmxlICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dh a2VyZWYuYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5jMTMz YzkxY2YyNzcKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfd2FrZXJlZi5jCj4gQEAgLTAsMCArMSw1MSBAQAo+ICsvKgo+ICsgKiBTUERYLUxpY2Vuc2Ut SWRlbnRpZmllcjogTUlUCj4gKyAqCj4gKyAqIENvcHlyaWdodCDCqSAyMDE5IEludGVsIENvcnBv cmF0aW9uCj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICsjaW5jbHVkZSAi aW50ZWxfd2FrZXJlZi5oIgo+ICsKPiArdm9pZCBfX2ludGVsX3dha2VyZWZfZ2V0X29uY2Uoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gKwkJCSAgICAgIHN0cnVjdCBpbnRlbF93YWtl cmVmX2NvdW50ICp3YywKPiArCQkJICAgICAgYm9vbCAoKmZuKShzdHJ1Y3QgaW50ZWxfd2FrZXJl Zl9jb3VudCAqd2MpKQo+ICt7Cj4gKwkvKgo+ICsJICogVHJlYXQgZ2V0L3B1dCBhcyBkaWZmZXJl bnQgc3ViY2xhc3NlcywgYXMgd2UgbWF5IG5lZWQgdG8gcnVuCj4gKwkgKiB0aGUgcHV0IGNhbGxi YWNrIGZyb20gdW5kZXIgdGhlIHNocmlua2VyIGFuZCBkbyBub3Qgd2FudCB0bwo+ICsJICogY3Jv c3MtY29udGFuaW1hdGUgdGhhdCBjYWxsYmFjayB3aXRoIGFueSBleHRyYSB3b3JrIHBlcmZvcm1l ZAo+ICsJICogdXBvbiBhY3F1aXJpbmcgdGhlIHdha2VyZWYuCj4gKwkgKi8KPiArCW11dGV4X2xv Y2tfbmVzdGVkKCZ3Yy0+bXV0ZXgsIFNJTkdMRV9ERVBUSF9ORVNUSU5HKTsKPiArCWlmICghYXRv bWljX3JlYWQoJndjLT5jb3VudCkpIHsKPiArCQl3Yy0+d2FrZXJlZiA9IGludGVsX3J1bnRpbWVf cG1fZ2V0KGk5MTUpOwo+ICsJCWlmICh1bmxpa2VseSghZm4od2MpKSkgewo+ICsJCQlpbnRlbF9y dW50aW1lX3BtX3B1dChpOTE1LCB3Yy0+d2FrZXJlZik7Cj4gKwkJCW11dGV4X3VubG9jaygmd2Mt Pm11dGV4KTsKPiArCQkJcmV0dXJuOwoKRmVlbHMgbGlrZSBhIGJhZCBBUEkgdGhhdCBjYWxsYmFj ayByZXR1cm4gZXJyb3IgZ2V0cyBpZ25vcmVkLiBJIG1lYW4gCmZyb20gdGhlIGNhbGxlcidzIHBl cnNwZWN0aXZlIC0gaG93IGRvIHRoZXkga25vdyBpZiB0aGUgd2FrZXJlZiBnZXQgCnN1Y2NlZWRl ZCBvciBub3Q/Cgo+ICsJCX0KPiArCj4gKwkJc21wX21iX19iZWZvcmVfYXRvbWljKCk7IC8qIHJl bGVhc2Ugd2MtPmNvdW50ICovCj4gKwl9Cj4gKwlhdG9taWNfaW5jKCZ3Yy0+Y291bnQpOwo+ICsJ bXV0ZXhfdW5sb2NrKCZ3Yy0+bXV0ZXgpOwo+ICt9Cj4gKwo+ICt2b2lkIF9faW50ZWxfd2FrZXJl Zl9wdXRfb25jZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiArCQkJICAgICAgc3Ry dWN0IGludGVsX3dha2VyZWZfY291bnQgKndjLAo+ICsJCQkgICAgICBib29sICgqZm4pKHN0cnVj dCBpbnRlbF93YWtlcmVmX2NvdW50ICp3YykpCj4gK3sKPiArCWlmIChsaWtlbHkoZm4od2MpKSkK PiArCQlpbnRlbF9ydW50aW1lX3BtX3B1dChpOTE1LCB3Yy0+d2FrZXJlZik7Cj4gKwllbHNlCj4g KwkJYXRvbWljX2luYygmd2MtPmNvdW50KTsKPiArCW11dGV4X3VubG9jaygmd2MtPm11dGV4KTsK PiArfQo+ICsKPiArdm9pZCBfX2ludGVsX3dha2VyZWZfaW5pdChzdHJ1Y3QgaW50ZWxfd2FrZXJl Zl9jb3VudCAqd2MsCj4gKwkJCSAgc3RydWN0IGxvY2tfY2xhc3Nfa2V5ICprZXkpCj4gK3sKPiAr CV9fbXV0ZXhfaW5pdCgmd2MtPm11dGV4LCAid2FrZXJlZiIsIGtleSk7Cj4gKwlhdG9taWNfc2V0 KCZ3Yy0+Y291bnQsIDApOwo+ICt9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3dha2VyZWYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dha2VyZWYuaAo+ IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5jZDRkOGY1N2U1MDIK PiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd2FrZXJl Zi5oCj4gQEAgLTAsMCArMSw3NyBAQAo+ICsvKgo+ICsgKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmll cjogTUlUCj4gKyAqCj4gKyAqIENvcHlyaWdodCDCqSAyMDE5IEludGVsIENvcnBvcmF0aW9uCj4g KyAqLwo+ICsKPiArI2lmbmRlZiBJTlRFTF9XQUtFUkVGX0gKPiArI2RlZmluZSBJTlRFTF9XQUtF UkVGX0gKPiArCj4gKyNpbmNsdWRlIDxsaW51eC9hdG9taWMuaD4KPiArI2luY2x1ZGUgPGxpbnV4 L211dGV4Lmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9zdGFja2RlcG90Lmg+Cj4gKwo+ICtzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZTsKPiArCj4gK3R5cGVkZWYgZGVwb3Rfc3RhY2tfaGFuZGxlX3QgaW50 ZWxfd2FrZXJlZl90Owo+ICsKPiArc3RydWN0IGludGVsX3dha2VyZWZfY291bnQgewo+ICsJYXRv bWljX3QgY291bnQ7Cj4gKwlzdHJ1Y3QgbXV0ZXggbXV0ZXg7Cj4gKwlpbnRlbF93YWtlcmVmX3Qg d2FrZXJlZjsKPiArfTsKPiArCj4gK3ZvaWQgX19pbnRlbF93YWtlcmVmX2luaXQoc3RydWN0IGlu dGVsX3dha2VyZWZfY291bnQgKndjLAo+ICsJCQkgIHN0cnVjdCBsb2NrX2NsYXNzX2tleSAqa2V5 KTsKPiArI2RlZmluZSBpbnRlbF93YWtlcmVmX2luaXQod2MpIGRvIHsJCQkJCVwKPiArCXN0YXRp YyBzdHJ1Y3QgbG9ja19jbGFzc19rZXkgX19rZXk7CQkJCVwKPiArCQkJCQkJCQkJXAo+ICsJX19p bnRlbF93YWtlcmVmX2luaXQoKHdjKSwgJl9fa2V5KTsJCQkJXAo+ICt9IHdoaWxlICgwKQo+ICsK PiArdm9pZCBfX2ludGVsX3dha2VyZWZfZ2V0X29uY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUsCj4gKwkJCSAgICAgIHN0cnVjdCBpbnRlbF93YWtlcmVmX2NvdW50ICp3YywKPiArCQkJ ICAgICAgYm9vbCAoKmZuKShzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9jb3VudCAqd2MpKTsKPiArdm9p ZCBfX2ludGVsX3dha2VyZWZfcHV0X29uY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUs Cj4gKwkJCSAgICAgIHN0cnVjdCBpbnRlbF93YWtlcmVmX2NvdW50ICp3YywKPiArCQkJICAgICAg Ym9vbCAoKmZuKShzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9jb3VudCAqd2MpKTsKPiArCj4gK3N0YXRp YyBpbmxpbmUgdm9pZAo+ICtpbnRlbF93YWtlcmVmX2dldF9vbmNlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICppOTE1LAo+ICsJCSAgICAgICBzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9jb3VudCAqd2Ms Cj4gKwkJICAgICAgIGJvb2wgKCpmbikoc3RydWN0IGludGVsX3dha2VyZWZfY291bnQgKndjKSkK CldoYXQgZG9lcyB0aGUgIm9uY2UiIHN1ZmZpeCByZWZlciB0byBoZXJlPyBUaGF0IGl0IHdpbGwg b25seSBjYWxsIHRoZSAKY2FsbGJhY2sgb25jZT8gSXMgdGhhdCBuZWVkZWQgaW4gdGhlIGZ1bmN0 aW9uIG5hbWUgYW5kIGNvdWxkbid0IGJlIApkb2N1bWVudGVkIGluIGtlcm5lbGRvYywgZ2l2ZW4g aG93IHRoZXJlIGlzIG5vIG5vbi1zdWZmaXhlZCB2ZXJzaW9uPwoKPiArewo+ICsJaWYgKHVubGlr ZWx5KCFhdG9taWNfaW5jX25vdF96ZXJvKCZ3Yy0+Y291bnQpKSkKPiArCQlfX2ludGVsX3dha2Vy ZWZfZ2V0X29uY2UoaTkxNSwgd2MsIGZuKTsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSB2b2lk Cj4gK2ludGVsX3dha2VyZWZfcHV0X29uY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUs Cj4gKwkJICAgICAgIHN0cnVjdCBpbnRlbF93YWtlcmVmX2NvdW50ICp3YywKPiArCQkgICAgICAg Ym9vbCAoKmZuKShzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9jb3VudCAqd2MpKQo+ICt7Cj4gKwlpZiAo YXRvbWljX2RlY19hbmRfbXV0ZXhfbG9jaygmd2MtPmNvdW50LCAmd2MtPm11dGV4KSkKPiArCQlf X2ludGVsX3dha2VyZWZfcHV0X29uY2UoaTkxNSwgd2MsIGZuKTsKPiArfQo+ICsKPiArc3RhdGlj IGlubGluZSB2b2lkCj4gK2ludGVsX3dha2VyZWZfbG9jayhzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9j b3VudCAqd2MpCj4gKwlfX2FjcXVpcmVzKHdjLT5tdXRleCkKPiArewo+ICsJbXV0ZXhfbG9jaygm d2MtPm11dGV4KTsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSB2b2lkCj4gK2ludGVsX3dha2Vy ZWZfdW5sb2NrKHN0cnVjdCBpbnRlbF93YWtlcmVmX2NvdW50ICp3YykKPiArCV9fcmVsZWFzZXMo d2MtPm11dGV4KQo+ICt7Cj4gKwltdXRleF91bmxvY2soJndjLT5tdXRleCk7Cj4gK30KPiArCj4g K3N0YXRpYyBpbmxpbmUgYm9vbAo+ICtpbnRlbF93YWtlcmVmX2FjdGl2ZShzdHJ1Y3QgaW50ZWxf d2FrZXJlZl9jb3VudCAqd2MpCj4gK3sKPiArCXJldHVybiBhdG9taWNfcmVhZCgmd2MtPmNvdW50 KTsKPiArfQo+ICsKPiArI2VuZGlmIC8qIElOVEVMX1dBS0VSRUZfSCAqLwo+IAoKUmVnYXJkcywK ClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=