From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9EE4EDB7CC for ; Tue, 7 Apr 2026 08:36:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE76B10E374; Tue, 7 Apr 2026 08:36:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WGWXL8QV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80CD610E362; Tue, 7 Apr 2026 08:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775550976; x=1807086976; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=GvyEVTPnOWj9KTDP+ZLoUn5XaTQVPf0nAgefxrWr3ks=; b=WGWXL8QVxXYec060v/xvJ8XIYmtsv/6qkYJUhxnI4McY58C5+Nud5wr6 9QCjKqb1QK6Ikhx9X9c5NEJURXxtfyOQfvx7jq7UoVR0ZrhTi/sSus+VV hnTl3lE3TSZvUKYUPO0oXEPfq9dQ5F0vnpimQFNrhNyUsntP24WXwa/oN u9XljcQwzkQ5319EcYu8zSfI6bSENWjjrqihyiqOmqpfev7MZDOiFD+rA jr00XFpM7kke47PZD7pG+MEJRNwxNBQECDJntxiMLPEZ6hOpu8hUd6AHE Qc56Ilsb0d34kxolGXcmPVjFEb/CDoP+hRB1Y42Q7L8zrcZrITFwzTbxr g==; X-CSE-ConnectionGUID: GlLb4d6JQBCtrnWKjBS+9Q== X-CSE-MsgGUID: KxakIogXSqqMOh4qHSUlig== X-IronPort-AV: E=McAfee;i="6800,10657,11751"; a="101962611" X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208";a="101962611" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 01:36:15 -0700 X-CSE-ConnectionGUID: Z8t1M/ETR62gVMd95GjOIA== X-CSE-MsgGUID: p760aFXhT1aZ+qgp2QHAoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208";a="251246646" Received: from mjarzebo-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.244]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 01:36:12 -0700 From: Jani Nikula To: Suraj Kandpal , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: sowmiya.s@intel.com, uma.shankar@intel.com, swati2.sharma@intel.com, chaitanya.kumar.borah@intel.com, arun.r.murthy@intel.com, Suraj Kandpal Subject: Re: [PATCH v3 22/26] drm/i915/writeback: Enable writeback interrupts In-Reply-To: <20260325110744.1096786-23-suraj.kandpal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260325110744.1096786-1-suraj.kandpal@intel.com> <20260325110744.1096786-23-suraj.kandpal@intel.com> Date: Tue, 07 Apr 2026 11:36:08 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 25 Mar 2026, Suraj Kandpal wrote: > Enable writeback interrupts while enabling writeback > and define the isr handler and schedule work for later > to signal completion job. > > Signed-off-by: Suraj Kandpal > --- > .../gpu/drm/i915/display/intel_display_irq.c | 10 ++++ > .../gpu/drm/i915/display/intel_display_regs.h | 1 + > .../gpu/drm/i915/display/intel_writeback.c | 50 +++++++++++++++++++ > .../gpu/drm/i915/display/intel_writeback.h | 1 + > 4 files changed, 62 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c > index 70c1bba7c0a8..656fb314b985 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_irq.c > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c > @@ -29,6 +29,8 @@ > #include "intel_pmdemand.h" > #include "intel_psr.h" > #include "intel_psr_regs.h" > +#include "intel_writeback.h" > +#include "intel_writeback_reg.h" Unused. > > static void irq_reset(struct intel_display *display, struct i915_irq_regs regs) > { > @@ -1281,6 +1283,11 @@ gen8_de_misc_irq_handler(struct intel_display *display, u32 iir) > found = true; > } > > + if (iir & (GEN8_DE_MISC_WD0)) { > + intel_writeback_isr_handler(display); > + found = true; > + } > + > if (iir & GEN8_DE_EDP_PSR) { > struct intel_encoder *encoder; > u32 psr_iir; > @@ -2337,6 +2344,9 @@ void gen8_de_irq_postinstall(struct intel_display *display) > if (DISPLAY_VER(display) < 11) > de_misc_masked |= GEN8_DE_MISC_GSE; > > + if (DISPLAY_VER(display) >= 13) > + de_misc_masked |= GEN8_DE_MISC_WD0; > + > if (display->platform.geminilake || display->platform.broxton) > de_port_masked |= BXT_DE_PORT_GMBUS; > > diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h b/drivers/gpu/drm/i915/display/intel_display_regs.h > index 4746e9ebd920..e637b10597c2 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_regs.h > +++ b/drivers/gpu/drm/i915/display/intel_display_regs.h > @@ -1495,6 +1495,7 @@ > #define XELPDP_RM_TIMEOUT REG_BIT(29) > #define XELPDP_PMDEMAND_RSPTOUT_ERR REG_BIT(27) > #define GEN8_DE_MISC_GSE REG_BIT(27) > +#define GEN8_DE_MISC_WD0 REG_BIT(23) > #define GEN8_DE_EDP_PSR REG_BIT(19) > #define XELPDP_PMDEMAND_RSP REG_BIT(3) > #define XE2LPD_DBUF_OVERLAP_DETECTED REG_BIT(1) > diff --git a/drivers/gpu/drm/i915/display/intel_writeback.c b/drivers/gpu/drm/i915/display/intel_writeback.c > index 54e74450e080..864d4a28de10 100644 > --- a/drivers/gpu/drm/i915/display/intel_writeback.c > +++ b/drivers/gpu/drm/i915/display/intel_writeback.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #include "intel_atomic.h" > #include "intel_connector.h" > @@ -323,6 +324,20 @@ void intel_writeback_atomic_commit(struct intel_atomic_state *state) > } > } > > +static void > +intel_writeback_enable_interrupts(struct intel_display *display, > + enum transcoder trans) > +{ > + u32 tmp; > + > + tmp = intel_de_read(display, WD_IIR(trans)); > + intel_de_write_fw(display, WD_IIR(trans), tmp); > + > + tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT | > + WD_VBLANK_INT | WD_CAPTURING_INT); > + intel_de_write(display, WD_IMR(trans), tmp); > +} > + > static void intel_writeback_enable_encoder(struct intel_atomic_state *state, > struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > @@ -348,6 +363,7 @@ static void intel_writeback_enable_encoder(struct intel_atomic_state *state, > fb = job->fb; > hactive = adjusted_mode->hdisplay; > vactive = adjusted_mode->vdisplay; > + intel_writeback_enable_interrupts(display, trans); > > /* Configure WD_STRIDE, WD_SURF and WD_TAIL_CFG */ > /* Enable Planes, Pipes and Transcoder */ > @@ -509,6 +525,40 @@ intel_writeback_get_hw_state(struct intel_encoder *encoder, > return true; > } > > +void intel_writeback_isr_handler(struct intel_display *display) > +{ > + struct intel_encoder *encoder; > + struct intel_writeback_connector *wb_conn; > + struct intel_crtc *crtc; > + u32 iir; > + > + for_each_intel_encoder(display->drm, encoder) { > + if (encoder->type != INTEL_OUTPUT_WRITEBACK) > + continue; > + > + wb_conn = enc_to_intel_writeback_connector(encoder); > + if (!wb_conn->job) { > + drm_err(display->drm, "No writeback job for the connector\n"); > + continue; > + } > + > + crtc = intel_crtc_for_pipe(display, wb_conn->pipe); > + iir = intel_de_read(display, WD_IIR(wb_conn->trans)); > + if (iir & WD_GTT_FAULT_INT) > + drm_err(display->drm, " GTT fault during writeback\n"); > + if (iir & WD_WRITE_COMPLETE_INT) > + drm_dbg_kms(display->drm, "Writeback job write completed\n"); > + if (iir & WD_VBLANK_INT) { > + drm_crtc_handle_vblank(&crtc->base); > + drm_dbg_kms(display->drm, "Writeback vblank raised\n"); > + } > + if (iir & WD_CAPTURING_INT) > + drm_dbg_kms(display->drm, "Writeback job capture has started\n"); > + > + intel_de_write(display, WD_IIR(wb_conn->trans), iir); > + } > +} > + > int intel_writeback_init(struct intel_display *display) > { > struct intel_encoder *encoder; > diff --git a/drivers/gpu/drm/i915/display/intel_writeback.h b/drivers/gpu/drm/i915/display/intel_writeback.h > index 3c145cf73e20..83a986753c4c 100644 > --- a/drivers/gpu/drm/i915/display/intel_writeback.h > +++ b/drivers/gpu/drm/i915/display/intel_writeback.h > @@ -16,6 +16,7 @@ struct intel_writeback_connector; > > int intel_writeback_init(struct intel_display *display); > void intel_writeback_atomic_commit(struct intel_atomic_state *state); > +void intel_writeback_isr_handler(struct intel_display *display); > > #endif /* __INTEL_WRITEBACK_H__ */ -- Jani Nikula, Intel