Re: [PATCH 1/3] drm/i915/power: move enum skl_power_gate under display

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jun 25, 2025 at 03:39:36PM +0300, Jani Nikula wrote:
> When the display registers were split off from i915_reg.h, enum
> skl_power_gate was left behind. Move it to intel_display_regs.h.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_regs.h |  9 +++++++++
>  drivers/gpu/drm/i915/i915_reg.h                   | 10 ----------
>  2 files changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h b/drivers/gpu/drm/i915/display/intel_display_regs.h
> index e101105da4af..fdac72fcebee 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_regs.h
> @@ -2195,6 +2195,15 @@
>  #define   HSW_PWR_WELL_FORCE_ON			(1 << 19)
>  #define HSW_PWR_WELL_CTL6			_MMIO(0x45414)
>  
> +/* SKL Fuse Status */
> +enum skl_power_gate {
> +	SKL_PG0,
> +	SKL_PG1,
> +	SKL_PG2,
> +	ICL_PG3,
> +	ICL_PG4,
> +};
> +
>  #define SKL_FUSE_STATUS				_MMIO(0x42000)
>  #define  SKL_FUSE_DOWNLOAD_STATUS		(1 << 31)
>  /*
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 04fb40867cc0..cec6e2e2a262 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1204,16 +1204,6 @@
>   */
>  #define GEN7_SO_WRITE_OFFSET(n)		_MMIO(0x5280 + (n) * 4)
>  
> -/* SKL Fuse Status */
> -enum skl_power_gate {
> -	SKL_PG0,
> -	SKL_PG1,
> -	SKL_PG2,
> -	ICL_PG3,
> -	ICL_PG4,
> -};
> -
> -
>  #define GEN9_TIMESTAMP_OVERRIDE				_MMIO(0x44074)
>  #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_SHIFT	0
>  #define  GEN9_TIMESTAMP_OVERRIDE_US_COUNTER_DIVIDER_MASK	0x3ff
> -- 
> 2.39.5
>