intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm/i915: Some universal plane fixes and cleanups
Date: Tue, 28 Oct 2025 22:58:59 +0200	[thread overview]
Message-ID: <aQEuk8vuRdYV6ZRF@intel.com> (raw)
In-Reply-To: <CAJ=qYWTASBWWFCDpL4pWkjyMhN9ZUCqEHYdb+hBy8bmXMhLBLQ@mail.gmail.com>

On Tue, Oct 28, 2025 at 11:36:18AM +0200, Juha-Pekka Heikkilä wrote:
> Set is
> 
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> 
> Only thing I was wondering about is that cbcr handling with that plane
> min width but I assume you've tested it works as we're not getting
> much of ci results for these.

The actual limits aren't changing here so not much to test in that
sense. I've never actually tested to see what happens if the plane is
below that w/a min width, but IIRC from reading the hsd the problem
was more along the linds of extra power draw rather than underrun/etc.

> 
> /Juha-Pekka
> 
> On Fri, Oct 10, 2025 at 12:13 AM Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Fix up some of the universal plane min size handling, and do
> > a bit of random cleanup.
> >
> > Ville Syrjälä (8):
> >   drm/i915: Rewrite icl_min_plane_width()
> >   drm/i915: Drop the min plane width w/a adl+
> >   drm/i915: Implement .min_plane_width() for PTL+
> >   drm/i915: Start checking plane min size for the chroma plane
> >   drm/i915: Introduce intel_plane_min_height()
> >   drm/i915: Remove pointless crtc hw.enable check
> >   drm/i915: Extract glk_plane_has_planar()
> >   drm/i915: Unify the logic in {skl,glk}_plane_has_*()
> >
> >  .../drm/i915/display/skl_universal_plane.c    | 94 +++++++++----------
> >  1 file changed, 44 insertions(+), 50 deletions(-)
> >
> > --
> > 2.49.1
> >

-- 
Ville Syrjälä
Intel

      reply	other threads:[~2025-10-28 20:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 21:13 [PATCH 0/8] drm/i915: Some universal plane fixes and cleanups Ville Syrjala
2025-10-09 21:13 ` [PATCH 1/8] drm/i915: Rewrite icl_min_plane_width() Ville Syrjala
2025-10-09 21:13 ` [PATCH 2/8] drm/i915: Drop the min plane width w/a adl+ Ville Syrjala
2025-10-09 22:38   ` Matt Roper
2025-10-10 23:33     ` Ville Syrjälä
2025-10-09 21:13 ` [PATCH 3/8] drm/i915: Implement .min_plane_width() for PTL+ Ville Syrjala
2025-10-09 21:13 ` [PATCH 4/8] drm/i915: Start checking plane min size for the chroma plane Ville Syrjala
2025-10-09 21:13 ` [PATCH 5/8] drm/i915: Introduce intel_plane_min_height() Ville Syrjala
2025-10-09 21:13 ` [PATCH 6/8] drm/i915: Remove pointless crtc hw.enable check Ville Syrjala
2025-10-09 21:13 ` [PATCH 7/8] drm/i915: Extract glk_plane_has_planar() Ville Syrjala
2025-10-09 21:13 ` [PATCH 8/8] drm/i915: Unify the logic in {skl,glk}_plane_has_*() Ville Syrjala
2025-10-09 22:41 ` ✗ i915.CI.BAT: failure for drm/i915: Some universal plane fixes and cleanups Patchwork
2025-10-12 19:39 ` ✓ i915.CI.BAT: success for drm/i915: Some universal plane fixes and cleanups (rev2) Patchwork
2025-10-28  9:36 ` [PATCH 0/8] drm/i915: Some universal plane fixes and cleanups Juha-Pekka Heikkilä
2025-10-28 20:58   ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQEuk8vuRdYV6ZRF@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).