From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BE81CFD2F6 for ; Sat, 29 Nov 2025 20:34:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC6F410E221; Sat, 29 Nov 2025 20:34:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="S8KbGkfj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE32010E220; Sat, 29 Nov 2025 20:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764448442; x=1795984442; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kU1QuoIkQDS8CxvKL6NvEr+zykBqz2/Z+pCc/nSb8Wk=; b=S8KbGkfjpClqj/+coJglkgP7jhJFMsHPAiJjebwvx0LDFjHUnCOvQD7X 8qLWzZrHC775MrReUUUQTMpmQCsAmYH6DSVhgTa5xtJsuC4liBfysvMIM 01TLobfyML7G7OZJQxWYRc7W75gbnn2kwY6dYlN6+4UV+5WhDPSvNAQ5d +t97vNhdH9hmsVT7JPE2PerLSvsg/ALAzutrZwbuBGKXP0Bw5yg/S/w8h Si+Pz89m/ZL3zXv6gu9jWNBqm1tQOfUKMuFcn6dZ/dWsdsVy4bgNSSqU4 E+hD7SZ//K8PgCSJsIpn49TWSQRNc5GLW/E4E1nMkEcca0rprIlO0k3G1 w==; X-CSE-ConnectionGUID: IgLaLxQLRtKInM+EzJEbwQ== X-CSE-MsgGUID: MFiZx1hDSqGOr9sVqDmIDA== X-IronPort-AV: E=McAfee;i="6800,10657,11628"; a="77062514" X-IronPort-AV: E=Sophos;i="6.20,237,1758610800"; d="scan'208";a="77062514" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2025 12:34:02 -0800 X-CSE-ConnectionGUID: pTPPe07hSIajirdMDWsVVQ== X-CSE-MsgGUID: IGjX9ZOMShyrrAa+vUUvbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,237,1758610800"; d="scan'208";a="193503327" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.50]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2025 12:33:57 -0800 Date: Sat, 29 Nov 2025 22:33:55 +0200 From: Andy Shevchenko To: "Yury Norov (NVIDIA)" Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Message-ID: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Nov 29, 2025 at 10:24:55PM +0200, Andy Shevchenko wrote: > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote: > > The macro is related to sysfs, but is defined in kernel.h. Move it to > > the proper header, and unload the generic kernel.h. > > Tough guy :-) > I hope it builds well in your case. > > FWIW, > https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@linux.intel.com/ > https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@ionos.com/ > https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@ionos.com/ > > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 > Reviewed-by: Andy Shevchenko Actually, one thing should be fixed, i.e. Documentation/filesystems/sysfs.rst:123:Note as stated in include/linux/kernel.h "OTHER_WRITABLE? ... -- With Best Regards, Andy Shevchenko