From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DFE1CFD376 for ; Sun, 30 Nov 2025 17:56:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72E2010E271; Sun, 30 Nov 2025 17:56:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VCEjOgF9"; dkim-atps=neutral Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CEF610E271 for ; Sun, 30 Nov 2025 17:56:07 +0000 (UTC) Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-640d0895d7cso4284573d50.1 for ; Sun, 30 Nov 2025 09:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764525366; x=1765130166; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wUD/yBt9NZ9+A9XDWEgi0gEwekBnc6bPrryNuMfZMEw=; b=VCEjOgF98hn6/IN0XXwNpF53NKJrJB1g4YEq0mc0xoO6qROdVAl3fCOQhIRiFmahBc f3ICQE/BzUyBCummkp90vktmBeaDckpUpg32lB58VWAlEuHWf4rbM+JuPOj8+fn90kDR dKZ5td8HMmFHQuSI4V92shbI8LaHSeFR43q+FUh/5uQMopPOqMyaHu7nZsrNFi81LwDC qsg+e9uHjHeGVeZwK0pOl43IaOidLuWJZw+BNB/XH/r/YD5ue6ZtbVD5wzB8LSnWV2gL s1lCATxTXoFiHxDU0/uht+FBOwGTRbYo9gvJXTLAV17hjmmIJfKDErm2SWG3JIS2mNmo o8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764525366; x=1765130166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wUD/yBt9NZ9+A9XDWEgi0gEwekBnc6bPrryNuMfZMEw=; b=QQTcczZ420sKNK6oKCppqdIcrPXnieQgwTyGVZXJEIPRurDnsW8wfyuxZhtSP/eEnU +pCYeYPuikA5A6FFX1QwrUCIMygLkEdcpa+qLvoJwvYOKJ5SQQaMoFLY+xWkPuFQ8WN6 wEF9K4h47TxuEHV+6Pz2Fl4EBRxAywjmuV8qFp/KxvYPP3WOB2nb/YYEZLILJk6QrRIJ +zibLW2/HsovB962gJdDN9nIeNNn1E51uSY+L/0p+fO7TBruPIUG+UD0pvnls18pQ8/J Hv9ZxBnX8MBb5Due5TdtzhrkxN+ZLlAOb1QoD7UP0y93elTY62uatn2KD5Z8ziBvcVTg DI5Q== X-Forwarded-Encrypted: i=1; AJvYcCXeBB/B2U6rkjoRDTbdlejBXpd5wOaU7rFzLn2bf6MdIvo3AZopNyHLsE/3+D/xRmiy5gSaXJRJgu8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwqKvx53TrXzrQs/PYL2nec4OGe8KS8MbYR/VRx6wO6RdGEc/nc JqzBYAa8BVWytul6WUMrhQQC1XT0MngZo1sMdp/6fBwpevgxBo30iSE1 X-Gm-Gg: ASbGncvMF562RD/dD7qh05GAPkkUR9uiV9BBRstgW7JlXGHzynO7tD/YCSamjFo0e5E zKIMoJXiVaySAeZnqt3OUfZY0aPPRa4RZRtdrOwn17jnl5DGQzBfNDfY23FOPg7GvgbwfvUROl6 2sECmoFv3GaXHLuFoC/l/HSXl06tewtsCqOdA6oxDp+auZlTytthdnxLRZupDE4DcOC6or8LKIu vUQX3NJwaKyviP03J3LPr+JnaqJX7Sz2IJTtj9Ns6k9ONZTj1o7ScieUnfZScjS7mKFKj7oV6h+ NRNW5C/Q5N9iyZa2J/HIvfj9YGOmLAxNcATelKb4//B3rbWimgttgMydbrGCxqa0iPmksesBmy1 jwErhqyf+efaABswLhqPG1T6nkASW0+DDYxXQgVK17ljMHTnL3mkqvlm92e3xjA+MZUq/r7f87h G7UlPG04E= X-Google-Smtp-Source: AGHT+IFazktIfCN3qlxWEck8ZBpdX6Q85L5F/mb8r4CtsaC7PGh9ijpwS9MHVlr3YNeQOBcTLxwxaw== X-Received: by 2002:a05:690e:1483:b0:640:d1cc:2be7 with SMTP id 956f58d0204a3-642f8e41c16mr30276137d50.30.1764525366495; Sun, 30 Nov 2025 09:56:06 -0800 (PST) Received: from localhost ([2601:346:0:79bd:b42b:4ad9:10af:cabc]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6433c4692a2sm3805357d50.17.2025.11.30.09.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 09:56:06 -0800 (PST) Date: Sun, 30 Nov 2025 12:56:05 -0500 From: Yury Norov To: Andy Shevchenko Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Message-ID: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Nov 29, 2025 at 10:35:54PM +0200, Andy Shevchenko wrote: > On Sat, Nov 29, 2025 at 10:34:02PM +0200, Andy Shevchenko wrote: > > On Sat, Nov 29, 2025 at 10:24:55PM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote: > > > > The macro is related to sysfs, but is defined in kernel.h. Move it to > > > > the proper header, and unload the generic kernel.h. > > > > > > Tough guy :-) > > > I hope it builds well in your case. > > > > > > FWIW, > > > https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@linux.intel.com/ > > > https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@ionos.com/ > > > https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@ionos.com/ > > > > > > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 > > > Reviewed-by: Andy Shevchenko > > > > Actually, one thing should be fixed, i.e. > > Documentation/filesystems/sysfs.rst:123:Note as stated in include/linux/kernel.h "OTHER_WRITABLE? ... > > And just in case, look into > https://lore.kernel.org/r/20251126214709.2322314-1-andriy.shevchenko@linux.intel.com Sure. Please find attached. >From 8b08bfd1d4b885bffb67c548d17d98760ca06e76 Mon Sep 17 00:00:00 2001 From: "Yury Norov (NVIDIA)" Date: Sun, 30 Nov 2025 12:50:11 -0500 Subject: [PATCH] sysfs: Align update documentation This series moves VERIFY_OCTAL_PERMISSIONS() from linux/kernel.h to linux/sysfs.h. Update documentation accordingly Suggested-by: Andy Shevchenko Signed-off-by: Yury Norov (NVIDIA) --- Documentation/filesystems/sysfs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/filesystems/sysfs.rst b/Documentation/filesystems/sysfs.rst index 2703c04af7d0..ffcef4d6bc8d 100644 --- a/Documentation/filesystems/sysfs.rst +++ b/Documentation/filesystems/sysfs.rst @@ -120,7 +120,7 @@ is equivalent to doing:: .store = store_foo, }; -Note as stated in include/linux/kernel.h "OTHER_WRITABLE? Generally +Note as stated in include/linux/sysfs.h "OTHER_WRITABLE? Generally considered a bad idea." so trying to set a sysfs file writable for everyone will fail reverting to RO mode for "Others". -- 2.43.0