From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B955ACFD376 for ; Sun, 30 Nov 2025 18:16:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16F1010E270; Sun, 30 Nov 2025 18:16:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AXfSdG70"; dkim-atps=neutral Received: from mail-yx1-f41.google.com (mail-yx1-f41.google.com [74.125.224.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD5B310E275 for ; Sun, 30 Nov 2025 18:16:21 +0000 (UTC) Received: by mail-yx1-f41.google.com with SMTP id 956f58d0204a3-63f96d5038dso2735663d50.1 for ; Sun, 30 Nov 2025 10:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764526580; x=1765131380; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bPTHL8VwtfKfk45TFU08paMyal7EO1gfKoy+e7omzHs=; b=AXfSdG70wwg+NJSOTf8MqnNpq263+h4TqLmU7bSpjQ866yjC4LEAJVLutx+FxwO18x Buxly7vqg8bNMWjdEB9E7kcL9AxH8qKSWWj1t0KqI4X5UREF0+aVLekRdEL/vFS8X0uG wjv7J75BFd7YluEGLSeIXXjQ2Mn+0hw5jh7L8dYI7XQeuTJjy5eY2bWkwm55a0hQmirp QBH7/UVM1LzydFMdmlwBqOXRF7rCtD+yWVKZvcMIy/+eufjI8KF0NVJ7nx/cUygVuYMB 7r1P8nxmkjZVKbkXFniQ+Yil2Vp7xv162g7+wAfvSMxGNE4YW6fxdr6pj7X3Kox6xBHS 6Bog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764526580; x=1765131380; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bPTHL8VwtfKfk45TFU08paMyal7EO1gfKoy+e7omzHs=; b=qPjCczaeGTpxHiTb/bRnSsk7xpQSSweL/G93LcWzNfe3vWFWfS9eAMu5nFUc3qw6l0 AkmyJElZGgxgL9w/gfLlrKGAib6xNBWJXJDOHpzHFmsjsKZ1Jz877xoA1AVAZeOgqI84 wc5rvX7uCRFwiUwGrrMfH03FNxFn2kqTgZu+c7kEvce9xhHPZZ9qoJadXl/egeuW5fge 1y4htbQd5XSDCb8eEdOzRtpk6c7x5XDoJ3cZmdAHFSWG56EotGugCWoNex5VVfdRNFx+ Hk+y1crU3LyCXLWw4iFCEVWhcC1x6mWB1/5fYstjLYyNpJrEph99DMNqJ3MNah9AvGsp 2kSA== X-Forwarded-Encrypted: i=1; AJvYcCVqZgnCcnbsnOZe4iy53kjg31vzfC61qRypwps6A2HGvQA9k8eiw6y17i6qWZw94mCrJEHZLtUnrS8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzsMC8Gw0DiTzfX8zTYWzNNkbQBQZKM2tXihu0zrdnoSHbhjxK/ BhTfnkQGgaHE4k+KrPktYnej4vVT4/cU1nxgNoWueQPIFyNGc6pbggfo X-Gm-Gg: ASbGnculQ14Fd+6+Vz9AJCcECvuRBodReQV7tk9prUutG+nq9PMrn3YfX6W6DkkKHrg /toWQnEJl8YBrdpzd7dWpcPxqdzEGRRVi/6+tpUyBnmk3Iq0un25iTobX5zFop2cT+X/b/B9xOp jOZS/Gnz6o5gSN/GIQYqlupx2ugCDVO8v/s/GhHs5+6KkEWU7j7ZcQ+nAJCvsm0gXddF8GeYsQh 8fmyLu19Fpb3I9ow6XiRJ5PuSkZqsrVWZ4CFqA+cR+dwhty6UXC6AK6+Mn+bwg96cPXKd5BLfQr drmm9yZ4OyZI/G5xOyp+fEdXcqp4GjXEl4NrZPLoNjHfcQWkWIXRpKOaTpj+iZaob60uafm+DcY Wofd/kCmBRN5LRx4y/fFWuzR9jMdqtQ/TDH+wVTBzeTDYid0yhPV3zDSPGJNdTE8Qy8seBiDpG8 w9MmhhoDPyvYKjEibp2A== X-Google-Smtp-Source: AGHT+IEQcHwA7T6ktmCXafon70hVlddeX9BaPXERtnLHGkMmTox+ufRP6CsVlNJn8W2ToaNF/lgtHw== X-Received: by 2002:a53:acc9:0:10b0:63f:beb2:9519 with SMTP id 956f58d0204a3-64302a2fb59mr21422815d50.5.1764526580498; Sun, 30 Nov 2025 10:16:20 -0800 (PST) Received: from localhost ([2601:346:0:79bd:b42b:4ad9:10af:cabc]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78ad0d603f5sm39289087b3.19.2025.11.30.10.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 10:16:20 -0800 (PST) Date: Sun, 30 Nov 2025 13:16:19 -0500 From: Yury Norov To: Andy Shevchenko Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tracing: move tracing declarations from kernel.h to a dedicated header Message-ID: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Nov 29, 2025 at 10:30:23PM +0200, Andy Shevchenko wrote: > On Sat, Nov 29, 2025 at 02:53:02PM -0500, Yury Norov (NVIDIA) wrote: > > Tracing is a half of the kernel.h in terms of LOCs, although it's a > > self-consistent part. Move it to a separate header. > > > > This is a pure move, except for removing a few 'extern's. > > Yeah, I also have something similar (but half-baked) locally, the Q I wanted to > ask is why a separate header? We have already some of tracing headers. Doesn't > suit well? Just as said in the commit message - this part is more or less self-consistent and debugging-oriented. If someone needs to just throw trace_printk() in their driver, they will not have to pull all the heavy tracing machinery. > ... > > > --- a/include/linux/kernel.h > > +++ b/include/linux/kernel.h > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > > +#include > > There is better place for t*.h, i.e. after static_call_types.h. They are poorly sorted for seemingly no good reason. I found the first t*.h and just put this header next to it. Don't think that placing it next to static_call_types.h is any better or worse. > Btw, have you tried to sort alphabetically the bulk in the kernel.h after > your series. Does it still build? (Just wondering about state of affairs > with the possible cyclic dependencies.) I didn't try. Sorting #include's is not the purpose of the series. Thanks, Yury