From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47FE3D3F084 for ; Wed, 28 Jan 2026 15:56:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1D6710E72A; Wed, 28 Jan 2026 15:56:12 +0000 (UTC) Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by gabe.freedesktop.org (Postfix) with ESMTPS id D808210E72A; Wed, 28 Jan 2026 15:56:11 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 4EE732009D17; Wed, 28 Jan 2026 16:49:05 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 3BA7E32CA5; Wed, 28 Jan 2026 16:49:05 +0100 (CET) Date: Wed, 28 Jan 2026 16:49:05 +0100 From: Lukas Wunner To: Atharva Tiwari Cc: Ard Biesheuvel , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Thomas Zimmermann , Javier Martinez Canillas , "Borislav Petkov (AMD)" , Lenny Szubowicz , Francesco Pompo , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's Message-ID: References: <20260128145855.1071-1-atharvatiwarilinuxdev@gmail.com> <20260128145855.1071-3-atharvatiwarilinuxdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128145855.1071-3-atharvatiwarilinuxdev@gmail.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 28, 2026 at 02:58:38PM +0000, Atharva Tiwari wrote: > Disable display on iMacs, as they can't do link training > on the internal display. > > (tested on iMac20,1) So with your patch the screen is black on those iMacs? I don't quite understand why that would be desirable. What happens without this patch? Something worse than a black screen? This needs to be explained in the commit message so that reviewers understand why the patch is needed. I also don't understand why this patch follows the EFI set_os one. What's the connection between those two patches? If there is none, they shouldn't be submitted as a series but as two individual patches. Thanks, Lukas