From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61746D3F081 for ; Wed, 28 Jan 2026 15:51:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E48BD10E723; Wed, 28 Jan 2026 15:51:12 +0000 (UTC) X-Greylist: delayed 344 seconds by postgrey-1.36 at gabe; Wed, 28 Jan 2026 15:51:11 UTC Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5270B10E6EE; Wed, 28 Jan 2026 15:51:11 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id B820B20091A5; Wed, 28 Jan 2026 16:45:25 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id A8116351C5; Wed, 28 Jan 2026 16:45:25 +0100 (CET) Date: Wed, 28 Jan 2026 16:45:25 +0100 From: Lukas Wunner To: Atharva Tiwari Cc: Ard Biesheuvel , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Javier Martinez Canillas , Thomas Zimmermann , "Borislav Petkov (AMD)" , Francesco Pompo , Lenny Szubowicz , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices Message-ID: References: <20260128145855.1071-1-atharvatiwarilinuxdev@gmail.com> <20260128145855.1071-2-atharvatiwarilinuxdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128145855.1071-2-atharvatiwarilinuxdev@gmail.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 28, 2026 at 02:58:37PM +0000, Atharva Tiwari wrote: > Make apple-set-os run on all macs, as > apple-set-os is needed to use eGPUs and iGPU. As discussed previously, your patch will regress older MacBook Airs which use SPI to access keyboard + trackpad if the set_os protocol is invoked: https://lore.kernel.org/all/ZoJPgSlZJ3ZlU2zL@wunner.de/ The last time this topic came up, I suggested counting the number of GPUs instead of using the DMI quirk. I even provided a patch but nobody with an eGPU bothered to test it, so the thread fizzled out: https://lore.kernel.org/all/Z6paeFrjdv7L3mtv@wunner.de/ Maybe you could give it a spin and verify if it fixes the issue for you? Thanks, Lukas