From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7AB2EFB818 for ; Tue, 24 Feb 2026 09:04:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AC0410E521; Tue, 24 Feb 2026 09:04:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CTzxjq83"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1809110E521; Tue, 24 Feb 2026 09:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771923843; x=1803459843; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7SOOx1WyxporpiLiNMC8H1UjdyFNaBuj9kbMC3LI3qQ=; b=CTzxjq83QUMUWJy78kSlEvmsTMybyhlfK0aYMfGVjExF3ntbsXrTqYMU FzL8AMlBP0TR61jjnWXfIG4rcKGcB6u8jTVFWltJpoQe7sQDX6T/uVavs bPoX9qhKEII7+TFTtCeIwlLqT9EgohzOj+5gXkBG3JP2reVhX+96cm/Hw MbYKyFr6xRMHO5SQvArFFyJS46RrSHj6WgQ0IbJTQX3JskZxzkqHJn0yU l19nZwQHXacWlRJ7yeXhMkhxnTHJXy3ICCtSK74iG17XjnvgSeZahQyXt IdIRiYW+Qof0bavq6qEBEakVaxfAKtDlQoyB+Nk0Ak46p2NJWAz+zRDp8 Q==; X-CSE-ConnectionGUID: 5Km2XOmfT2e2hnWM0icv0Q== X-CSE-MsgGUID: BN92bflqSVydB73Iow4aqQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="60509973" X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="60509973" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 01:04:02 -0800 X-CSE-ConnectionGUID: MTMUPqecRcKegBEmyYrTPg== X-CSE-MsgGUID: vGD9dJu5TEuL6gkuwr8qJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="215082937" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.101]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 01:03:57 -0800 Date: Tue, 24 Feb 2026 11:03:54 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Murthy, Arun R" Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , xaver.hugl@kde.org, harry.wentland@amd.com, uma.shankar@intel.com, louis.chauvet@bootlin.com, naveen1.kumar@intel.com, ramya.krishna.yella@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Suraj Kandpal Subject: Re: [PATCH v10 0/7] User readable error codes on atomic_ioctl failure Message-ID: References: <20260223-atomic-v10-0-f59c8def2e70@intel.com> <1a4462b8-def9-4474-8382-6e99b7c8276d@intel.com> <5f04b5f1-744e-449e-9a45-00fd477256fc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Feb 24, 2026 at 02:24:42PM +0530, Murthy, Arun R wrote: > On 24-02-2026 14:16, Ville Syrjälä wrote: > > On Tue, Feb 24, 2026 at 12:46:10PM +0530, Murthy, Arun R wrote: > >> On 24-02-2026 12:37, Ville Syrjälä wrote: > >>> On Mon, Feb 23, 2026 at 03:37:39PM +0530, Murthy, Arun R wrote: > >>>> Any other comments/feedback on this? > >>> Having random strings as uabi seems like a bad idea. > >>> How would you make sure those are never changed? > >> The requirement was to have a string for logging/debugging in the UMD > >> logs and KMD/display to pass the verbose information. > >> > >> Discussions around this.[1][2] > >> > >> [1] https://hackmd.io/f3bDn3kyRUalLn4LbMfCVQ#Commit-Failure-Feedback > >> > >> [2] https://patchwork.freedesktop.org/patch/666193/?series=152276&rev=1 > > So the enum+obj_id thing there is perhaps the only thing that makes > > sense for compositors. > > > > Although I kinda doubt its actual usefulness to drive useful > > fallback logic because often the restrictions might be a combination > > of many things, and the kernel can only realistically report one of > > those things. > > > > Anyways, someone really needs to do the actual compositor > > implementation so that we could see how any of this would > > even work in practice. > Xaver is working on the compositor implementation for KWin and has > commented[3] that the API looks good. > > > [3] https://patchwork.freedesktop.org/patch/696982/?series=152275&rev=6 Until we see it I don't think there's any point in constantly spamming this series. > Thanks and Regards, > Arun R Murthy > ------------------- > > >> Thanks and Regards, > >> Arun R Murthy > >> ------------------- > >> > >>>> Thanks and Regards, > >>>> Arun R Murthy > >>>> ------------------- > >>>> > >>>> On 23-02-2026 14:45, Arun R Murthy wrote: > >>>>> EDITME: Imported from f20260210-atomic-v9-5-525c88fd2402@intel.com > >>>>> Please review before sending. > >>>>> > >>>>> The series focuses on providing a user readable error value on a failure > >>>>> in drm_atomic_ioctl(). Usually -EINVAL is returned in most of the error > >>>>> cases and it is difficult for the user to decode the error and get to > >>>>> know the real cause for the error. If user gets to know the reason for > >>>>> the error then corrective measurements can be taken up. > >>>>> > >>>>> User will have to check for the capability > >>>>> DRM_CAP_ATOMIC_ERROR_REPORTING before using this feature so as to ensure > >>>>> that the driver supports failure reporting. > >>>>> > >>>>> TODO: driver specific error codes are to be added and will be done in > >>>>> the follow-up patches. > >>>>> > >>>>> TODO: Once the series is merged the element 'reserved' used for sending > >>>>> the failure code in struct drm_mode_atomic is to changed to err_code. > >>>>> > >>>>> The IGT related changes are pushed for review @ > >>>>> https://patchwork.freedesktop.org/series/153330/ > >>>>> > >>>>> [RFC] changes for libdrm pushed for review @ > >>>>> https://gitlab.freedesktop.org/mesa/libdrm/-/merge_requests/450 > >>>>> > >>>>> To: Maarten Lankhorst > >>>>> To: suraj.kandpal@intel.com> > >>>>> To: Maxime Ripard > >>>>> To: Thomas Zimmermann > >>>>> To: David Airlie > >>>>> To: Simona Vetter > >>>>> To: Jani Nikula > >>>>> To: Rodrigo Vivi > >>>>> To: Joonas Lahtinen > >>>>> To: Tvrtko Ursulin > >>>>> To: xaver.hugl@kde.org > >>>>> To: harry.wentland@amd.com > >>>>> To: uma.shankar@intel.com > >>>>> To: louis.chauvet@bootlin.com > >>>>> To: naveen1.kumar@intel.com > >>>>> To: ramya.krishna.yella@intel.com > >>>>> Cc: dri-devel@lists.freedesktop.org > >>>>> Cc: intel-gfx@lists.freedesktop.org > >>>>> Cc: intel-xe@lists.freedesktop.org > >>>>> Signed-off-by: Arun R Murthy > >>>>> > >>>>> Signed-off-by: Arun R Murthy > >>>>> --- > >>>>> Changes in v9: > >>>>> - EDITME: describe what is new in this series revision. > >>>>> - EDITME: use bulletpoints and terse descriptions. > >>>>> - Link to v8: https://lore.kernel.org/r/20260129-atomic-v8-0-4cb7b0faa051@intel.com > >>>>> > >>>>> --- > >>>>> Arun R Murthy (7): > >>>>> drm: Define user readable error codes for atomic ioctl > >>>>> drm/atomic: Add error_code element in atomic_state > >>>>> drm/atomic: Call complete_signaling only if prepare_signaling is done > >>>>> drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl > >>>>> drm/atomic: Return user readable error in atomic_ioctl > >>>>> drm/i915/display: Error codes for async flip failures > >>>>> drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING > >>>>> > >>>>> drivers/gpu/drm/drm_atomic.c | 31 ++++++++++ > >>>>> drivers/gpu/drm/drm_atomic_uapi.c | 89 ++++++++++++++++++++-------- > >>>>> drivers/gpu/drm/drm_ioctl.c | 3 + > >>>>> drivers/gpu/drm/i915/display/intel_display.c | 25 ++++---- > >>>>> include/drm/drm_atomic.h | 10 ++++ > >>>>> include/uapi/drm/drm.h | 7 +++ > >>>>> include/uapi/drm/drm_mode.h | 37 ++++++++++++ > >>>>> 7 files changed, 165 insertions(+), 37 deletions(-) > >>>>> --- > >>>>> base-commit: cec43d5c2696af219fc2ef71dd7e93db48c80f66 > >>>>> change-id: 20250728-atomic-c9713fd357e4 > >>>>> > >>>>> Best regards, -- Ville Syrjälä Intel