From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 19/40] drm/i915: Remove debugfs/i915_ppgtt_info Date: Mon, 24 Sep 2018 13:03:16 +0100 Message-ID: References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-19-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6E5988A27 for ; Mon, 24 Sep 2018 12:04:13 +0000 (UTC) In-Reply-To: <20180919195544.1511-19-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA5LzIwMTggMjA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgaW5mb3JtYXRp b24gcHJlc2VudGVkIGhlcmUgaXMgbm90IHJlbGV2YW50IHRvIGN1cnJlbnQgZGV2ZWxvcG1lbnQu Cj4gV2UgY2FuIGVpdGhlciB1c2UgdGhlIGNvbnRleHQgaW5mb3JtYXRpb24sIGJ1dCBtb3JlIG9m dGVuIHdlIHdhbnQgdG8KPiBpbnNwZWN0IHRoZSBhY3RpdmUgZ3B1IHN0YXRlLgo+IAo+IFRoZSB1 bHRlcmlvciBtb3RpdmUgaXMgdG8gZXJhZGljYXRlIGRldi0+ZmlsZWxpc3QuCj4gCj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8IDExOSAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTE5IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggNmI1Y2MzMGYzZTA5Li4zOWYz MTljNDlkZWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2Zz LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0yMDM1 LDEyNCArMjAzNSw2IEBAIHN0YXRpYyBpbnQgaTkxNV9zd2l6emxlX2luZm8oc3RydWN0IHNlcV9m aWxlICptLCB2b2lkICpkYXRhKQo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gLXN0YXRpYyBp bnQgcGVyX2ZpbGVfY3R4KGludCBpZCwgdm9pZCAqcHRyLCB2b2lkICpkYXRhKQo+IC17Cj4gLQlz dHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4ID0gcHRyOwo+IC0Jc3RydWN0IHNlcV9maWxlICpt ID0gZGF0YTsKPiAtCXN0cnVjdCBpOTE1X2h3X3BwZ3R0ICpwcGd0dCA9IGN0eC0+cHBndHQ7Cj4g LQo+IC0JaWYgKCFwcGd0dCkgewo+IC0JCXNlcV9wcmludGYobSwgIiAgbm8gcHBndHQgZm9yIGNv bnRleHQgJWRcbiIsCj4gLQkJCSAgIGN0eC0+dXNlcl9oYW5kbGUpOwo+IC0JCXJldHVybiAwOwo+ IC0JfQo+IC0KPiAtCWlmIChpOTE1X2dlbV9jb250ZXh0X2lzX2RlZmF1bHQoY3R4KSkKPiAtCQlz ZXFfcHV0cyhtLCAiICBkZWZhdWx0IGNvbnRleHQ6XG4iKTsKPiAtCWVsc2UKPiAtCQlzZXFfcHJp bnRmKG0sICIgIGNvbnRleHQgJWQ6XG4iLCBjdHgtPnVzZXJfaGFuZGxlKTsKPiAtCXBwZ3R0LT5k ZWJ1Z19kdW1wKHBwZ3R0LCBtKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC0KPiAtc3RhdGlj IHZvaWQgZ2VuOF9wcGd0dF9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwKPiAtCQkJICAgIHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0Jc3RydWN0IGk5MTVfaHdfcHBn dHQgKnBwZ3R0ID0gZGV2X3ByaXYtPm1tLmFsaWFzaW5nX3BwZ3R0Owo+IC0Jc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lOwo+IC0JZW51bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4gLQlpbnQg aTsKPiAtCj4gLQlpZiAoIXBwZ3R0KQo+IC0JCXJldHVybjsKPiAtCj4gLQlmb3JfZWFjaF9lbmdp bmUoZW5naW5lLCBkZXZfcHJpdiwgaWQpIHsKPiAtCQlzZXFfcHJpbnRmKG0sICIlc1xuIiwgZW5n aW5lLT5uYW1lKTsKPiAtCQlmb3IgKGkgPSAwOyBpIDwgNDsgaSsrKSB7Cj4gLQkJCXU2NCBwZHAg PSBJOTE1X1JFQUQoR0VOOF9SSU5HX1BEUF9VRFcoZW5naW5lLCBpKSk7Cj4gLQkJCXBkcCA8PD0g MzI7Cj4gLQkJCXBkcCB8PSBJOTE1X1JFQUQoR0VOOF9SSU5HX1BEUF9MRFcoZW5naW5lLCBpKSk7 Cj4gLQkJCXNlcV9wcmludGYobSwgIlx0UERQJWQgMHglMDE2bGx4XG4iLCBpLCBwZHApOwo+IC0J CX0KPiAtCX0KPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQgZ2VuNl9wcGd0dF9pbmZvKHN0cnVjdCBz ZXFfZmlsZSAqbSwKPiAtCQkJICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAtewo+IC0Jc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+IC0JZW51bSBpbnRlbF9l bmdpbmVfaWQgaWQ7Cj4gLQo+IC0JaWYgKElTX0dFTjYoZGV2X3ByaXYpKQo+IC0JCXNlcV9wcmlu dGYobSwgIkdGWF9NT0RFOiAweCUwOHhcbiIsIEk5MTVfUkVBRChHRlhfTU9ERSkpOwo+IC0KPiAt CWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+IC0JCXNlcV9wcmludGYo bSwgIiVzXG4iLCBlbmdpbmUtPm5hbWUpOwo+IC0JCWlmIChJU19HRU43KGRldl9wcml2KSkKPiAt CQkJc2VxX3ByaW50ZihtLCAiR0ZYX01PREU6IDB4JTA4eFxuIiwKPiAtCQkJCSAgIEk5MTVfUkVB RChSSU5HX01PREVfR0VONyhlbmdpbmUpKSk7Cj4gLQkJc2VxX3ByaW50ZihtLCAiUFBfRElSX0JB U0U6IDB4JTA4eFxuIiwKPiAtCQkJICAgSTkxNV9SRUFEKFJJTkdfUFBfRElSX0JBU0UoZW5naW5l KSkpOwo+IC0JCXNlcV9wcmludGYobSwgIlBQX0RJUl9CQVNFX1JFQUQ6IDB4JTA4eFxuIiwKPiAt CQkJICAgSTkxNV9SRUFEKFJJTkdfUFBfRElSX0JBU0VfUkVBRChlbmdpbmUpKSk7Cj4gLQkJc2Vx X3ByaW50ZihtLCAiUFBfRElSX0RDTFY6IDB4JTA4eFxuIiwKPiAtCQkJICAgSTkxNV9SRUFEKFJJ TkdfUFBfRElSX0RDTFYoZW5naW5lKSkpOwo+IC0JfQo+IC0JaWYgKGRldl9wcml2LT5tbS5hbGlh c2luZ19wcGd0dCkgewo+IC0JCXN0cnVjdCBpOTE1X2h3X3BwZ3R0ICpwcGd0dCA9IGRldl9wcml2 LT5tbS5hbGlhc2luZ19wcGd0dDsKPiAtCj4gLQkJc2VxX3B1dHMobSwgImFsaWFzaW5nIFBQR1RU OlxuIik7Cj4gLQkJc2VxX3ByaW50ZihtLCAicGQgZ3R0IG9mZnNldDogMHglMDh4XG4iLCBwcGd0 dC0+cGQuYmFzZS5nZ3R0X29mZnNldCk7Cj4gLQo+IC0JCXBwZ3R0LT5kZWJ1Z19kdW1wKHBwZ3R0 LCBtKTsKPiAtCX0KPiAtCj4gLQlzZXFfcHJpbnRmKG0sICJFQ09DSEs6IDB4JTA4eFxuIiwgSTkx NV9SRUFEKEdBTV9FQ09DSEspKTsKPiAtfQo+IC0KPiAtc3RhdGljIGludCBpOTE1X3BwZ3R0X2lu Zm8oc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBub2RlX3RvX2k5MTUobS0+cHJpdmF0ZSk7Cj4gLQlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07Cj4gLQlzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGU7Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCW11dGV4X2xvY2soJmRldi0+ZmlsZWxpc3RfbXV0 ZXgpOwo+IC0JcmV0ID0gbXV0ZXhfbG9ja19pbnRlcnJ1cHRpYmxlKCZkZXYtPnN0cnVjdF9tdXRl eCk7Cj4gLQlpZiAocmV0KQo+IC0JCWdvdG8gb3V0X3VubG9jazsKPiAtCj4gLQlpbnRlbF9ydW50 aW1lX3BtX2dldChkZXZfcHJpdik7Cj4gLQo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g OCkKPiAtCQlnZW44X3BwZ3R0X2luZm8obSwgZGV2X3ByaXYpOwo+IC0JZWxzZSBpZiAoSU5URUxf R0VOKGRldl9wcml2KSA+PSA2KQo+IC0JCWdlbjZfcHBndHRfaW5mbyhtLCBkZXZfcHJpdik7Cj4g LQo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeV9yZXZlcnNlKGZpbGUsICZkZXYtPmZpbGVsaXN0LCBs aGVhZCkgewo+IC0JCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdiA9IGZp bGUtPmRyaXZlcl9wcml2Owo+IC0JCXN0cnVjdCB0YXNrX3N0cnVjdCAqdGFzazsKPiAtCj4gLQkJ dGFzayA9IGdldF9waWRfdGFzayhmaWxlLT5waWQsIFBJRFRZUEVfUElEKTsKPiAtCQlpZiAoIXRh c2spIHsKPiAtCQkJcmV0ID0gLUVTUkNIOwo+IC0JCQlnb3RvIG91dF9ycG07Cj4gLQkJfQo+IC0J CXNlcV9wcmludGYobSwgIlxucHJvYzogJXNcbiIsIHRhc2stPmNvbW0pOwo+IC0JCXB1dF90YXNr X3N0cnVjdCh0YXNrKTsKPiAtCQlpZHJfZm9yX2VhY2goJmZpbGVfcHJpdi0+Y29udGV4dF9pZHIs IHBlcl9maWxlX2N0eCwKPiAtCQkJICAgICAodm9pZCAqKSh1bnNpZ25lZCBsb25nKW0pOwo+IC0J fQo+IC0KPiAtb3V0X3JwbToKPiAtCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiAt CW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC1vdXRfdW5sb2NrOgo+IC0JbXV0 ZXhfdW5sb2NrKCZkZXYtPmZpbGVsaXN0X211dGV4KTsKPiAtCXJldHVybiByZXQ7Cj4gLX0KPiAt Cj4gICBzdGF0aWMgaW50IGNvdW50X2lycV93YWl0ZXJzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1KQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPiBAQCAt NDc0MSw3ICs0NjIzLDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1faW5mb19saXN0IGk5MTVf ZGVidWdmc19saXN0W10gPSB7Cj4gICAJeyJpOTE1X2NvbnRleHRfc3RhdHVzIiwgaTkxNV9jb250 ZXh0X3N0YXR1cywgMH0sCj4gICAJeyJpOTE1X2ZvcmNld2FrZV9kb21haW5zIiwgaTkxNV9mb3Jj ZXdha2VfZG9tYWlucywgMH0sCj4gICAJeyJpOTE1X3N3aXp6bGVfaW5mbyIsIGk5MTVfc3dpenps ZV9pbmZvLCAwfSwKPiAtCXsiaTkxNV9wcGd0dF9pbmZvIiwgaTkxNV9wcGd0dF9pbmZvLCAwfSwK PiAgIAl7Imk5MTVfbGxjIiwgaTkxNV9sbGMsIDB9LAo+ICAgCXsiaTkxNV9lZHBfcHNyX3N0YXR1 cyIsIGk5MTVfZWRwX3Bzcl9zdGF0dXMsIDB9LAo+ICAgCXsiaTkxNV9lbmVyZ3lfdUoiLCBpOTE1 X2VuZXJneV91SiwgMH0sCj4gCgpMb29rcyBsaWtlIGl0IGNvdWxkIG9ubHkgYmUgdXNlZnVsIG1h eWJlIGR1cmluZyBkZXZlbG9wbWVudC4gU28gaGlkaW5nIAppdCB1bmRlciB0aGUgR0VNX0RFQlVH IHdvdWxkIGFsc28gd29yayBmb3IgbWUuIElmIHNvbWVvbmUgdGhpbmtzIHRoZXkgCmNvdWxkIG5l ZWQgaXQuLiBydW4gdGhlIHF1ZXN0aW9uIHBhc3Qgc29tZSBwZW9wbGUgd2hvIHdvcmtlZCBpbiB0 aGUgcGFnZSAKdGFibGUgYXJlYT8KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK