From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37228FEE4ED for ; Sat, 28 Feb 2026 12:38:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FD3010E29D; Sat, 28 Feb 2026 12:38:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="lrbsrG0b"; dkim-atps=neutral Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1C2010E158 for ; Sat, 28 Feb 2026 12:38:51 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-48372facfedso26100605e9.0 for ; Sat, 28 Feb 2026 04:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772282330; x=1772887130; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mOaqhQImVlbU+bIaPkzVliN+MSpqLdHsMK4C5p4HbTE=; b=lrbsrG0b8Q37SOHbOkCbIgTMy1CAzw5/Fgo5KDAzfp9foE1DPpsiKSt5OPCPbdE+iI 1jx7Wgqa/6tjZoU90cPv6KP/YNSY9PM369At83ePyIr9N3JfJZ2A5mG4JsA3oZydwe7Q R7TsarVpR3TKVvtKFZWy90VFugu7oizdRTDaDGYPwrNxwCXu5l3q2i4/MX6ps6RpSpCN Yujl/1kckfAzd+dKY9xF5jc661IqGNpnLmXNZlgZgEU3ga1OicmHOH0tk8lrzEpHz4Sq CspSqpP/y3qQmy3qt+bKhWIP+WGWZT3y4ABdCi2EIiVYEbZw6YxyLxfCdLAkiiw+cFQi H8ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772282330; x=1772887130; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mOaqhQImVlbU+bIaPkzVliN+MSpqLdHsMK4C5p4HbTE=; b=PvPBA1/0Nu2ZYtVbWEY6K/Zvp0Vqcq/r+Zc0TUdYgoQBse7SuPO7aCYEldZl/iRQIw LyA9fXGYx3ihuSDxXMXFe6pZDSjq/PWVinp0TkNUJKt66f6DF8PqDzedbnoM1WEK7TkK TOHvZ6VjLnGtLIe5rFLJrnkmzj4wuFpx8KOldvdqJ7RyRx2btniCm3TRocmmMINQlgOu YGG0YzlWoApLQ0hLiBC2ckUBWjWjLJOfGI1zcHNlRWYMgwaXkuUwXoHUvOaUQXuyZHIW liw/1V/LiDpQS9HLHrjI3txkGtZe8k8yeSHhbTYU2cZkrWvo3dHVojS925eeLovKA84O /Xkw== X-Forwarded-Encrypted: i=1; AJvYcCW3x3jd0YQ08P9CFdEAPqqno3wBtMVp4ha0r6mExVKVehp2c6uwz7IK8u3mXn2YRbg6dRHFUy+z5C8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzmVFijQ5p5SA+qOrWq8O3Y2pH50aB6rsLEV0Bw25t8IPg33koV YTvxNsXgRvSWLJQvdcNzYbe2G+Qp7oDYW+yGIMDncRqHfQ6dPUjPrDcB+aEkjt1jdN6E0Gy+c1x pIp/tpAj6PGf9oOJytA== X-Received: from wmby19.prod.google.com ([2002:a05:600c:c053:b0:480:690c:88de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8b5b:b0:481:a662:b3f3 with SMTP id 5b1f17b1804b1-483c990c263mr116931775e9.7.1772282329804; Sat, 28 Feb 2026 04:38:49 -0800 (PST) Date: Sat, 28 Feb 2026 12:38:48 +0000 In-Reply-To: <20260227200848.114019-3-david@kernel.org> Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > Nobody except memory.c should really set that parameter to non-NULL. So > let's just drop it and make unmap_mapping_range_vma() use > zap_page_range_single_batched() instead. > > Signed-off-by: David Hildenbrand (Arm) > diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > index da21d65ccd20..b8e59e4420f3 100644 > --- a/rust/kernel/mm/virt.rs > +++ b/rust/kernel/mm/virt.rs > @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > // sufficient for this method call. This method has no requirements on the vma flags. The > // address range is checked to be within the vma. > unsafe { > - bindings::zap_page_range_single(self.as_ptr(), address, size, core::ptr::null_mut()) > + bindings::zap_page_range_single(self.as_ptr(), address, size) > }; Please run rustfmt on Rust changes. Here, rustfmt leads to this being formatted on a single line: unsafe { bindings::zap_page_range_single(self.as_ptr(), address, size) }; with the above changed: Acked-by: Alice Ryhl # Rust and Binder Alice