From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71288FEE4C9 for ; Sat, 28 Feb 2026 12:44:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04D2C10E29F; Sat, 28 Feb 2026 12:44:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="HTHQmG3c"; dkim-atps=neutral Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3753D10E2A0 for ; Sat, 28 Feb 2026 12:44:30 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-483a2db68caso23191825e9.0 for ; Sat, 28 Feb 2026 04:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772282669; x=1772887469; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RH0L9WD4/u9mQiuU+Jc2bLYt2zoxsRLi5sNyM2YzgMo=; b=HTHQmG3cXVKjawylAL3iHZ34M6CV82KhZ+kRqFDp0F7mYng7JszVSybtsOrkG1jq5V L23JYjiLD/qtzSZObeXBbUN8p25ki5vZRNHKSXLCdpAwZkeCVy6lJYQv3dQFXgd+VXaE VoBboTIDkLURbNBMoVJrSLVlp5oGkCZxXX7uscXgjNCmkERtNoPq6rOXv+Pj1yy8iYu+ DjtgpuXij3sniillPmga8iaQVdfXvYUGqPEZiIQqgIRtne9DsR/+wauPzBsa5B2nkM35 NYxXxXDhZNFOSJjkpUDt38pRIMCVkC/kz9b5DGdHpXLWl3uOofI28dFe4ZzjdyE5ci/H +NFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772282669; x=1772887469; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RH0L9WD4/u9mQiuU+Jc2bLYt2zoxsRLi5sNyM2YzgMo=; b=UuyekZy6r6rFHiXY+TjJIG2l2Mktcaj9XXn54IUKzKFwny+k5/uoBO93QAJcT7QIn1 6CzJI2iE+j3V9ORynLnIuOaVNtxd695Wp9+3afKixs1Hrp8aQBJCF84FL/pgXpkyA6Kc Vjvv1Dl59UvkiCcib33nv7Rh6Bxab7H4v65SfEWINp8/vR6rHrDM7y3MaxZT1MEtyn0I 8mgEEesklI5GsBhWVqktpnxhxPDuZJ906+X2OGQC9k9DHGaTIPAl4P9/TDFZnrfMuXJ5 DP3anf4vycfu7U6Wo9LQBzPtmiBbeZjo+thzLQhknpI/XVFAEttFxu3uOFf/v5lMmgi8 /Xpg== X-Forwarded-Encrypted: i=1; AJvYcCXIRWA+NjyixTZB1EjViYyYEEB1YU5Zl4sl3AoIM55FAMVGVTUNpFEhHZVb5VjBtQQWFTsSE62XhPc=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwxJmGGfT2rCaRghDUxLmbjNTQ6ykP02YkP/tpoM3bhb9Zksbfd rblkr/35JZf/82A62970DsiDajBsb1IR1t2q5SmqPEl8PULFaF5RyCp7WAiIG9ca7w0/Utns4y9 7FfAAxrXuttIIHdekKw== X-Received: from wmqi19.prod.google.com ([2002:a05:600c:3553:b0:483:6fe1:c054]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4fc8:b0:47b:e2a9:2bd7 with SMTP id 5b1f17b1804b1-483c9beaca0mr120569145e9.19.1772282668287; Sat, 28 Feb 2026 04:44:28 -0800 (PST) Date: Sat, 28 Feb 2026 12:44:27 +0000 In-Reply-To: <20260227200848.114019-15-david@kernel.org> Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-15-david@kernel.org> Message-ID: Subject: Re: [PATCH v1 14/16] mm: rename zap_page_range_single() to zap_vma_range() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Feb 27, 2026 at 09:08:45PM +0100, David Hildenbrand (Arm) wrote: > diff --git a/drivers/android/binder/page_range.rs b/drivers/android/binder/page_range.rs > index fdd97112ef5c..2fddd4ed8d4c 100644 > --- a/drivers/android/binder/page_range.rs > +++ b/drivers/android/binder/page_range.rs > @@ -130,7 +130,7 @@ pub(crate) struct ShrinkablePageRange { > pid: Pid, > /// The mm for the relevant process. > mm: ARef, > - /// Used to synchronize calls to `vm_insert_page` and `zap_page_range_single`. > + /// Used to synchronize calls to `vm_insert_page` and `zap_vma_range`. > #[pin] > mm_lock: Mutex<()>, > /// Spinlock protecting changes to pages. > @@ -719,7 +719,7 @@ fn drop(self: Pin<&mut Self>) { > > if let Some(vma) = mmap_read.vma_lookup(vma_addr) { > let user_page_addr = vma_addr + (page_index << PAGE_SHIFT); > - vma.zap_page_range_single(user_page_addr, PAGE_SIZE); > + vma.zap_vma_range(user_page_addr, PAGE_SIZE); > } LGTM. Be aware that this will have a merge conflict with patches currently in char-misc-linus that are scheduled to land in an -rc. > diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c > index dd2046bd5cde..e4488ad86a65 100644 > --- a/drivers/android/binder_alloc.c > +++ b/drivers/android/binder_alloc.c > @@ -1185,7 +1185,7 @@ enum lru_status binder_alloc_free_page(struct list_head *item, > if (vma) { > trace_binder_unmap_user_start(alloc, index); > > - zap_page_range_single(vma, page_addr, PAGE_SIZE); > + zap_vma_range(vma, page_addr, PAGE_SIZE); > > trace_binder_unmap_user_end(alloc, index); LGTM. > diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > index b8e59e4420f3..04b3cc925d67 100644 > --- a/rust/kernel/mm/virt.rs > +++ b/rust/kernel/mm/virt.rs > @@ -113,7 +113,7 @@ pub fn end(&self) -> usize { > /// kernel goes further in freeing unused page tables, but for the purposes of this operation > /// we must only assume that the leaf level is cleared. > #[inline] > - pub fn zap_page_range_single(&self, address: usize, size: usize) { > + pub fn zap_vma_range(&self, address: usize, size: usize) { > let (end, did_overflow) = address.overflowing_add(size); > if did_overflow || address < self.start() || self.end() < end { > // TODO: call WARN_ONCE once Rust version of it is added > @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > // sufficient for this method call. This method has no requirements on the vma flags. The > // address range is checked to be within the vma. > unsafe { > - bindings::zap_page_range_single(self.as_ptr(), address, size) > + bindings::zap_vma_range(self.as_ptr(), address, size) > }; > } Same as previous patch: please run rustfmt. It will format on a single line, like this: unsafe { bindings::zap_vma_range(self.as_ptr(), address, size) }; with the above change applied: Acked-by: Alice Ryhl # Rust and Binder Alice