From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB5D8EA4E24 for ; Mon, 2 Mar 2026 15:41:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F21110E52E; Mon, 2 Mar 2026 15:41:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="yDVao2ku"; dkim-atps=neutral Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D7D410E52E for ; Mon, 2 Mar 2026 15:41:45 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso58425175e9.1 for ; Mon, 02 Mar 2026 07:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772466103; x=1773070903; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=yDVao2kutJij3UcQPjbx19mZXojU4aZRhj+awnsgjYAAJrkJv2z5k7Y6WlsSuPyNEQ OgT7Ey7Bb2eBLYvTQ8DP7xwSncZUR3/Px3uTZ0KSC/VWUMrULjoDQlRs9pfDJ/v1tlWC X3wiYQYaNOF4SZ5utaAI2nuqyTcAde9cu7qxXu2WbCh/qPmDI3fUzAKcCFCOfLefzPQB r8JTQJ3juH19MpSS17wgYTxpKlx1T++QZ810Zgr3/UZsmlFsgYqbw102xelsqno1jFRn LpTYhrEUXi9c+1gXi+MRtMQHFjRavPtCbFlA1Pmm2d+QPoRk7NK2mdJx2mvUVNybPXqF HBAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772466103; x=1773070903; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=Efpjd682w5AtLsG8l61QqI1Tr3WSVI3gSQ/H/elR/Jeqsd7wylC6vwIKfj+6dmFrPm MciBTj8dQRUTdn9zuG6h+TFPrfHsFHIz9lIEyaQYFxpTh/01rROd4ZSxpilvuCsZL4TK 5msfn3Onhl1V+jcPKx3KIy3nVFO5YTWveNJ/CGuzvPVodV+xQBj+sFGMNX1DkHYz25by NKY88AsCtHvUzOsVJCrGH4FJF62kHkzn8QB3kN0PZaiGrAq7V+MfF26MMkddZjHFswnT 68XqhKu789mEfjlyLgJSGch2khrxXcs0PYhk8uVf6a8rE3MC244/OiqCoxo3OcuDPU0x UEnw== X-Forwarded-Encrypted: i=1; AJvYcCUWfairbTRX5IfS8D4bSu8zxLeG13Ydf/ZLKn1IWoXAh40isoYZL9ckIVvYXyLlB0/JzZumn/4B3js=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwjqZ4vhskaq6pruczsoA0U6FW2/32UfgESYyRASr8E0uoMCIOy YUCM2ghp6wTpxU2Wwv9VIhFrbfpPLKLd74AJtDJ1QEaXj9sXuYyhCOEhHNCWF16262+ACVqh90n COYP8bcCZ9lfFselYsw== X-Received: from wmby19.prod.google.com ([2002:a05:600c:c053:b0:480:690c:88de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b18:b0:483:7432:a761 with SMTP id 5b1f17b1804b1-483c9bc558bmr213622465e9.24.1772466102970; Mon, 02 Mar 2026 07:41:42 -0800 (PST) Date: Mon, 2 Mar 2026 15:41:42 +0000 In-Reply-To: <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 02, 2026 at 04:01:44PM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:33, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > >> On 3/2/26 11:01, Alice Ryhl wrote: > >>> > >>> Well, rustfmt comes with the compiler, and it would be ideal to build > >>> test changes before sending them :) > >> > >> At least on Ubuntu on my notebook where I do most of the coding+patch > >> submissions it's a separate package? > >> > >> I do all my builds on a different (more powerful) machine where the > >> whole rust machinery's in place. Further, build bots that run on my > >> private branches did not report any issues. > > > > There are some build bots that check for rustfmt, though not all of > > them. > > > >>> But no worries, I took care of testing it. Thanks for taking the time to > >>> update the Rust code as well. > >> > >> I just did an allyesconfig and it does not report any warnings. > >> > >> So apparently, rustfmt problems not result in the compiler complaining? > >> > >> Or something else is off here that rust/kernel/mm/virt.rs won't get > >> compiled on my machine, even with allyesconfig. I can definitely see > >> some RUSTC stuff happening in the logs, like > >> > >> RUSTC L rust/kernel.o > >> > >> Thanks for the review and for pointing out rustfmt! > > > > Similar to kerneldoc and other similar targets, formatting isn't checked > > in the normal build, but make can be invoked on the rustfmtcheck target > > to check it. > > Thanks adding that to my cross-compile chain. Awesome, thanks! It's not relevant in this patch, but another thing that may be useful is to add CLIPPY=1 to the make invocation when building normally. This causes additional warnings to be checked using a tool called clippy. Alice