From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CDD7EDA6B5 for ; Tue, 3 Mar 2026 17:18:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0543C10E894; Tue, 3 Mar 2026 17:18:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="R/otYeIJ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 032AC10E0C3; Tue, 3 Mar 2026 17:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772558277; x=1804094277; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=tR4vh10wYli0MphjcUWkzlsojlbu3sAAfWV8dQrIPCU=; b=R/otYeIJpP5uHnUC/Q7lgVYSGYNVZu2RjJBF6HXsEfP7iRdsMnw0nsL9 15GEkDx69PxWAZWZPsgF2hTqA/Yb2b7uH21CVzIW81ZbIINpdgn6d6LvP HS1BwHTzkUn6t8iPRB3hgGkY1ntcGrRubLXstroCbiO/pXgZ85LNgxgkQ W0j9yD4UTpi4Zw6r8tF8gGYHOpgU97dx8KkVl0Yjn/fQvZiBmHcNSxJ21 oSgvx0DQISD4Msktamp2IeJRlbqukpN2Fwg6NnROFQ3GsaMil82uQwIvf 7g33nibgqL6th4KKgQMJ3DalFSGoNYLPNafRnoLr0uonLyNrZJ2QyeKq2 w==; X-CSE-ConnectionGUID: rI9C+AdcSESpEB3KGHv/ww== X-CSE-MsgGUID: XDEFQFsxShOYzw6xgoS+Pw== X-IronPort-AV: E=McAfee;i="6800,10657,11718"; a="84698551" X-IronPort-AV: E=Sophos;i="6.21,322,1763452800"; d="scan'208";a="84698551" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 09:17:56 -0800 X-CSE-ConnectionGUID: ZG9qZFsNSEWHGGVePtrRug== X-CSE-MsgGUID: nH+uHY1aS4CoA6Ki5sK47A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,322,1763452800"; d="scan'208";a="218186770" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.23]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 09:17:55 -0800 Date: Tue, 3 Mar 2026 19:17:51 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: =?utf-8?Q?Micha=C5=82?= Grzelak Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/overlay: Fix oops on unload Message-ID: References: <20260303101417.14409-1-ville.syrjala@linux.intel.com> <67e4ef68-268c-57ad-1abd-5c07cefd6270@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67e4ef68-268c-57ad-1abd-5c07cefd6270@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 03, 2026 at 11:25:55AM +0100, Michał Grzelak wrote: > On Tue, 3 Mar 2026, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Apparently I failed to test the unload case properly and > > thus didn't notice that the i915_overlay_is_active() needs > > i915->overlay after fetch_and_zero() already cleared it. > > Stop using fetch_and_zero() and only clear the pointer at > > the end to avoid the oops. > > > > Fixes: 38d9a352c45e ("drm/i915/overlay: Extract i915_overlay_is_active()") > > Signed-off-by: Ville Syrjälä > > Reviewed-by: Michał Grzelak Thanks. Pushed. -- Ville Syrjälä Intel