* [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition
@ 2015-03-12 11:01 Jani Nikula
2015-03-12 16:52 ` shuang.he
0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2015-03-12 11:01 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Same as
commit c883ef1b1c998d2d66866772fd0fc34afa45641e
Author: Mika Kuoppala <miku@iki.fi>
Date: Tue Oct 28 17:32:30 2014 +0200
drm/i915: Redefine WARN_ON to include the condition
but for WARN_ON_ONCE. Since the kernel WARN_ON_ONCE actually picks up
*our* version of WARN_ON, we end up with messages like
[ 838.285319] WARN_ON(!__warned)
which are not that helpful.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index a80b15f7acfa..a76c6eee593c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -70,6 +70,9 @@
#define WARN_ON(x) WARN((x), "WARN_ON(" #x ")")
#endif
+#undef WARN_ON_ONCE
+#define WARN_ON_ONCE(x) WARN_ONCE((x), "WARN_ON_ONCE(" #x ")")
+
#define MISSING_CASE(x) WARN(1, "Missing switch case (%lu) in %s\n", \
(long) (x), __func__);
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition
2015-03-12 11:01 [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition Jani Nikula
@ 2015-03-12 16:52 ` shuang.he
0 siblings, 0 replies; 2+ messages in thread
From: shuang.he @ 2015-03-12 16:52 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, jani.nikula
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5940
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -6 274/274 268/274
ILK 301/301 301/301
SNB -1 277/277 276/277
IVB 341/341 341/341
BYT 287/287 287/287
HSW 360/360 360/360
BDW 308/308 308/308
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gem_userptr_blits_minor-normal-sync PASS(4) DMESG_WARN(1)PASS(1)
PNV igt_gen3_render_linear_blits FAIL(3)PASS(3) FAIL(2)
PNV igt_gen3_render_mixed_blits FAIL(3)PASS(3) FAIL(2)
PNV igt_gen3_render_tiledx_blits FAIL(5)PASS(2) FAIL(2)
PNV igt_gen3_render_tiledy_blits FAIL(5)PASS(1) FAIL(2)
PNV igt_gem_tiled_pread_pwrite FAIL(2)PASS(2) FAIL(2)
*SNB igt_gem_mmap_short-mmap PASS(2) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-12 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 11:01 [PATCH] drm/i915: redefine WARN_ON_ONCE to include the condition Jani Nikula
2015-03-12 16:52 ` shuang.he
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox