Re: [PATCH] drm/atomic-helpers: Properly avoid full modeset dance

Gustavo Padovan
2015-03-27T15:38:27Z

2015-03-27 Daniel Vetter <daniel.vetter@ffwll.ch>:

> Legacy setCrtc has a nice fastpath for just updating the frontbuffer
> when the output routing doesn't change. Which I of course tried to
> keep working, except that I fumbled the job: The helpers correctly
> compute ->mode_changed, CRTC updates get correctly skipped but
> connector functions are called unconditionally.
>
> Fix this.
>
> v2: For the disable sided connector->state->crtc might be NULL.
> Instead look at the old_connector_state->crtc, but still use the new
> crtc state for that old crtc. Reported by Thierry.
>
> Reported-and-Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> (v1)
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> (v1)
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

v2 still works for me. You can also add my r-b to v2.

Gustavo