Re: [PATCH v4] drm/i915: Report correct GGTT space usage

Chris Wilson
2015-06-30T15:01:03Z

On Tue, Jun 30, 2015 at 03:32:47PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Currently only normal views were accounted which under-accounts
> the usage as reported in debugfs.
>
> Introduce new helper, i915_gem_obj_total_ggtt_size, and use it
> from call sites which want to know how much GGTT space are
> objects using.
>
> v2: Single loop in i915_gem_get_aperture_ioctl. (Chris Wilson)
>
> v3: Walk GGTT active/inactive lists in i915_gem_get_aperture_ioctl
> for better efficiency. (Chris Wilson, Daniel Vetter)
>
> v4: Make i915_gem_obj_total_ggtt_size private to debugfs. (Chris Wilson)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>

s/unsigned long/u64/
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre