Re: [PATCH v4] drm/i915: Report correct GGTT space usage

Chris Wilson
2015-07-01T10:58:32Z

On Wed, Jul 01, 2015 at 11:53:43AM +0100, Tvrtko Ursulin wrote:
>
> On 06/30/2015 04:00 PM, Chris Wilson wrote:
> >On Tue, Jun 30, 2015 at 03:32:47PM +0100, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >>Currently only normal views were accounted which under-accounts
> >>the usage as reported in debugfs.
> >>
> >>Introduce new helper, i915_gem_obj_total_ggtt_size, and use it
> >>from call sites which want to know how much GGTT space are
> >>objects using.
> >>
> >>v2: Single loop in i915_gem_get_aperture_ioctl. (Chris Wilson)
> >>
> >>v3: Walk GGTT active/inactive lists in i915_gem_get_aperture_ioctl
> >> for better efficiency. (Chris Wilson, Daniel Vetter)
> >>
> >>v4: Make i915_gem_obj_total_ggtt_size private to debugfs. (Chris Wilson)
> >>
> >>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >>Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >>Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> >s/unsigned long/u64/
>
> It's all pointless until someone makes it all consistent. But done
> anyway. And sent as a new thread so Daniel hopefully notices it more
> easily.

Mika's in the process of being repeatedly poked until the driver is clean. :)
-Chris

--
Chris Wilson, Intel Open Source Technology Centre