Re: [PATCH v2 0/9] drm/i915/{dp,hdmi}: Restructure DP/HDMI sink format handling

Ville Syrjälä
2026-04-13T18:38:11Z

On Thu, Apr 09, 2026 at 05:40:50PM +0200, Nicolas Frattaroli wrote:
> On Thursday, 9 April 2026 12:15:30 Central European Summer Time Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Restructure the DP/HDMI sink format handling. I got inspired to do this
> > by https://lore.kernel.org/dri-devel/20260324-color-format-v11-8-605559af4fb4@collabora.com/
> >
> > I envision that after this the aforementioned patch could just
> > become something like this:
> >
> > 1. s/intel_foo_compute_formats/intel_foo_compute_formats_auto/
> > 2. Add a new intel_foo_compute_formats()
> >
> > intel_foo_compute_formats()
> > {
> > switch (color_format) {
> > case YCBCR420:
> > return intel_foo_compute_output_format(YCBCR420);
> > case RGB:
> > return intel_foo_compute_output_format(RGB);
> > case AUTO:
> > return intel_foo_compute_formats_auto();
> > }
> > }
> >
> > v2: A few more updates to the DP mode validation
> >
> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> >
> > Ville Syrjälä (9):
> > drm/i915/hdmi: Add missing intel_pfit_mode_valid() for 4:2:0 also
> > modes
> > drm/i915/hdmi: Restructure the sink/output format selection
> > drm/i915/hdmi: Restructure 4:2:0 vs. 4:4:4 mode validation
> > drm/i915/dp: Restructure the sink/output format selection
> > drm/i915/dp: Validate "4:2:0 also" modes twice
> > drm/i915/dp: Require a HDMI sink for YCbCr output via PCON
> > drm/i915/dp: Validate sink format in .mode_valid()
> > drm/i915/hdmi: Make the RGB fallback for "4:2:0 only" modes the last
> > resort
> > drm/i915/dp: Make the RGB fallback for "4:2:0 only" modes the last
> > resort
> >
> > drivers/gpu/drm/i915/display/intel_dp.c | 250 +++++++++++++---------
> > drivers/gpu/drm/i915/display/intel_hdmi.c | 167 +++++++++------
> > 2 files changed, 254 insertions(+), 163 deletions(-)
> >
> >
>
> For the whole series:
>
> Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>
> Tested both DisplayPort and HDMI on an N97 board, exercising various
> output formats.

Thanks for testing and reviews. Pushed to drm-intel-next.

--
Ville Syrjälä
Intel