Re: [PATCH v2 02/10] drm/i915/casf: rename *_coeff*() into *_coef*()

Michał Grzelak
2026-04-12T21:49:42Z

[-- Attachment #1: Type: text/plain, Size: 2564 bytes --]

Title starts to make sense after swapping in it coeff <-> coef. Eh.

On Sat, 11 Apr 2026, Michał Grzelak wrote:
> Stick to the notion of already used *_coeff*() instead of *_coef*().
> Rename that way convert_sharpness_coef_binary() and
> intel_casf_scaler_compute_coef().
>
> v1->v2
> - rename intel_casf_scaler_compute_coef()
>
> Cc: Nemesa Garg <nemesa.garg@intel.com>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_casf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_casf.c b/drivers/gpu/drm/i915/display/intel_casf.c
> index 9a306aee21994..c4fabffa369e3 100644
> --- a/drivers/gpu/drm/i915/display/intel_casf.c
> +++ b/drivers/gpu/drm/i915/display/intel_casf.c
> @@ -88,7 +88,7 @@ static void intel_casf_compute_win_size(struct intel_crtc_state *crtc_state)
> crtc_state->pch_pfit.casf.win_size = SHARPNESS_FILTER_SIZE_7X7;
> }
>
> -static void intel_casf_scaler_compute_coef(struct intel_crtc_state *crtc_state);
> +static void intel_casf_scaler_compute_coeff(struct intel_crtc_state *crtc_state);
>
> int intel_casf_compute_config(struct intel_crtc_state *crtc_state)
> {
> @@ -118,7 +118,7 @@ int intel_casf_compute_config(struct intel_crtc_state *crtc_state)
>
> intel_casf_compute_win_size(crtc_state);
>
> - intel_casf_scaler_compute_coef(crtc_state);
> + intel_casf_scaler_compute_coeff(crtc_state);
>
> return 0;
> }
> @@ -196,7 +196,7 @@ static void intel_casf_write_coeff(const struct intel_crtc_state *crtc_state)
> }
> }
>
> -static void convert_sharpness_coef_binary(struct scaler_filter_coeff *coeff,
> +static void convert_sharpness_coeff_binary(struct scaler_filter_coeff *coeff,
> u16 coefficient)
> {
> if (coefficient < 25) {
> @@ -214,7 +214,7 @@ static void convert_sharpness_coef_binary(struct scaler_filter_coeff *coeff,
> }
> }
>
> -static void intel_casf_scaler_compute_coef(struct intel_crtc_state *crtc_state)
> +static void intel_casf_scaler_compute_coeff(struct intel_crtc_state *crtc_state)
> {
> const u16 *filtercoeff;
> u16 filter_coeff[SCALER_FILTER_NUM_TAPS];
> @@ -233,7 +233,7 @@ static void intel_casf_scaler_compute_coef(struct intel_crtc_state *crtc_state)
>
> for (i = 0; i < SCALER_FILTER_NUM_TAPS; i++) {
> filter_coeff[i] = (*(filtercoeff + i) * 100 / sumcoeff);
> - convert_sharpness_coef_binary(&crtc_state->pch_pfit.casf.coeff[i],
> + convert_sharpness_coeff_binary(&crtc_state->pch_pfit.casf.coeff[i],
> filter_coeff[i]);
> }
> }
> --
> 2.45.2
>
>