[PATCH v2 03/10] drm/i915: rename t into tap

Michał Grzelak
2026-04-11T17:46:21Z

Add more description to the casf_coeff()'s argument and
casf_coeff_tap()'s returned value.

Do the same for glk_nearest_filter_coef().

v1->v2
- apply the rename to nearest neighbor filter (Ville)

Cc: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
drivers/gpu/drm/i915/display/intel_casf.c | 14 +++++++-------
drivers/gpu/drm/i915/display/skl_scaler.c | 14 +++++++-------
2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_casf.c b/drivers/gpu/drm/i915/display/intel_casf.c
index c4fabffa369e3..b9643548d1822 100644
--- a/drivers/gpu/drm/i915/display/intel_casf.c
+++ b/drivers/gpu/drm/i915/display/intel_casf.c
@@ -148,12 +148,12 @@ static int casf_coeff_tap(int i)
return i % SCALER_FILTER_NUM_TAPS;
}

-static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int t)
+static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int tap)
{
struct scaler_filter_coeff value;
u32 coeff;

- value = crtc_state->pch_pfit.casf.coeff[t];
+ value = crtc_state->pch_pfit.casf.coeff[tap];
value.sign = 0;

coeff = value.sign << 15 | value.exp << 12 | value.mantissa << 3;
@@ -183,13 +183,13 @@ static void intel_casf_write_coeff(const struct intel_crtc_state *crtc_state)

for (i = 0; i < 17 * SCALER_FILTER_NUM_TAPS; i += 2) {
u32 tmp;
- int t;
+ int tap;

- t = casf_coeff_tap(i);
- tmp = casf_coeff(crtc_state, t);
+ tap = casf_coeff_tap(i);
+ tmp = casf_coeff(crtc_state, tap);

- t = casf_coeff_tap(i + 1);
- tmp |= casf_coeff(crtc_state, t) << 16;
+ tap = casf_coeff_tap(i + 1);
+ tmp |= casf_coeff(crtc_state, tap) << 16;

intel_de_write_fw(display, GLK_PS_COEF_DATA_SET(crtc->pipe, id, 0),
tmp);
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 308b8d363bba0..eceda1a909ccd 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -661,9 +661,9 @@ static int glk_coef_tap(int i)
return i % 7;
}

-static u16 glk_nearest_filter_coef(int t)
+static u16 glk_nearest_filter_coef(int tap)
{
- return t == 3 ? 0x0800 : 0x3000;
+ return tap == 3 ? 0x0800 : 0x3000;
}

/*
@@ -715,13 +715,13 @@ static void glk_program_nearest_filter_coefs(struct intel_display *display,

for (i = 0; i < 17 * 7; i += 2) {
u32 tmp;
- int t;
+ int tap;

- t = glk_coef_tap(i);
- tmp = glk_nearest_filter_coef(t);
+ tap = glk_coef_tap(i);
+ tmp = glk_nearest_filter_coef(tap);

- t = glk_coef_tap(i + 1);
- tmp |= glk_nearest_filter_coef(t) << 16;
+ tap = glk_coef_tap(i + 1);
+ tmp |= glk_nearest_filter_coef(tap) << 16;

intel_de_write_dsb(display, dsb,
GLK_PS_COEF_DATA_SET(pipe, id, set), tmp);
--
2.45.2