From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 5/5] drm/i915/execlists: Drop promotion on unsubmit Date: Fri, 17 May 2019 15:30:12 +0100 Message-ID: References: <20190515130052.4475-1-chris@chris-wilson.co.uk> <20190515130052.4475-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68D40898EE for ; Fri, 17 May 2019 14:30:14 +0000 (UTC) In-Reply-To: <20190515130052.4475-5-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzA1LzIwMTkgMTQ6MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXaXRoIHRoZSBkaXNh cHBlYXJhbmNlIG9mIE5FV0NMSUVOVCwgd2Ugbm8gbG9uZ2VyIG5lZWQgdG8gcHJvdmlkZSB0aGUK PiBwcmlvcml0eSBib29zdCBvbiBwcmVlbXB0aW9uIGluIG9yZGVyIHRvIHByZXZlbnQgcmVwZWF0 ZWQgZ2F6dW1waW5nLAo+IGFuZCB3ZSBjYW4gcmVtb3ZlIHRoZSBkZWFkIGNvZGUuCj4gCj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYyB8IDU5ICsrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xy Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPiBpbmRleCBiNWU4MjE3 MWRmOGYuLmYyNjNhODM3NDI3MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9n dC9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5j Cj4gQEAgLTE2NCw4ICsxNjQsNiBAQAo+ICAgI2RlZmluZSBXQV9UQUlMX0RXT1JEUyAyCj4gICAj ZGVmaW5lIFdBX1RBSUxfQllURVMgKHNpemVvZih1MzIpICogV0FfVEFJTF9EV09SRFMpCj4gICAK PiAtI2RlZmluZSBBQ1RJVkVfUFJJT1JJVFkgKEk5MTVfUFJJT1JJVFlfTk9TRU1BUEhPUkUpCj4g LQo+ICAgc3RhdGljIGludCBleGVjbGlzdHNfY29udGV4dF9kZWZlcnJlZF9hbGxvYyhzdHJ1Y3Qg aW50ZWxfY29udGV4dCAqY2UsCj4gICAJCQkJCSAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpOwo+ICAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2luaXRfcmVnX3N0YXRlKHUzMiAqcmVn X3N0YXRlLAo+IEBAIC0xODksMjMgKzE4NywxMiBAQCBzdGF0aWMgaW50IGVmZmVjdGl2ZV9wcmlv KGNvbnN0IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+ICAgCj4gICAJLyoKPiAgIAkgKiBPbiB1 bndpbmRpbmcgdGhlIGFjdGl2ZSByZXF1ZXN0LCB3ZSBnaXZlIGl0IGEgcHJpb3JpdHkgYnVtcAo+ IC0JICogZXF1aXZhbGVudCB0byBhIGZyZXNobHkgc3VibWl0dGVkIHJlcXVlc3QuIFRoaXMgcHJv dGVjdHMgaXQgZnJvbQo+IC0JICogYmVpbmcgZ2F6dW1wZWQgYWdhaW4sIGJ1dCBpdCB3b3VsZCBi ZSBwcmVmZXJhYmxlIGlmIHdlIGRpZG4ndAo+IC0JICogbGV0IGl0IGJlIGdhenVtcGVkIGluIHRo ZSBmaXJzdCBwbGFjZSEKPiAtCSAqCj4gLQkgKiBTZWUgX191bndpbmRfaW5jb21wbGV0ZV9yZXF1 ZXN0cygpCj4gKwkgKiBpZiBpdCBoYXMgY29tcGxldGVkIHdhaXRpbmcgb24gYW55IHNlbWFwaG9y ZS4gSWYgd2Uga25vdyB0aGF0Cj4gKwkgKiB0aGUgcmVxdWVzdCBoYXMgYWxyZWFkeSBzdGFydGVk LCB3ZSBjYW4gcHJldmVudCBhbiB1bndhbnRlZAo+ICsJICogcHJlZW1wdC10by1pZGxlIGN5Y2xl IGJ5IHRha2luZyB0aGF0IGludG8gYWNjb3VudCBub3cuCj4gICAJICovCj4gLQlpZiAofnByaW8g JiBBQ1RJVkVfUFJJT1JJVFkgJiYgX19pOTE1X3JlcXVlc3RfaGFzX3N0YXJ0ZWQocnEpKSB7Cj4g LQkJLyoKPiAtCQkgKiBBZnRlciBwcmVlbXB0aW9uLCB3ZSBpbnNlcnQgdGhlIGFjdGl2ZSByZXF1 ZXN0IGF0IHRoZQo+IC0JCSAqIGVuZCBvZiB0aGUgbmV3IHByaW9yaXR5IGxldmVsLiBUaGlzIG1l YW5zIHRoYXQgd2Ugd2lsbCBiZQo+IC0JCSAqIF9sb3dlcl8gcHJpb3JpdHkgdGhhbiB0aGUgcHJl ZW1wdGVlIGFsbCB0aGluZ3MgZXF1YWwgKGFuZAo+IC0JCSAqIHNvIHRoZSBwcmVlbXB0aW9uIGlz IHZhbGlkKSwgc28gYWRqdXN0IG91ciBjb21wYXJpc29uCj4gLQkJICogYWNjb3JkaW5nbHkuCj4g LQkJICovCj4gLQkJcHJpbyB8PSBBQ1RJVkVfUFJJT1JJVFk7Cj4gLQkJcHJpby0tOwo+IC0JfQo+ ICsJaWYgKF9faTkxNV9yZXF1ZXN0X2hhc19zdGFydGVkKHJxKSkKPiArCQlwcmlvIHw9IEk5MTVf UFJJT1JJVFlfTk9TRU1BUEhPUkU7Cj4gICAKPiAgIAkvKiBSZXN0cmljdCBtZXJlIFdBSVQgYm9v c3RzIGZyb20gdHJpZ2dlcmluZyBwcmVlbXB0aW9uICovCj4gICAJcmV0dXJuIHByaW8gfCBfX05P X1BSRUVNUFRJT047Cj4gQEAgLTM3MSwxMSArMzU4LDExIEBAIHN0YXRpYyB2b2lkIHVud2luZF93 YV90YWlsKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+ICAgfQo+ICAgCj4gICBzdGF0aWMgc3Ry dWN0IGk5MTVfcmVxdWVzdCAqCj4gLV9fdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBpbnQgYm9vc3QpCj4gK19fdW53aW5kX2luY29tcGxl dGVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICAgCXN0 cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCAqcm4sICphY3RpdmUgPSBOVUxMOwo+ICAgCXN0cnVjdCBs aXN0X2hlYWQgKnVuaW5pdGlhbGl6ZWRfdmFyKHBsKTsKPiAtCWludCBwcmlvID0gSTkxNV9QUklP UklUWV9JTlZBTElEIHwgYm9vc3Q7Cj4gKwlpbnQgcHJpbyA9IEk5MTVfUFJJT1JJVFlfSU5WQUxJ RDsKPiAgIAo+ICAgCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmVuZ2luZS0+dGltZWxpbmUubG9jayk7 Cj4gICAKPiBAQCAtNDAyLDMxICszODksNiBAQCBfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3Rz KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgaW50IGJvb3N0KQo+ICAgCQlhY3RpdmUg PSBycTsKPiAgIAl9Cj4gICAKPiAtCS8qCj4gLQkgKiBUaGUgYWN0aXZlIHJlcXVlc3QgaXMgbm93 IGVmZmVjdGl2ZWx5IHRoZSBzdGFydCBvZiBhIG5ldyBjbGllbnQKPiAtCSAqIHN0cmVhbSwgc28g Z2l2ZSBpdCB0aGUgZXF1aXZhbGVudCBzbWFsbCBwcmlvcml0eSBidW1wIHRvIHByZXZlbnQKPiAt CSAqIGl0IGJlaW5nIGdhenVtcGVkIGEgc2Vjb25kIHRpbWUgYnkgYW5vdGhlciBwZWVyLgo+IC0J ICoKPiAtCSAqIE5vdGUgd2UgaGF2ZSB0byBiZSBjYXJlZnVsIG5vdCB0byBhcHBseSBhIHByaW9y aXR5IGJvb3N0IHRvIGEgcmVxdWVzdAo+IC0JICogc3RpbGwgc3Bpbm5pbmcgb24gaXRzIHNlbWFw aG9yZXMuIElmIHRoZSByZXF1ZXN0IGhhc24ndCBzdGFydGVkLCB0aGF0Cj4gLQkgKiBtZWFucyBp dCBpcyBzdGlsbCB3YWl0aW5nIGZvciBpdHMgZGVwZW5kZW5jaWVzIHRvIGJlIHNpZ25hbGVkLCBh bmQKPiAtCSAqIGlmIHdlIGFwcGx5IGEgcHJpb3JpdHkgYm9vc3QgdG8gdGhpcyByZXF1ZXN0LCB3 ZSB3aWxsIGJvb3N0IGl0IHBhc3QKPiAtCSAqIGl0cyBzaWduYWxlcnMgYW5kIHNvIGJyZWFrIFBJ Lgo+IC0JICoKPiAtCSAqIE9uZSBjb25zZXF1ZW5jZSBvZiB0aGlzIHByZWVtcHRpb24gYm9vc3Qg aXMgdGhhdCB3ZSBtYXkganVtcAo+IC0JICogb3ZlciBsZXNzZXIgcHJpb3JpdGllcyAoc3VjaCBh cyBJOTE1X1BSSU9SSVRZX1dBSVQpLCBlZmZlY3RpdmVseQo+IC0JICogbWFraW5nIHRob3NlIHBy aW9yaXRpZXMgbm9uLXByZWVtcHRpYmxlLiBUaGV5IHdpbGwgYmUgbW92ZWQgZm9yd2FyZAo+IC0J ICogaW4gdGhlIHByaW9yaXR5IHF1ZXVlLCBidXQgdGhleSB3aWxsIG5vdCBnYWluIGltbWVkaWF0 ZSBhY2Nlc3MgdG8KPiAtCSAqIHRoZSBHUFUuCj4gLQkgKi8KPiAtCWlmICh+cHJpbyAmIGJvb3N0 ICYmIF9faTkxNV9yZXF1ZXN0X2hhc19zdGFydGVkKGFjdGl2ZSkpIHsKPiAtCQlwcmlvIHw9IGJv b3N0Owo+IC0JCUdFTV9CVUdfT04oYWN0aXZlLT5zY2hlZC5hdHRyLnByaW9yaXR5ID49IHByaW8p Owo+IC0JCWFjdGl2ZS0+c2NoZWQuYXR0ci5wcmlvcml0eSA9IHByaW87Cj4gLQkJbGlzdF9tb3Zl X3RhaWwoJmFjdGl2ZS0+c2NoZWQubGluaywKPiAtCQkJICAgICAgIGk5MTVfc2NoZWRfbG9va3Vw X3ByaW9saXN0KGVuZ2luZSwgcHJpbykpOwo+IC0JfQo+IC0KPiAgIAlyZXR1cm4gYWN0aXZlOwo+ ICAgfQo+ICAgCj4gQEAgLTQzNiw3ICszOTgsNyBAQCBleGVjbGlzdHNfdW53aW5kX2luY29tcGxl dGVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cykKPiAg IAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPQo+ICAgCQljb250YWluZXJfb2YoZXhl Y2xpc3RzLCB0eXBlb2YoKmVuZ2luZSksIGV4ZWNsaXN0cyk7Cj4gICAKPiAtCXJldHVybiBfX3Vu d2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKGVuZ2luZSwgMCk7Cj4gKwlyZXR1cm4gX191bndpbmRf aW5jb21wbGV0ZV9yZXF1ZXN0cyhlbmdpbmUpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW5saW5l IHZvaWQKPiBAQCAtNjU3LDggKzYxOSw3IEBAIHN0YXRpYyB2b2lkIGNvbXBsZXRlX3ByZWVtcHRf Y29udGV4dChzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzKQo+ICAgCWV4 ZWNsaXN0c19jYW5jZWxfcG9ydF9yZXF1ZXN0cyhleGVjbGlzdHMpOwo+ICAgCV9fdW53aW5kX2lu Y29tcGxldGVfcmVxdWVzdHMoY29udGFpbmVyX29mKGV4ZWNsaXN0cywKPiAgIAkJCQkJCSAgc3Ry dWN0IGludGVsX2VuZ2luZV9jcywKPiAtCQkJCQkJICBleGVjbGlzdHMpLAo+IC0JCQkJICAgICBB Q1RJVkVfUFJJT1JJVFkpOwo+ICsJCQkJCQkgIGV4ZWNsaXN0cykpOwo+ICAgfQo+ICAgCj4gICBz dGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4gQEAgLTE5MTEsNyArMTg3Miw3IEBAIHN0YXRpYyB2b2lkIF9fZXhlY2xpc3RzX3Jlc2V0 KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgYm9vbCBzdGFsbGVkKQo+ICAgCWV4ZWNs aXN0c19jYW5jZWxfcG9ydF9yZXF1ZXN0cyhleGVjbGlzdHMpOwo+ICAgCj4gICAJLyogUHVzaCBi YWNrIGFueSBpbmNvbXBsZXRlIHJlcXVlc3RzIGZvciByZXBsYXkgYWZ0ZXIgdGhlIHJlc2V0LiAq Lwo+IC0JcnEgPSBfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKGVuZ2luZSwgMCk7Cj4gKwly cSA9IF9fdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMoZW5naW5lKTsKPiAgIAlpZiAoIXJxKQo+ ICAgCQlnb3RvIG91dF9yZXBsYXk7Cj4gICAKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=