From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH] drm/i915: Call i915_perf_fini() on init_hw error unwind Date: Sat, 14 Apr 2018 08:40:29 -0700 Message-ID: References: <20180414091233.32224-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D998F6E05C for ; Sat, 14 Apr 2018 15:40:33 +0000 (UTC) In-Reply-To: <20180414091233.32224-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Matthew Auld List-Id: intel-gfx@lists.freedesktop.org T24gMTQvMDQvMTggMDI6MTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBoYXZlIHRvIGNsZWFu dXAgYWZ0ZXIgaTkxNV9wZXJmX2luaXQoKSwgZXZlbiBvbiB0aGUgZXJyb3IgcGF0aCwgYXMgaXQK PiBwYXNzZXMgYSBwb2ludGVyIGludG8gdGhlIG1vZHVsZSB0byB0aGUgc3lzZnMgY29yZS4gSWYg d2UgZmFpbCB0bwo+IHVucmVnaXN0ZXIgdGhlIHN5c2N0bCB0YWJsZSwgd2UgbGVhdmUgYSBkYW5n bGluZyBwb2ludGVyIHdoaWNoIHRoZW4gbWF5Cj4gZXhwbG9kZSBhbnl0aW1lIGxhdGVyIHRoZSBz eXNjdGwgdGFibGUsIHdlIGxlYXZlIGEgZGFuZ2xpbmcgcG9pbnRlcgo+IHdoaWNoIHRoZW4gbWF5 IGV4cGxvZGUgYW55dGltZSBsYXRlci4KPgo+IEZpeGVzOiA5ZjliMjc5MmI2ZDMgKCJkcm0vaTkx NS9wZXJmOiByZXVzZSB0aW1lc3RhbXAgZnJlcXVlbmN5IGZyb20gZGV2aWNlIGluZm8iKQo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENj OiBMaW9uZWwgTGFuZHdlcmxpbiA8bGlvbmVsLmcubGFuZHdlcmxpbkBpbnRlbC5jb20+Cj4gQ2M6 IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBMaW9u ZWwgTGFuZHdlcmxpbiA8bGlvbmVsLmcubGFuZHdlcmxpbkBpbnRlbC5jb20+CgpUaGFua3MgYSBs b3QhCgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8IDIxICsrKysr KysrKysrLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEw IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggOTk0NGEwM2Nk ZWE2Li5iZWFjNTY1ZGRmZTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtMTEw OSwzMCArMTEwOSwzMCBAQCBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX2luaXRfaHcoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCj4gICAJcmV0ID0gaTkxNV9nZ3R0X3Byb2Jl X2h3KGRldl9wcml2KTsKPiAgIAlpZiAocmV0KQo+IC0JCXJldHVybiByZXQ7Cj4gKwkJZ290byBl cnJfcGVyZjsKPiAgIAo+ICAgCS8qIFdBUk5JTkc6IEFwcGFyZW50bHkgd2UgbXVzdCBraWNrIGZi ZGV2IGRyaXZlcnMgYmVmb3JlIHZnYWNvbiwKPiAgIAkgKiBvdGhlcndpc2UgdGhlIHZnYSBmYmRl diBkcml2ZXIgZmFsbHMgb3Zlci4gKi8KPiAgIAlyZXQgPSBpOTE1X2tpY2tfb3V0X2Zpcm13YXJl X2ZiKGRldl9wcml2KTsKPiAgIAlpZiAocmV0KSB7Cj4gICAJCURSTV9FUlJPUigiZmFpbGVkIHRv IHJlbW92ZSBjb25mbGljdGluZyBmcmFtZWJ1ZmZlciBkcml2ZXJzXG4iKTsKPiAtCQlnb3RvIG91 dF9nZ3R0Owo+ICsJCWdvdG8gZXJyX2dndHQ7Cj4gICAJfQo+ICAgCj4gICAJcmV0ID0gaTkxNV9r aWNrX291dF92Z2Fjb24oZGV2X3ByaXYpOwo+ICAgCWlmIChyZXQpIHsKPiAgIAkJRFJNX0VSUk9S KCJmYWlsZWQgdG8gcmVtb3ZlIGNvbmZsaWN0aW5nIFZHQSBjb25zb2xlXG4iKTsKPiAtCQlnb3Rv IG91dF9nZ3R0Owo+ICsJCWdvdG8gZXJyX2dndHQ7Cj4gICAJfQo+ICAgCj4gICAJcmV0ID0gaTkx NV9nZ3R0X2luaXRfaHcoZGV2X3ByaXYpOwo+ICAgCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsK PiArCQlnb3RvIGVycl9nZ3R0Owo+ICAgCj4gICAJcmV0ID0gaTkxNV9nZ3R0X2VuYWJsZV9odyhk ZXZfcHJpdik7Cj4gICAJaWYgKHJldCkgewo+ICAgCQlEUk1fRVJST1IoImZhaWxlZCB0byBlbmFi bGUgR0dUVFxuIik7Cj4gLQkJZ290byBvdXRfZ2d0dDsKPiArCQlnb3RvIGVycl9nZ3R0Owo+ICAg CX0KPiAgIAo+ICAgCXBjaV9zZXRfbWFzdGVyKHBkZXYpOwo+IEBAIC0xMTQzLDcgKzExNDMsNyBA QCBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAgCQlpZiAocmV0KSB7Cj4gICAJCQlEUk1fRVJST1IoImZhaWxlZCB0byBz ZXQgRE1BIG1hc2tcbiIpOwo+ICAgCj4gLQkJCWdvdG8gb3V0X2dndHQ7Cj4gKwkJCWdvdG8gZXJy X2dndHQ7Cj4gICAJCX0KPiAgIAl9Cj4gICAKPiBAQCAtMTE2MSw3ICsxMTYxLDcgQEAgc3RhdGlj IGludCBpOTE1X2RyaXZlcl9pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgIAkJaWYgKHJldCkgewo+ICAgCQkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gc2V0IERNQSBt YXNrXG4iKTsKPiAgIAo+IC0JCQlnb3RvIG91dF9nZ3R0Owo+ICsJCQlnb3RvIGVycl9nZ3R0Owo+ ICAgCQl9Cj4gICAJfQo+ICAgCj4gQEAgLTExOTcsMTMgKzExOTcsMTQgQEAgc3RhdGljIGludCBp OTE1X2RyaXZlcl9pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg IAo+ICAgCXJldCA9IGludGVsX2d2dF9pbml0KGRldl9wcml2KTsKPiAgIAlpZiAocmV0KQo+IC0J CWdvdG8gb3V0X2dndHQ7Cj4gKwkJZ290byBlcnJfZ2d0dDsKPiAgIAo+ICAgCXJldHVybiAwOwo+ ICAgCj4gLW91dF9nZ3R0Ogo+ICtlcnJfZ2d0dDoKPiAgIAlpOTE1X2dndHRfY2xlYW51cF9odyhk ZXZfcHJpdik7Cj4gLQo+ICtlcnJfcGVyZjoKPiArCWk5MTVfcGVyZl9maW5pKGRldl9wcml2KTsK PiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==