From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2. Date: Wed, 1 Nov 2017 16:55:06 +0100 Message-ID: References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> <20171101152903.GF10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171101152903.GF10981@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDEtMTEtMTcgb20gMTY6Mjkgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBO b3YgMDEsIDIwMTcgYXQgMDQ6MDQ6MzNQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFRoaXMgaW50cm9kdWNlcyBhIHNsaWdodCBiZWhhdmlvcmFsIGNoYW5nZSB0byBybWZiLiBJ bnN0ZWFkIG9mCj4+IGRpc2FibGluZyBhIGNydGMgd2hlbiB0aGUgcHJpbWFyeSBwbGFuZSBpcyBk aXNhYmxlZCwgd2UgdHJ5IHRvCj4+IHByZXNlcnZlIGl0Lgo+Pgo+PiBBcGFydCBmcm9tIG9sZCB2 ZXJzaW9ucyBvZiB0aGUgdm13Z2Z4IHhvcmcgZHJpdmVyLCB0aGVyZSBpcwo+PiBub3RoaW5nIGRl cGVuZGluZyBvbiBybWZiIGRpc2FibGluZyBhIGNydGMuCj4+Cj4+IFZtd2dmeCcgYW5kIHNpbXBs ZSBrbXMgaGVscGVyIGF0b21pYyBpbXBsZW1lbnRhdGlvbiByZWplY3RzIENSVEMKPj4gZW5hYmxl ZCB3aXRob3V0IHBsYW5lLCBzbyB3ZSBjYW4gZG8gdGhpcyBzYWZlbHkuCj4+Cj4+IElmIHRoZSBh dG9taWMgY29tbWl0IGlzIHJlamVjdGVkIGJ5IHRoZSBkcml2ZXIgdGhlbiB3ZSB3aWxsIHN0aWxs Cj4+IGZhbGwgYmFjayB0byB0aGUgb2xkIGJlaGF2aW9yIGFuZCB0dXJuIG9mZiB0aGUgY3J0Yy4K Pj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBSZXN0YXJ0IGNvbXBsZXRlbHkgd2hlbiBybWZi IHdpdGggY3J0YyBvbiBmYWlscyAoU2VhbiBQYXVsKS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFh cnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6 IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+PiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Zy YW1lYnVmZmVyLmMgfCAyMyArKysrKysrKysrKysrKysrKy0tLS0tLQo+PiAgMSBmaWxlIGNoYW5n ZWQsIDE3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zy YW1lYnVmZmVyLmMKPj4gaW5kZXggMmFmZmU1M2YzZmRhLi5mMDY3OTQ2OGY0MjEgMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPj4gQEAgLTc2NSwxNCArNzY1LDE4IEBAIHN0YXRp YyBpbnQgYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPj4gIAlz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubjsK Pj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPj4gLQlpbnQgaSwg cmV0ID0gMDsKPj4gKwlpbnQgaSwgcmV0Owo+PiAgCXVuc2lnbmVkIHBsYW5lX21hc2s7Cj4+ICsJ Ym9vbCBkaXNhYmxlX2NydGNzID0gZmFsc2U7Cj4+ICAKPj4gLQlzdGF0ZSA9IGRybV9hdG9taWNf c3RhdGVfYWxsb2MoZGV2KTsKPj4gLQlpZiAoIXN0YXRlKQo+PiAtCQlyZXR1cm4gLUVOT01FTTsK Pj4gLQo+PiArcmV0cnlfZGlzYWJsZToKPj4gIAlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0 eCwgMCk7Cj4+ICsKPj4gKwlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPj4g KwlpZiAoIXN0YXRlKSB7Cj4+ICsJCXJldCA9IC1FTk9NRU07Cj4+ICsJCWdvdG8gb3V0Owo+PiAr CX0KPj4gIAlzdGF0ZS0+YWNxdWlyZV9jdHggPSAmY3R4Owo+PiAgCj4+ICByZXRyeToKPj4gQEAg LTc5Myw3ICs3OTcsNyBAQCBzdGF0aWMgaW50IGF0b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9m cmFtZWJ1ZmZlciAqZmIpCj4+ICAJCQlnb3RvIHVubG9jazsKPj4gIAkJfQo+PiAgCj4+IC0JCWlm IChwbGFuZV9zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSA9PSBwbGFuZSkgewo+PiArCQlpZiAoZGlzYWJs ZV9jcnRjcyAmJiBwbGFuZV9zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSA9PSBwbGFuZSkgewo+PiAgCQkJ c3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiAgCj4+ICAJCQljcnRjX3N0YXRl ID0gZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZShzdGF0ZSwgcGxhbmVfc3RhdGUt PmNydGMpOwo+PiBAQCAtODE4LDYgKzgyMiw3IEBAIHN0YXRpYyBpbnQgYXRvbWljX3JlbW92ZV9m YihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPj4gIAkJcGxhbmUtPm9sZF9mYiA9IHBsYW5l LT5mYjsKPj4gIAl9Cj4+ICAKPj4gKwkvKiBUaGlzIGxpc3QgaXMgb25seSBmaWxsZWQgd2hlbiBk aXNhYmxlX2NydGNzIGlzIHNldC4gKi8KPj4gIAlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0 YXRlKHN0YXRlLCBjb25uLCBjb25uX3N0YXRlLCBpKSB7Cj4gV0FSTl9PTighZGlzYWJsZV9jcnRj cykgbWF5YmU/CldvdWxkIGJlIG92ZXJraWxsLCBub3RoaW5nIGJlZm9yZSBpdCBhZGRzIGNvbm5l Y3RvciBzdGF0ZSwgYW5kIGlmIGF0b21pYyBjaGVjayBkb2VzIHRoZW4gdGhhdCdzIGZpbmUsIGJ1 dCBpdCB3b24ndCBiZSBydW4gaGVyZS4gOikKPj4gIAkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0 Y19mb3JfY29ubmVjdG9yKGNvbm5fc3RhdGUsIE5VTEwpOwo+PiAgCj4+IEBAIC04NDAsOSArODQ1 LDE1IEBAIHN0YXRpYyBpbnQgYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy ICpmYikKPj4gIAo+PiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPj4gIAo+PiArb3V0 Ogo+PiAgCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0eCk7Cj4+ICAJZHJtX21vZGVzZXRfYWNx dWlyZV9maW5pKCZjdHgpOwo+PiAgCj4+ICsJaWYgKHJldCA9PSAtRUlOVkFMICYmICFkaXNhYmxl X2NydGNzKSB7Cj4gSG1tLiAtRUlOVkFMIHNlZW1zIHJhdGhlciBzcGVjaWZpYy4gTm90IHN1cmUg aWYgd2UgY291bGQganVzdCBjaGVjayBmb3IKPiBhbnkgZXJyb3I/Cj4KPiBPci4uLiBJJ20gbm90 IHN1cmUgaWYgd2UgaGF2ZSBhbnkgY2VudHJhbCBwbGFjZSB3aGVyZSB3ZSBkbyB0aGUKPiAiY2Fu IEkgZGlzYWJsZSB0aGUgcHJpbWFyeSBwbGFuZSB3L28gZGlzYWJsaW5nIHRoZSBjcnRjPyIgY2hl Y2suIElmIHdlCj4gZG8gdGhlbiB3ZSBjb3VsZCBhbHNvIGFkZCBhIGNvbW1lbnQgdGhlcmUgaW5m b3JtaW5nIHBlb3BsZSB0aGF0IHRoZQo+IC1FSU5WQUwgaXMgaW1wb3J0YW50LgpXZSBkb24ndCBo YXZlIGEgY2VudHJhbCBwbGFjZSwgSSBjaGVjayBmb3IgRUlOVkFMIHNpbmNlIHRoYXQgaXMgdGhl IGdlbmVyaWMgYXRvbWljX2NoZWNrKCkgZmFpbGVkIGVycm9yLiBJZiBpdCBmYWlscyBmb3IgYW55 IG90aGVyIHJlYXNvbiB0aGVuIHdlIGRvbid0IGhhdmUgdG8gcmV0cnksIGJ1dCBwYXNzIGl0IGFs b25nLiA6KQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==