From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 4/6] drm/i915: switch ring->id to be a real
	id
Date: Tue, 11 Oct 2011 16:55:17 +0100
Message-ID: <aefc95$1qt095@orsmga001.jf.intel.com>
References: <1318343954-14607-1-git-send-email-daniel.vetter@ffwll.ch>
	<1318343954-14607-4-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5E1869E9E2
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 11 Oct 2011 08:55:24 -0700 (PDT)
In-Reply-To: <1318343954-14607-4-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 11 Oct 2011 16:39:12 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... and add a helpr function for the places where we want a flag.
> 
> This way we can use ring->id to index into arrays.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c        |    8 ++++----
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    4 ++--
>  drivers/gpu/drm/i915/i915_irq.c            |    2 +-
>  drivers/gpu/drm/i915/intel_ringbuffer.c    |   14 +++++++-------
>  drivers/gpu/drm/i915/intel_ringbuffer.h    |   20 ++++++++++----------
>  5 files changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 8e95d66..75c5dd6 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -659,9 +659,9 @@ static int i915_ringbuffer_info(struct seq_file *m, void *data)
>  static const char *ring_str(int ring)
>  {
>  	switch (ring) {
> -	case RING_RENDER: return " render";
> -	case RING_BSD: return " bsd";
> -	case RING_BLT: return " blt";
> +	case RCS: return "render";
> +	case VCS: return "bsd";
> +	case BCS: return "blt";
>  	default: return "";

You dropped the beautifying space. On purpose?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre