From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 7/7] drm/i915: enable ppgtt
Date: Thu, 09 Feb 2012 16:39:06 +0000
Message-ID: <aefc95$34qdib@orsmga001.jf.intel.com>
References: <1328804150-19522-1-git-send-email-daniel.vetter@ffwll.ch>
	<1328804150-19522-8-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id A60A4A0B74
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  9 Feb 2012 08:39:29 -0800 (PST)
In-Reply-To: <1328804150-19522-8-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Thu,  9 Feb 2012 17:15:50 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> v3: Pimp commit message and make Chris Wilson less grumpy by adding a
> module option.

> +void i915_gem_init_ppgtt(struct drm_device *dev)
> +{
> +	drm_i915_private_t *dev_priv = dev->dev_private;
> +	uint32_t pd_offset;
> +	struct intel_ring_buffer *ring;
> +	int i;
> +
> +	if (i915_enable_ppgtt && !HAS_ALIASING_PPGTT(dev))
> +		return;
> +

This is quite a late check since we have already partitioned the
aperture and run i915_gem_init_aliasing_ppgtt. I think the enable check
should be done earlier and this check reduced to
  if (!dev_priv->mm.aliasing_ppgtt)
    return;

Bah humbug!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre