From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2406AFDEE3F for ; Thu, 23 Apr 2026 18:57:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B287C10E36D; Thu, 23 Apr 2026 18:57:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="azNnLgEF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 764BF10E09B; Thu, 23 Apr 2026 18:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776970653; x=1808506653; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=wKEN1wbbY38h+ZNf6pLdJyW35dWeJ3pFr2TOqCLpOMM=; b=azNnLgEFA5U71MeFr7ouam/9LZiU0Fvsd9GoPjUHPwCn8Rk6jqOYZTir xQVEEIrzgP3qoyE4w4E8xEiNuT58KgeIdVo84fsCfmy4LFoJ/oVesEAxN IWTd9abmWhaJCJlHq321GQKhEZwliKZbcHo+ChmNlPT2WeGfAJWOy3vyE bP5lT6c+o4J7S5icnESWiXknYBXNvmmL1gxvcAquXePvBktfqbOzNHc2z aqVwystR6U9SxnklFODjH8XF3BYoJKitOg7C9uR6D41p7TZSW9/q4UrSj DfNT0fPpaGOwWbAjUeTr3BBzP94GBI1Xwx9TmCrk6XPm7gA/B/jEOFAPL w==; X-CSE-ConnectionGUID: TrOfUD5NSBuLFAGHY5c4Aw== X-CSE-MsgGUID: 2/QO3m2ESiSPr9cvMTxvIw== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="100602843" X-IronPort-AV: E=Sophos;i="6.23,195,1770624000"; d="scan'208";a="100602843" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 11:57:32 -0700 X-CSE-ConnectionGUID: PHe7/TScSoy9IY801Vpskw== X-CSE-MsgGUID: qC2ce3H2S9y/RcWxWwYoKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,195,1770624000"; d="scan'208";a="232644317" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.188]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 11:57:30 -0700 Date: Thu, 23 Apr 2026 21:57:26 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Juha-Pekka Heikkila Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Jani Nikula Subject: Re: [PATCH v2] drm/i915/display: enable ccs modifiers on dg2 Message-ID: References: <20260423141148.3145665-1-juhapekka.heikkila@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260423141148.3145665-1-juhapekka.heikkila@gmail.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Apr 23, 2026 at 05:11:48PM +0300, Juha-Pekka Heikkila wrote: > Since Xe driver aux ccs enablement dg2 ccs modifiers have been > disabled on both Xe and i915 drivers. Here allow dg2 to use > ccs again for framebuffers. I don't think they got disabled on xe since it just (for whatever random reason) checks for ADL in its has_auxccs(). With the commit message sorted out this is Reviewed-by: Ville Syrjälä > > Fixes: 6a99e91a6ca8fec5882450128fb128265f86b32a ("drm/i915/display: Detect AuxCCS support via display parent interface") > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i915/i915_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index d31819758f3d..a4bd4f8e18b2 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -750,9 +750,8 @@ static bool has_auxccs(struct drm_device *drm) > { > struct drm_i915_private *i915 = to_i915(drm); > > - return IS_GRAPHICS_VER(i915, 9, 12) || > - IS_ALDERLAKE_P(i915) || > - IS_METEORLAKE(i915); > + return IS_GRAPHICS_VER(i915, 9, 12) && > + !HAS_FLAT_CCS(i915); > } > > static bool has_fenced_regions(struct drm_device *drm) > -- > 2.43.0 -- Ville Syrjälä Intel