From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9E90CD342F for ; Fri, 8 May 2026 09:41:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B64A10E028; Fri, 8 May 2026 09:41:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="H60nrMJQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id D168610E028 for ; Fri, 8 May 2026 09:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778233280; x=1809769280; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=l8aFjSNZubKpdHQfKwAA52+sFPDa1PU7V0J1cGar/cQ=; b=H60nrMJQ56K9FeJXEd8pJI9VW+aqEW6iSh86vU7yZk8YZ56elwz0MxYi qBpS1nUhX5Esc6Eqjf5tkoUgfY+Q6kozmEbwL5fsQw6nw1pxYcR6dE3XA cWJMNO045IxUyFNpUt5p0biPxhW95h7mptlUGGvdc721sRgjT3eS3bDEb Z5ugl7ii6hF29jH/6qIzgBMuwoTv2lN1ADdEnAPKVnMcW+JvJmWUt61lP UkW69WYmpa/Y81oaNxNmNWq3qfY0WdsnteEUAOpMFrssw7XcPZffUy5ko lSsd50KBLcQmSCQvWOwrav2WCO2xBcHnVrSWx56YRllLtfumkMQe639xI g==; X-CSE-ConnectionGUID: JMcvRuskSweK90JvFwyo8g== X-CSE-MsgGUID: e12T+0lvS32lXOZ/wczcoQ== X-IronPort-AV: E=McAfee;i="6800,10657,11779"; a="96767833" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="96767833" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 02:41:19 -0700 X-CSE-ConnectionGUID: i4QmJJBHRYOzOq+Wvo7h2g== X-CSE-MsgGUID: wjsfYX3RRSO27KKNBNo9Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="238504237" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.67]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 02:41:17 -0700 Date: Fri, 8 May 2026 11:41:14 +0200 From: Andi Shyti To: Krzysztof Karas Cc: intel-gfx@lists.freedesktop.org, Andi Shyti , Sebastian Brzezinka , Krzysztof Niemiec , Janusz Krzysztofik Subject: Re: [PATCH v10 1/2] drm/i915/selftests: Prevent userspace mapping invalidation Message-ID: References: <20260508080214.1979686-1-krzysztof.karas@intel.com> <20260508080214.1979686-2-krzysztof.karas@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508080214.1979686-2-krzysztof.karas@intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Krzysztof, ... > +static struct mm_struct * > +get_mm(int u_pid_nr) This fits in one line, no need to break it. I'm not a big fan of the name "get_mm()". It's too generic and sounds like a library function. With the two above changed: Reviewed-by: Andi Shyti On the other hand I don't want to ask for v11: if it's OK with you I would bring the lines together and change the function to get_selftest_mm() before merging. Let me know, Andi