From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV Date: Fri, 16 Aug 2019 08:33:54 -0700 Message-ID: References: <20190816012343.36433-1-daniele.ceraolospurio@intel.com> <20190816012343.36433-5-daniele.ceraolospurio@intel.com> <875zmxfo6r.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A1D26E47F for ; Fri, 16 Aug 2019 15:33:55 +0000 (UTC) In-Reply-To: <875zmxfo6r.fsf@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA4LzE2LzE5IDI6MzUgQU0sIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIFRodSwgMTUgQXVn IDIwMTksIERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRl bC5jb20+IHdyb3RlOgo+PiBUaGlzIGlzIG9ubHkgcmVxdWlyZWQgZm9yIGEgc2luZ2xlIHBsYXRm b3JtIHNvIG5vIG5lZWQgdG8gcmVzZXJ2ZSB0aGUKPj4gbWVtb3J5IG9uIGFsbCBvZiB0aGVtLgo+ Pgo+PiBUaGlzIHJlbW92ZXMgdGhlIGxhc3QgZGlyZWN0IGRlcGVuZGVuY3kgb2YgaTkxNV9kcnYu aCBvbiBpOTE1X3JlZy5oCj4+IChhcGFydCBmcm9tIHRoZSBpOTE1X3JlZ190IGRlZmluaXRpb24p Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNl cmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgo+IAo+IEhlaCwgSSd2ZSBhbHJlYWR5IHNlbnQgYSB2ZXJzaW9uIG9mIHRoaXMgWzFdLCBi dXQgSSBkb24ndCBtaW5kIHlvdQo+IGZpbmlzaGluZyB0aGUgam9iLiBFc3BlY2lhbGx5IGJlY2F1 c2UgSSB0aGluayBpdCdzIGJldHRlciB0byBoYW5kbGUgdGhlCj4gYWxsb2MvZnJlZSBleHBsaWNp dGx5IGluc3RlYWQgb2YgdGhlIHdheSBJIGRvIGl0LgoKRCdvaCEgSSBjb21wbGV0ZWx5IG1pc3Nl ZCB0aGF0Cgo+IAo+IEkgZG8gaGF2ZSBzb21lIG5pdHBpY2tzIG9uIHRoaXMgb25lIHRob3VnaCwg aW5saW5lLgo+IAo+IAo+IFsxXSBodHRwOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRj aC9tc2dpZC8yMDE5MDgwNzE0NDkzOS4zMjEyMy0xLWphbmkubmlrdWxhQGludGVsLmNvbQo+IAo+ IAoKPHNuaXA+CgoKPj4gQEAgLTIxMzcsNyArMjIyOCw3IEBAIHN0YXRpYyBpbnQgaTkxNV9wbV9y ZXN0b3JlKHN0cnVjdCBkZXZpY2UgKmtkZXYpCj4+ICAgICovCj4+ICAgc3RhdGljIHZvaWQgdmx2 X3NhdmVfZ3VuaXRfczBpeF9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4+ICAgewo+PiAtCXN0cnVjdCB2bHZfczBpeF9zdGF0ZSAqcyA9ICZkZXZfcHJpdi0+dmx2X3Mw aXhfc3RhdGU7Cj4+ICsJc3RydWN0IHZsdl9zMGl4X3N0YXRlICpzID0gZGV2X3ByaXYtPnMwaXhf c3RhdGU7Cj4gCj4gSSB0aGluayBJJ2Qgbm93IGNhbGwgdGhpcyBmdW5jdGlvbiB1bmNvbmRpdGlv bmFsbHksIGFuZCByZXR1cm4gZWFybHkgaWYKPiAoIXMpLiBUaGlzIHB1dHMgdGhlIGRlY2lzaW9u IHRvIGRvIHRoaXMgb3Igbm90IGluIG9uZSBwbGFjZSBvbmx5LCBpbgo+IHZsdl9hbGxvY19zMGl4 X3N0YXRlKCksIGluc3RlYWQgb2YgZHVwbGljYXRpbmcgdGhlIGNvbmRpdGlvbnMuCgphY2sKCj4g Cj4gCj4+ICAgCWludCBpOwo+PiAgIAo+PiAgIAkvKiBHQU0gMHg0MDAwLTB4NDc3MCAqLwo+PiBA QCAtMjE0Nyw3ICsyMjM4LDcgQEAgc3RhdGljIHZvaWQgdmx2X3NhdmVfZ3VuaXRfczBpeF9zdGF0 ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgCXMtPmdmeF9wZW5kX3Rs YjAJPSBJOTE1X1JFQUQoR0VON19HRlhfUEVORF9UTEIwKTsKPj4gICAJcy0+Z2Z4X3BlbmRfdGxi MQk9IEk5MTVfUkVBRChHRU43X0dGWF9QRU5EX1RMQjEpOwo+PiAgIAo+PiAtCWZvciAoaSA9IDA7 IGkgPCBBUlJBWV9TSVpFKHMtPmxyYV9saW1pdHMpOyBpKyspCj4+ICsJZm9yIChpID0gMDsgaSA8 IEdFTjdfTFJBX0xJTUlUU19SRUdfTlVNOyBpKyspCj4+ICAgCQlzLT5scmFfbGltaXRzW2ldID0g STkxNV9SRUFEKEdFTjdfTFJBX0xJTUlUUyhpKSk7Cj4+ICAgCj4+ICAgCXMtPm1lZGlhX21heF9y ZXFfY291bnQJPSBJOTE1X1JFQUQoR0VON19NRURJQV9NQVhfUkVRX0NPVU5UKTsKPj4gQEAgLTIx OTEsNyArMjI4Miw3IEBAIHN0YXRpYyB2b2lkIHZsdl9zYXZlX2d1bml0X3MwaXhfc3RhdGUoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgIAlzLT5wbV9pbXIJCT0gSTkxNV9S RUFEKEdFTjZfUE1JTVIpOwo+PiAgIAlzLT5wbV9pZXIJCT0gSTkxNV9SRUFEKEdFTjZfUE1JRVIp Owo+PiAgIAo+PiAtCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHMtPmd0X3NjcmF0Y2gpOyBp KyspCj4+ICsJZm9yIChpID0gMDsgaSA8IEdFTjdfR1RfU0NSQVRDSF9SRUdfTlVNOyBpKyspCj4+ ICAgCQlzLT5ndF9zY3JhdGNoW2ldID0gSTkxNV9SRUFEKEdFTjdfR1RfU0NSQVRDSChpKSk7Cj4g Cj4gVGhlIGFib3ZlIHR3byBodW5rcyBhcmUgaW4gdGhlIHdyb25nIHBhdGNoLgo+IAoKWXVwLCBs ZWZ0b3ZlcnMgZnJvbSBhIHByZXZpb3VzIHZlcnNpb24uCgo+PiAgIAo+PiAgIAkvKiBHVCBTQSBD WiBkb21haW4sIDB4MTAwMDAwLTB4MTM4MTI0ICovCj4+IEBAIC0yMjE4LDcgKzIzMDksNyBAQCBz dGF0aWMgdm9pZCB2bHZfc2F2ZV9ndW5pdF9zMGl4X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPj4gICAKPj4gICBzdGF0aWMgdm9pZCB2bHZfcmVzdG9yZV9ndW5pdF9z MGl4X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gICB7Cj4+IC0J c3RydWN0IHZsdl9zMGl4X3N0YXRlICpzID0gJmRldl9wcml2LT52bHZfczBpeF9zdGF0ZTsKPj4g KwlzdHJ1Y3Qgdmx2X3MwaXhfc3RhdGUgKnMgPSBkZXZfcHJpdi0+czBpeF9zdGF0ZTsKPiAKPiBF YXJseSByZXR1cm4gb24gIXMgaGVyZSBhcyB3ZWxsLCBhbmQgY2FsbCB0aGUgZnVuY3Rpb24gdW5j b25kaXRpb25hbGx5Lgo+IAoKb2sKCj4+ICAgCXUzMiB2YWw7Cj4+ICAgCWludCBpOwo+PiAgIAo+ PiBAQCAtMjIyOSw3ICsyMzIwLDcgQEAgc3RhdGljIHZvaWQgdmx2X3Jlc3RvcmVfZ3VuaXRfczBp eF9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgCUk5MTVfV1JJ VEUoR0VON19HRlhfUEVORF9UTEIwLAlzLT5nZnhfcGVuZF90bGIwKTsKPj4gICAJSTkxNV9XUklU RShHRU43X0dGWF9QRU5EX1RMQjEsCXMtPmdmeF9wZW5kX3RsYjEpOwo+PiAgIAo+PiAtCWZvciAo aSA9IDA7IGkgPCBBUlJBWV9TSVpFKHMtPmxyYV9saW1pdHMpOyBpKyspCj4+ICsJZm9yIChpID0g MDsgaSA8IEdFTjdfTFJBX0xJTUlUU19SRUdfTlVNOyBpKyspCj4+ICAgCQlJOTE1X1dSSVRFKEdF TjdfTFJBX0xJTUlUUyhpKSwgcy0+bHJhX2xpbWl0c1tpXSk7Cj4+ICAgCj4+ICAgCUk5MTVfV1JJ VEUoR0VON19NRURJQV9NQVhfUkVRX0NPVU5ULCBzLT5tZWRpYV9tYXhfcmVxX2NvdW50KTsKPj4g QEAgLTIyNzMsNyArMjM2NCw3IEBAIHN0YXRpYyB2b2lkIHZsdl9yZXN0b3JlX2d1bml0X3MwaXhf c3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgIAlJOTE1X1dSSVRF KEdFTjZfUE1JTVIsCQlzLT5wbV9pbXIpOwo+PiAgIAlJOTE1X1dSSVRFKEdFTjZfUE1JRVIsCQlz LT5wbV9pZXIpOwo+PiAgIAo+PiAtCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHMtPmd0X3Nj cmF0Y2gpOyBpKyspCj4+ICsJZm9yIChpID0gMDsgaSA8IEdFTjdfR1RfU0NSQVRDSF9SRUdfTlVN OyBpKyspCj4+ICAgCQlJOTE1X1dSSVRFKEdFTjdfR1RfU0NSQVRDSChpKSwgcy0+Z3Rfc2NyYXRj aFtpXSk7Cj4gCj4gVGhlIGFib3ZlIHR3byBodW5rcyBhcmUgaW4gdGhlIHdyb25nIHBhdGNoLgo+ IAo+PiAgIAo+PiAgIAkvKiBHVCBTQSBDWiBkb21haW4sIDB4MTAwMDAwLTB4MTM4MTI0ICovCj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRleCBjNjcyMmQ1NGNjZDUuLjliNDFmMjIwOWI2 OSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC01MjcsNjggKzUyNyw2IEBA IHN0cnVjdCBpOTE1X3N1c3BlbmRfc2F2ZWRfcmVnaXN0ZXJzIHsKPj4gICAJdTE2IHNhdmVHQ0RH TUJVUzsKPj4gICB9Owo+PiAgIAo+PiAtc3RydWN0IHZsdl9zMGl4X3N0YXRlIHsKPj4gLQkvKiBH QU0gKi8KPj4gLQl1MzIgd3Jfd2F0ZXJtYXJrOwo+PiAtCXUzMiBnZnhfcHJpb19jdHJsOwo+PiAt CXUzMiBhcmJfbW9kZTsKPj4gLQl1MzIgZ2Z4X3BlbmRfdGxiMDsKPj4gLQl1MzIgZ2Z4X3BlbmRf dGxiMTsKPj4gLQl1MzIgbHJhX2xpbWl0c1tHRU43X0xSQV9MSU1JVFNfUkVHX05VTV07Cj4+IC0J dTMyIG1lZGlhX21heF9yZXFfY291bnQ7Cj4+IC0JdTMyIGdmeF9tYXhfcmVxX2NvdW50Owo+PiAt CXUzMiByZW5kZXJfaHdzcDsKPj4gLQl1MzIgZWNvY2hrOwo+PiAtCXUzMiBic2RfaHdzcDsKPj4g LQl1MzIgYmx0X2h3c3A7Cj4+IC0JdTMyIHRsYl9yZF9hZGRyOwo+PiAtCj4+IC0JLyogTUJDICov Cj4+IC0JdTMyIGczZGN0bDsKPj4gLQl1MzIgZ3Nja2djdGw7Cj4+IC0JdTMyIG1iY3RsOwo+PiAt Cj4+IC0JLyogR0NQICovCj4+IC0JdTMyIHVjZ2N0bDE7Cj4+IC0JdTMyIHVjZ2N0bDM7Cj4+IC0J dTMyIHJjZ2N0bDE7Cj4+IC0JdTMyIHJjZ2N0bDI7Cj4+IC0JdTMyIHJzdGN0bDsKPj4gLQl1MzIg bWlzY2NwY3RsOwo+PiAtCj4+IC0JLyogR1BNICovCj4+IC0JdTMyIGdmeHBhdXNlOwo+PiAtCXUz MiBycGRldWh3dGM7Cj4+IC0JdTMyIHJwZGV1YzsKPj4gLQl1MzIgZWNvYnVzOwo+PiAtCXUzMiBw d3Jkd251cGN0bDsKPj4gLQl1MzIgcnBfZG93bl90aW1lb3V0Owo+PiAtCXUzMiBycF9kZXVjc3c7 Cj4+IC0JdTMyIHJjdWJtYWJkdG1yOwo+PiAtCXUzMiByY2VkYXRhOwo+PiAtCXUzMiBzcGFyZTJn aDsKPj4gLQo+PiAtCS8qIERpc3BsYXkgMSBDWiBkb21haW4gKi8KPj4gLQl1MzIgZ3RfaW1yOwo+ PiAtCXUzMiBndF9pZXI7Cj4+IC0JdTMyIHBtX2ltcjsKPj4gLQl1MzIgcG1faWVyOwo+PiAtCXUz MiBndF9zY3JhdGNoW0dFTjdfR1RfU0NSQVRDSF9SRUdfTlVNXTsKPj4gLQo+PiAtCS8qIEdUIFNB IENaIGRvbWFpbiAqLwo+PiAtCXUzMiB0aWxlY3RsOwo+PiAtCXUzMiBndF9maWZvY3RsOwo+PiAt CXUzMiBndGxjX3dha2VfY3RybDsKPj4gLQl1MzIgZ3RsY19zdXJ2aXZlOwo+PiAtCXUzMiBwbXdn aWN6Owo+PiAtCj4+IC0JLyogRGlzcGxheSAyIENaIGRvbWFpbiAqLwo+PiAtCXUzMiBndV9jdGww Owo+PiAtCXUzMiBndV9jdGwxOwo+PiAtCXUzMiBwY2JyOwo+PiAtCXUzMiBjbG9ja19nYXRlX2Rp czI7Cj4+IC19Owo+PiAtCj4+ICAgc3RydWN0IGludGVsX3Jwc19laSB7Cj4+ICAgCWt0aW1lX3Qg a3RpbWU7Cj4+ICAgCXUzMiByZW5kZXJfYzA7Cj4+IEBAIC0xNjIyLDcgKzE1NjAsNyBAQCBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSB7Cj4+ICAgCXUzMiBzdXNwZW5kX2NvdW50Owo+PiAgIAlib29s IHBvd2VyX2RvbWFpbnNfc3VzcGVuZGVkOwo+PiAgIAlzdHJ1Y3QgaTkxNV9zdXNwZW5kX3NhdmVk X3JlZ2lzdGVycyByZWdmaWxlOwo+PiAtCXN0cnVjdCB2bHZfczBpeF9zdGF0ZSB2bHZfczBpeF9z dGF0ZTsKPj4gKwl2b2lkICpzMGl4X3N0YXRlOwo+IAo+IEknZCBrZWVwIHRoZSB2bHZfIHByZWZp eCBpbiB0aGUgbWVtYmVyIG5hbWUuCgpvayAoaW5jbHVkaW5nIHRoZSBmd2QgZGVjbCBtZW50aW9u ZWQgaW4gdGhlIG90aGVyIHJlcGx5KQoKRGFuaWVsZQoKPiAKPiBCUiwKPiBKYW5pLgo+IAo+IAo+ PiAgIAo+PiAgIAllbnVtIHsKPj4gICAJCUk5MTVfU0FHVl9VTktOT1dOID0gMCwKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4