From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 793DCCD5BAC for ; Thu, 21 May 2026 13:59:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02E3C10F322; Thu, 21 May 2026 13:59:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="LaeHuEPF"; dkim-atps=neutral Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C53310F322 for ; Thu, 21 May 2026 13:59:35 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c829366cf25so9100256a12.0 for ; Thu, 21 May 2026 06:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779371975; x=1779976775; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tqeEG6FXEKElqAGUt/Z2qfbIbuB++N7b4Fh1Zt6D5dk=; b=LaeHuEPF4pjPUTSbVcOjQruLCEQrUjktDsmvyqaeq1dt+/a9exufdiJb2cXAzubyyO mJWWuRCfqukKNmIGiYBymo7u5pechE6jmFTi1g9HfcOJ8WvGr+ZYcI0wHzKeOVvfzt96 jzo52EuD0fUSmbVnpKDRKcmZ3ieQIZC68HEW8FUwtJc1bjYj5rMye7/78XdDRoFEj1wp nXYWRrG4p+QoQ6qDi/OFZZ7D5dZJewBHH5TGDYMcpp4yVBX/+wl/1rIkNzbs40jiPZ1w Llu6IXFwix4/yEJAi5v/WmE2H/CEV2sgIxeEWRY8GZrjlNqMtzhYz5WbitmKyQHBcsgb 8akA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779371975; x=1779976775; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tqeEG6FXEKElqAGUt/Z2qfbIbuB++N7b4Fh1Zt6D5dk=; b=AcS9+tBmU5wtoKb9QYFasKEI5rV3UDLObB5Qor+nD9Wi3WWlUjD1wEEuCXYIKoGCro NBuyEV7b5kE8kw6sRt8IT0nG5lSdQ0zkMdw4c+pb3NXhAULgZ3jeSgZ/y90d42oTFAHm ol2t5FAzOzlr2oGKKFaZQnmlYkxkbTP7jgCIiVTcs91by2Cgurzn0a7rWUsYqMz2xEFG AoPvHrZES9J+V4ww73/cFmQvqDjSKotJt9CJQ/bowbaHjS0klToE2zzggtwO2IAovFm8 lXPl7cm5k0xAM+k8V/6s2+pppEzbG143yjS64SxW6sAIVxsiEZiFdkwczAl/l+jjjmtE jKzw== X-Forwarded-Encrypted: i=1; AFNElJ/vTiydmjwOrdNmmbT5m58xoLzyy5wR8vIzbfMcX9LAcIlXpteC9pCROpFf5l1924BRTj71X8U7GAQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw9pUsUz5dqw0odojZXJeSa3mQONtUqQpObkEcIfvhYJYZTqgCE E/2yzrO8aH/rqU+xbrA9wi6yPwbFO1lVrexbkWPOFvjCQ+fDW2o4Kn+sm3j8OZXGWficByfCY0E 2WOUFdQ== X-Received: from pge1.prod.google.com ([2002:a05:6a02:2d01:b0:c79:83b3:cdf8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:431a:b0:39c:a78e:dba9 with SMTP id adf61e73a8af0-3b308ac1b14mr3725831637.40.1779371973881; Thu, 21 May 2026 06:59:33 -0700 (PDT) Date: Thu, 21 May 2026 06:59:33 -0700 In-Reply-To: <20260521133326.2465264-4-kees@kernel.org> Mime-Version: 1.0 References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-4-kees@kernel.org> Message-ID: Subject: Re: [PATCH 04/11] treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS From: Sean Christopherson To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , "Eugenio =?utf-8?B?UMOpcmV6?=" , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , "Ilpo =?utf-8?B?SsOkcnZpbmVu?=" , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, May 21, 2026, Kees Cook wrote: > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > for example: > > @@ > declarer name DEFINE_KERNEL_PARAM_OPS; > identifier OPS; > expression SET, GET; > @@ > - const struct kernel_param_ops OPS = { > - .set = SET, > - .get = GET, > - }; > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); IMO, "OPS, GET, SET" is more intuitive, especially since that's the order used by DEFINE_SIMPLE_ATTRIBUTE and DEFINE_DEBUGFS_ATTRIBUTE.