From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F08C7CD4F21 for ; Wed, 13 May 2026 13:56:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DD0D10E5DA; Wed, 13 May 2026 13:56:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="YZV+i9x1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28D3910E34C; Wed, 13 May 2026 13:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778680573; x=1810216573; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=+Ps0dEkCG/iGFWfwapIoammPZPeI74waiyytbp8aUXw=; b=YZV+i9x1lG614+hBr+MjxDP30yzLDhWsWwBMdzTZG568HNGBpwCE3mJH PPLk0rwlWTfRE4G6CN15sXSHJ5RFBR9X/LTHQFVohq5hryjWIaA8EmTjl uy2ifvgf0jzshdMhLw4fRJQZXlcvOiWvYkk+r5ZysJhBfc8j9ucOQU0yO k//yDVpGJdHvxNsVtXukQV4q89Rl2wsZro3FTcHFEx4xkTaMTsGfQv4Qr m2IqERB7wiN2Y/T9+ZaxnnQ+Xmku4ufZctxlx0OMzVVHQlvlvlRs9A5Dj IHKN9bbEw8KP/VFbrT35SmlzMoijoKtbgcJOvV1o7a4sti/9ZMunKbRxR Q==; X-CSE-ConnectionGUID: Y30yHYC9S6K5/MzPm77ncw== X-CSE-MsgGUID: YZluNalyRMap022RIGgROQ== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="79466032" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="79466032" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 06:56:13 -0700 X-CSE-ConnectionGUID: e1Py8JABTaaVnFlElNYwDw== X-CSE-MsgGUID: 6SPjU/kBRyWonQW709dSkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="235418394" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.10]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 06:56:11 -0700 Date: Wed, 13 May 2026 16:56:08 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v3 3/6] drm/i915/irq: add display irq funcs, start with intel_display_irq_reset() Message-ID: References: <8cf49ccdb19c7263ac832714577d1a5cf2e20f00.1778666967.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8cf49ccdb19c7263ac832714577d1a5cf2e20f00.1778666967.git.jani.nikula@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, May 13, 2026 at 01:10:08PM +0300, Jani Nikula wrote: > Introduce display irq hooks with struct intel_display_irq_funcs, and add > the ->reset hook as the first thing. Call the reset hooks from i915 and > xe core via intel_display_irq_reset(). > > Relocate the gen8 and gen11 HAS_DISPLAY() check to > intel_display_irq_reset(), as the funcs pointer won't be initialized for > no display. > > Note: We're increasingly moving to the territory of not touching display > at all if there's no display or it has been fused off. Which is good, > but care must be taken to not have hardware setup required also for no > display cases in display code. Also note that the line is fuzzy for > older platforms, but there we also don't have fusing. > > v2: > - make the structs static const (Sashiko) > - relocate HAS_DISPLAY() (Sashiko) > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > .../gpu/drm/i915/display/intel_display_core.h | 3 + > .../gpu/drm/i915/display/intel_display_irq.c | 61 +++++++++++++++---- > .../gpu/drm/i915/display/intel_display_irq.h | 6 +- > drivers/gpu/drm/i915/i915_irq.c | 16 ++--- > drivers/gpu/drm/xe/display/xe_display.c | 2 +- > 5 files changed, 63 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h > index 76745ce6a716..3dc5ac75a98b 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_core.h > +++ b/drivers/gpu/drm/i915/display/intel_display_core.h > @@ -475,6 +475,9 @@ struct intel_display { > } ips; > > struct { > + /* internal display irq functions */ > + const struct intel_display_irq_funcs *funcs; > + > /* protects the irq masks */ > spinlock_t lock; > > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c > index d30b063714b0..62a849673454 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_irq.c > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c > @@ -1947,7 +1947,7 @@ static void _vlv_display_irq_reset(struct intel_display *display) > display->irq.vlv_imr_mask = ~0u; > } > > -void vlv_display_irq_reset(struct intel_display *display) > +static void vlv_display_irq_reset(struct intel_display *display) > { > spin_lock_irq(&display->irq.lock); > if (display->irq.vlv_display_irqs_enabled) > @@ -1955,7 +1955,7 @@ void vlv_display_irq_reset(struct intel_display *display) > spin_unlock_irq(&display->irq.lock); > } > > -void i9xx_display_irq_reset(struct intel_display *display) > +static void i9xx_display_irq_reset(struct intel_display *display) > { > if (HAS_HOTPLUG(display)) { > i915_hotplug_interrupt_update(display, 0xffffffff, 0); > @@ -2076,7 +2076,7 @@ static void ibx_display_irq_reset(struct intel_display *display) > intel_de_write(display, SERR_INT, 0xffffffff); > } > > -void ilk_display_irq_reset(struct intel_display *display) > +static void ilk_display_irq_reset(struct intel_display *display) > { > irq_reset(display, DE_IRQ_REGS); > display->irq.ilk_de_imr_mask = ~0u; > @@ -2092,13 +2092,10 @@ void ilk_display_irq_reset(struct intel_display *display) > ibx_display_irq_reset(display); > } > > -void gen8_display_irq_reset(struct intel_display *display) > +static void gen8_display_irq_reset(struct intel_display *display) > { > enum pipe pipe; > > - if (!HAS_DISPLAY(display)) > - return; > - > intel_de_write(display, EDP_PSR_IMR, 0xffffffff); > intel_de_write(display, EDP_PSR_IIR, 0xffffffff); > > @@ -2114,15 +2111,12 @@ void gen8_display_irq_reset(struct intel_display *display) > ibx_display_irq_reset(display); > } > > -void gen11_display_irq_reset(struct intel_display *display) > +static void gen11_display_irq_reset(struct intel_display *display) > { > enum pipe pipe; > u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | > BIT(TRANSCODER_C) | BIT(TRANSCODER_D); > > - if (!HAS_DISPLAY(display)) > - return; > - > intel_de_write(display, GEN11_DISPLAY_INT_CTL, 0); > > if (DISPLAY_VER(display) >= 12) { > @@ -2453,6 +2447,38 @@ struct intel_display_irq_funcs { > void (*reset)(struct intel_display *display); > }; > > +static const struct intel_display_irq_funcs gen11_display_irq_funcs = { > + .reset = gen11_display_irq_reset, > +}; > + > +static const struct intel_display_irq_funcs gen8_display_irq_funcs = { > + .reset = gen8_display_irq_reset, > +}; > + > +static const struct intel_display_irq_funcs vlv_display_irq_funcs = { > + .reset = vlv_display_irq_reset, > +}; > + > +static const struct intel_display_irq_funcs ilk_display_irq_funcs = { > + .reset = ilk_display_irq_reset, > +}; > + > +static const struct intel_display_irq_funcs i965_display_irq_funcs = { > + .reset = i9xx_display_irq_reset, > +}; > + > +static const struct intel_display_irq_funcs i915_display_irq_funcs = { > + .reset = i9xx_display_irq_reset, > +}; > + > +void intel_display_irq_reset(struct intel_display *display) > +{ > + if (!HAS_DISPLAY(display)) > + return; > + > + display->irq.funcs->reset(display); > +} > + > void intel_display_irq_init(struct intel_display *display) > { > spin_lock_init(&display->irq.lock); > @@ -2463,6 +2489,19 @@ void intel_display_irq_init(struct intel_display *display) > > INIT_WORK(&display->irq.vblank_notify_work, > intel_display_vblank_notify_work); > + > + if (DISPLAY_VER(display) >= 11) > + display->irq.funcs = &gen11_display_irq_funcs; > + else if (display->platform.cherryview || display->platform.valleyview) > + display->irq.funcs = &vlv_display_irq_funcs; > + else if (DISPLAY_VER(display) >= 8) > + display->irq.funcs = &gen8_display_irq_funcs; > + else if (DISPLAY_VER(display) >= 5) > + display->irq.funcs = &ilk_display_irq_funcs; > + else if (DISPLAY_VER(display) == 4) > + display->irq.funcs = &i965_display_irq_funcs; > + else > + display->irq.funcs = &i915_display_irq_funcs; > } > > struct intel_display_irq_snapshot { > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.h b/drivers/gpu/drm/i915/display/intel_display_irq.h > index d25b9ea4272b..21b2145656cd 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_irq.h > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.h > @@ -58,11 +58,7 @@ void gen11_display_irq_handler(struct intel_display *display); > u32 gen11_gu_misc_irq_ack(struct intel_display *display, const u32 master_ctl); > void gen11_gu_misc_irq_handler(struct intel_display *display, const u32 iir); > > -void i9xx_display_irq_reset(struct intel_display *display); > -void ilk_display_irq_reset(struct intel_display *display); > -void vlv_display_irq_reset(struct intel_display *display); > -void gen8_display_irq_reset(struct intel_display *display); > -void gen11_display_irq_reset(struct intel_display *display); > +void intel_display_irq_reset(struct intel_display *display); > > u32 i9xx_display_irq_enable_mask(struct intel_display *display); > void i915_display_irq_postinstall(struct intel_display *display); > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index ef9eadf38a53..c4f56a869910 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -640,7 +640,7 @@ static void ilk_irq_reset(struct drm_i915_private *dev_priv) > struct intel_display *display = dev_priv->display; > > /* The master interrupt enable is in DEIER, reset display irq first */ > - ilk_display_irq_reset(display); > + intel_display_irq_reset(display); > gen5_gt_irq_reset(to_gt(dev_priv)); > } > > @@ -653,7 +653,7 @@ static void valleyview_irq_reset(struct drm_i915_private *dev_priv) > > gen5_gt_irq_reset(to_gt(dev_priv)); > > - vlv_display_irq_reset(display); > + intel_display_irq_reset(display); > } > > static void gen8_irq_reset(struct drm_i915_private *dev_priv) > @@ -664,7 +664,7 @@ static void gen8_irq_reset(struct drm_i915_private *dev_priv) > gen8_master_intr_disable(intel_uncore_regs(uncore)); > > gen8_gt_irq_reset(to_gt(dev_priv)); > - gen8_display_irq_reset(display); > + intel_display_irq_reset(display); > gen2_irq_reset(uncore, GEN8_PCU_IRQ_REGS); > } > > @@ -677,7 +677,7 @@ static void gen11_irq_reset(struct drm_i915_private *dev_priv) > gen11_master_intr_disable(intel_uncore_regs(&dev_priv->uncore)); > > gen11_gt_irq_reset(gt); > - gen11_display_irq_reset(display); > + intel_display_irq_reset(display); > > gen2_irq_reset(uncore, GEN11_GU_MISC_IRQ_REGS); > gen2_irq_reset(uncore, GEN8_PCU_IRQ_REGS); > @@ -695,7 +695,7 @@ static void dg1_irq_reset(struct drm_i915_private *dev_priv) > for_each_gt(gt, dev_priv, i) > gen11_gt_irq_reset(gt); > > - gen11_display_irq_reset(display); > + intel_display_irq_reset(display); > > gen2_irq_reset(uncore, GEN11_GU_MISC_IRQ_REGS); > gen2_irq_reset(uncore, GEN8_PCU_IRQ_REGS); > @@ -715,7 +715,7 @@ static void cherryview_irq_reset(struct drm_i915_private *dev_priv) > > gen2_irq_reset(uncore, GEN8_PCU_IRQ_REGS); > > - vlv_display_irq_reset(display); > + intel_display_irq_reset(display); > } > > static void ilk_irq_postinstall(struct drm_i915_private *dev_priv) > @@ -864,7 +864,7 @@ static void i915_irq_reset(struct drm_i915_private *dev_priv) > struct intel_display *display = dev_priv->display; > struct intel_uncore *uncore = &dev_priv->uncore; > > - i9xx_display_irq_reset(display); > + intel_display_irq_reset(display); > > gen2_error_reset(uncore, GEN2_ERROR_REGS); > gen2_irq_reset(uncore, GEN2_IRQ_REGS); > @@ -951,7 +951,7 @@ static void i965_irq_reset(struct drm_i915_private *dev_priv) > struct intel_display *display = dev_priv->display; > struct intel_uncore *uncore = &dev_priv->uncore; > > - i9xx_display_irq_reset(display); > + intel_display_irq_reset(display); > > gen2_error_reset(uncore, GEN2_ERROR_REGS); > gen2_irq_reset(uncore, GEN2_IRQ_REGS); > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index aa73023b7398..ba3225878c61 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -236,7 +236,7 @@ void xe_display_irq_reset(struct xe_device *xe) > if (!xe->info.probe_display) > return; > > - gen11_display_irq_reset(display); > + intel_display_irq_reset(display); > } > > void xe_display_irq_postinstall(struct xe_device *xe) > -- > 2.47.3 -- Ville Syrjälä Intel