From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A286CD8C85 for ; Sat, 6 Jun 2026 06:19:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C44C112D50; Sat, 6 Jun 2026 06:19:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WyxK9saC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F9D0112D4F; Sat, 6 Jun 2026 06:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780726743; x=1812262743; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CP7+C8z3E8+Tt7Fy11CVC1S5hyAJTbWNPe4KzQdOTNo=; b=WyxK9saC1YMTZ8Kv3PPd6NW+z4EZbJH+N6SyCKJbnrvzc5o+ys9ufZVo i3xYQ0FFUB5gGrZEMruGq8StqwfVPnDKw+Ek9lAjZ8yjJPCK+/M1gP+XS Io9f3/B+uNj4ymCCriBNtMH26DwjDWRLqsyia6vp1pjLTPMgu/UQ2FDU3 wDJpdpjgxxyKB0MwtNaiPu+b6bXaInUDnKXSwbsSuvPrvY6GGnE0olZsu f+zM2HvX3yRlJpJ7iaHfJ88BMI7zqLhv/n73IrAwNE3uaMriyQy9Rr2SO SNILgTitVwiZrrvXKXvnUdI+8z4XeQMn1FJudWySHd8wyKjACdT2CK72n g==; X-CSE-ConnectionGUID: 6tqc0SgxRqy9QBoOt0q+Ew== X-CSE-MsgGUID: dwm3NaNmTbaqXFL8UTNeBg== X-IronPort-AV: E=McAfee;i="6800,10657,11808"; a="81460979" X-IronPort-AV: E=Sophos;i="6.24,190,1774335600"; d="scan'208";a="81460979" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 23:19:02 -0700 X-CSE-ConnectionGUID: y3Pm8tDeSleLm3UAdLH3Tw== X-CSE-MsgGUID: n8U0Y8iBRs28JqEXw8qehA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,190,1774335600"; d="scan'208";a="246876848" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 23:19:01 -0700 Date: Sat, 6 Jun 2026 08:18:58 +0200 From: Raag Jadav To: Jonathan Cavitt Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, saurabhg.gupta@intel.com, alex.zuo@intel.com, Michal.Wajdeczko@intel.com Subject: Re: [PATCH v3 5/5] drm/xe/i2c: Report i2c irq handler issue Message-ID: References: <20260605210534.3843211-1-jonathan.cavitt@intel.com> <20260605210534.3843211-6-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605210534.3843211-6-jonathan.cavitt@intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Jun 06, 2026 at 05:05:34AM +0800, Jonathan Cavitt wrote: > Error logging is expected but not included in xe_i2c_irq_handler() for > generic_handle_irq_safe(), so add error logging there. > > This issue was caught by static analysis. > > v2: > - Reword error message (Wajdeczko) > > Signed-off-by: Jonathan Cavitt > Cc: Raag Jadav > Cc: Michal Wajdeczko Reviewed-by: Raag Jadav