Re: [for-CI-v2] drm/i915/mocs: Program MOCS for all engines on init

[Peter Antoine <peter.antoine@intel.com>]

Thanks for tidying up and pushing.
Peter.

On Thu, 14 Apr 2016, Chris Wilson wrote:

> On Wed, Apr 13, 2016 at 03:03:25PM +0100, Chris Wilson wrote:
>> From: Peter Antoine <peter.antoine@intel.com>
>>
>> Allow for the MOCS to be programmed for all engines.
>> Currently we program the MOCS when the first render batch
>> goes through. This works on most platforms but fails on
>> platforms that do not run a render batch early,
>> i.e. headless servers. The patch now programs all initialised engines
>> on init and the RCS is programmed again within the initial batch. This
>> is done for predictable consistency with regards to the hardware
>> context.
>>
>> Hardware context loading sets the values of the MOCS for RCS
>> and L3CC. Programming them from within the batch makes sure that
>> the render context is valid, no matter what the previous state of
>> the saved-context was.
>>
>> v2: posted correct version to the mailing list.
>> v3: moved programming to within engine->init_hw() (Chris Wilson)
>> v4: code formatting and white-space changes. (Chris Wilson)
>>
>> Testcase: igt/gem_mocs_settings
>> Signed-off-by: Peter Antoine <peter.antoine@intel.com>
>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> And pushed, finally. Thanks for the patch and test cases.
> -Chris
>
>

--
    Peter Antoine (Android Graphics Driver Software Engineer)
    ---------------------------------------------------------------------
    Intel Corporation (UK) Limited
    Registered No. 1134945 (England)
    Registered Office: Pipers Way, Swindon SN3 1RJ
    VAT No: 860 2173 47
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx