From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Antoine Subject: Re: [PATCH] drm/i915/sysfs: Adding mocs_state Date: Wed, 4 May 2016 15:51:21 +0100 (BST) Message-ID: References: <1462367783-4342-1-git-send-email-peter.antoine@intel.com> <20160504132306.GB19266@nuc-i3427.alporthouse.com> <20160504134717.GD19266@nuc-i3427.alporthouse.com> <20160504143841.GR4329@intel.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1614171888-1462373484=:3052" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 284E86E165 for ; Wed, 4 May 2016 14:51:50 +0000 (UTC) In-Reply-To: <20160504143841.GR4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-15?Q?Ville_Syrj=E4l=E4?= Cc: "intel-gfx@lists.freedesktop.org" , "Widawsky, Benjamin" List-Id: intel-gfx@lists.freedesktop.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1614171888-1462373484=:3052 Content-Type: TEXT/PLAIN; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sorry Ville, What is SRM? Peter. On Wed, 4 May 2016, Ville Syrj=E4l=E4 wrote: > On Wed, May 04, 2016 at 02:23:35PM +0000, Antoine, Peter wrote: >> No, It's not debug. >> It's for syncing and aligning (and validating) the open-source userspa= ce with the kernel cache policy. > > Why doesn't userspace just use SRM to read registers? The spec gives me > the impression that SRM doesn't care whether the register is privileged > or not. > >> >> As for the name being wrong, I'll change that. >> >> As for the sysfs, would you prefer the following structure: >> >> mocs/size >> mocs/control_state >> mocs/l3cc_state >> >> for the different tables? >> >> Peter. >> >> -----Original Message----- >> From: Chris Wilson [mailto:chris@chris-wilson.co.uk] >> Sent: Wednesday, May 4, 2016 2:47 PM >> To: Antoine, Peter >> Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state >> >> On Wed, May 04, 2016 at 02:32:53PM +0100, Peter Antoine wrote: >>> Will wait for more comments, then will respin with a different commit >>> message. Is the rest of the patch ok? >> >> No, you've put debug information into sysfs. (Also sysfs is one value = per >> file.) sysfs does not match your goal of validation. And you exported = an internal function (get_mocs...) without giving it a proper name. >> -Chris >> >> -- >> Chris Wilson, Intel Open Source Technology Centre >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- Peter Antoine (Android Graphics Driver Software Engineer) --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 --8323329-1614171888-1462373484=:3052 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --8323329-1614171888-1462373484=:3052--