From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 195F8C79FAE for ; Tue, 8 Sep 2026 10:46:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C28F10EB09; Tue, 8 Sep 2026 10:46:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZaVXaVFd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BDDD10EB07 for ; Tue, 8 Sep 2026 10:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788864371; x=1820400371; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=r/l1YoM6RxKXIyIUKiNRzuIxu6GWquA/QjRvwN8HJKc=; b=ZaVXaVFd6+s8rhbvKJE55wkBMhxPl2/yIgZhqp9nMGF0gbyPmbcztc0y MVoyYwVr7eJK7bmDpcGMw2wXy121PC7phhERPG/MwdDTB+jAmdv329AsQ q+R0/5VpHJCKKPgmdLewK0tzUUS+BIN/ljfXJD9BnCUOqcWBR6WeOkKR/ SghdfhjL33jCIvNUVfZwXjHGa/zq2PFgkUIMjBhu3jrAatpXa34O7J+YJ axZV0+KSTUaWGJ0S90KBaLRCja+0Ljpta3lxV2aNx0qbspQswqu9wgi2s DBzIQf1/DlnyDJFA5gP3A18uy3psZ4bw94sVL7rRaIow/vGC/kUSyfa67 w==; X-CSE-ConnectionGUID: JHH03H/gQJWtExZiDdUMnw== X-CSE-MsgGUID: kqDqLZGWTIGSF103T6/sUw== X-IronPort-AV: E=McAfee;i="6800,10657,11899"; a="100421360" X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="100421360" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2026 03:46:10 -0700 X-CSE-ConnectionGUID: mYt1HGNlT6ubu5HZabgTpw== X-CSE-MsgGUID: M8egQ/YUTG26EpMeldSn2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="272890143" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.174]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2026 03:46:07 -0700 Date: Tue, 8 Sep 2026 13:46:04 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Janusz Krzysztofik Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Andi Shyti , Krzysztof Karas , Sebastian Brzezinka , Krzysztof Niemiec , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: Disable not supported reset methods on DG1 0x4905 Message-ID: References: <20260907090249.1348552-2-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260907090249.1348552-2-janusz.krzysztofik@linux.intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Sep 07, 2026 at 10:59:18AM +0200, Janusz Krzysztofik wrote: > DRM CI consistently reports failing device reset attempts on Intel DG1 > discrete graphics adapters. Manual reproduction attempts allowed to > narrow down the scope of that problem to a specific revision of that > hardware, SKU 8086:4905. It has been confirmed that both reset methods > claimed by the device, i.e., flr and bus, suffer from that issue. IIRC the documented workaround for the issue is some kind of magic register write after the FLR to unblock some internal state machine, but the CPU isn't allowed to do that write and instead it has to be performed by the GuC. That means we'd somehow have to reinitialize the GuC very early after the FLR, which sounds rather difficult. > > Since consecutively failing device resets may lead to system hangs, > disable both useless reset methods. A respective CI test will then be > skipped instead of aborting whole CI jobs. > > Suggested-by: Joonas Lahtinen > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/11814 > Reviewed-by: Andi Shyti > Reviewed-by: Krzysztof Karas > Signed-off-by: Janusz Krzysztofik > --- > v2: Fix commit description wording (Andi) > - add Suggested-by: tag missing from v1, > - add collected Reviewed-by: tags. > > drivers/pci/quirks.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index de9bbccda21fd..e55475374c6fd 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3811,6 +3811,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, 0xb005, quirk_no_bus_reset); > */ > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1164, quirk_no_bus_reset); > > +/* Intel DG1 0x4905 may not recover from bus reset */ > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x4905, quirk_no_bus_reset); > + > static void quirk_no_pm_reset(struct pci_dev *dev) > { > /* > @@ -5597,6 +5600,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, quirk_intel_qat_vf_cap); > * AMD Neural Processing Unit 0x1502 0x17f0 > * Intel 82579LM Gigabit Ethernet Controller 0x1502 > * Intel 82579V Gigabit Ethernet Controller 0x1503 > + * Intel DG1 Discrete Graphics Adapter 0x4905 > * Mediatek MT7922 802.11ax PCI Express Wireless Network Adapter > * Mediatek MT7925 802.11be PCI Express Wireless Network Adapter > */ > @@ -5612,6 +5616,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x1502, quirk_no_flr); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x17f0, quirk_no_flr); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x4905, quirk_no_flr); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x0616, quirk_no_flr); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x7925, quirk_no_flr); > > -- > 2.54.0 -- Ville Syrjälä Intel