From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60B7DCA5FAC for ; Tue, 29 Sep 2026 21:27:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E326A10F0FE; Tue, 29 Sep 2026 21:27:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="AuXYWiys"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F2EC10F045; Tue, 29 Sep 2026 21:27:04 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 05DCC438F9; Tue, 29 Sep 2026 21:27:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E47C01F000FF; Tue, 29 Sep 2026 21:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790717223; bh=UE/hrsGxz16noEvTsN6oFLNfwwQHiEcByfB5OGcmBL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AuXYWiysNAPhhIfNjP8ZYoMzz28wGAsy9MhJUSiWTK+jS3vNbjq+jOkYlmWTNoOsJ /UUkdYf29dlXZnmDy77oJ/xeREVywf0mjTpzwC3T+OUXd2XuZaXIryT4LAuObzn7F7 Vxmwnsmp5jMhmTSNyz8fdAPFvER6OEQsZk3oX0x2CH7TT3UTgYYMX+ZGWU0PEAOs/d Q8YFOMcDVgTqBdfrkhID5WApTQMCpeGpNmw8X3juZlznBCn6laxI/HTC3E7vDjLP/z VJh8O7o4+ATddfbbW8YqtReTjOAdkij77hcrn0MkmxrS3x8GhXvN/oDo1b/ZXOVJGC 2O7a8tEh7Qfmw== Date: Tue, 29 Sep 2026 23:27:00 +0200 From: Andi Shyti To: Krzysztof Karas Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jani Nikula , Andi Shyti , Janusz Krzysztofik , Sebastian Brzezinka , Krzysztof Niemiec Subject: Re: [PATCH v3 4/8] drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests Message-ID: References: <20260828100339.72304-1-krzysztof.karas@intel.com> <20260828100339.72304-5-krzysztof.karas@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Krzysztof, On Tue, Sep 29, 2026 at 12:06:15PM +0000, Krzysztof Karas wrote: > On 2026-09-09 at 23:25:55 +0200, Andi Shyti wrote: > > On Thu, Sep 03, 2026 at 12:39:10PM +0000, Krzysztof Karas wrote: > > > On 2026-08-28 at 18:18:35 +0200, Andi Shyti wrote: > > > > On Fri, Aug 28, 2026 at 10:03:35AM +0000, Krzysztof Karas wrote: > > > > > Move away from generic pr prints to device context aware drm > > > > > versions. > > > > > > > > > > Assisted-by: GitHub-Copilot:claude-opus-5 > > > > > > > > what a ride! > > > > > > > > While reviewing everything I was thinking whether it would make > > > > sense to add an i915_err() like xe and gt. > > > The idea makes sense, the question is when to introduce this > > > macro. I have the v4 pretty much ready to send, apart from a few > > > minor issues I have to fix, but I am not against modifying it to > > > accomodate i915_* family of prints. > > > If we agreed on this, then we'd have this new macro ready when > > > we'd be replacing pr_* prints in other parts of the driver. > > > > > > I think it would be worth to keep the series in the oven for a > > > few more days, especially when it is not that critical of a > > > change. What do you think? > > > > yes, i915_* can come later, of course, it's out of the scope of > > this series. > > > > Andi > > I checked again and again these past two weeks for your reply > and none came into my inbox, only for me to notice today that it > was finally pulled by my mailer client recently. I posted > another version of this series, because I was under the > impression that silence meant I should introduce the i915_* > prints. That version was met with disapproval from Jani as well, > so please just ignore v4. > Sorry for the spam. it's also true that I haven't been very active in reviews lately. Are you now preparing a v5? Andi