From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 4/5] drm/i915: Fixup preempt-to-busy vs reset of a virtual request Date: Mon, 23 Sep 2019 14:46:27 +0100 Message-ID: References: <20190921095542.23205-1-chris@chris-wilson.co.uk> <20190921095542.23205-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F0186E916 for ; Mon, 23 Sep 2019 13:46:29 +0000 (UTC) In-Reply-To: <20190921095542.23205-4-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIxLzA5LzIwMTkgMTA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBEdWUgdG8gdGhlIG5h dHVyZSBvZiBwcmVlbXB0LXRvLWJ1c3kgdGhlIGV4ZWNsaXN0cyBhY3RpdmUgdHJhY2tpbmcgYW5k Cj4gdGhlIHNjaGVkdWxlIHF1ZXVlIG1heSBiZWNvbWUgdGVtcG9yYXJpbHkgZGVzeW5jJ2VkIChi ZXR3ZWVuIHJlc3VibWlzc2lvbgo+IHRvIEhXIGFuZCBpdHMgYWNrIGZyb20gSFcpLiBUaGlzIG1l YW5zIHRoYXQgd2UgbWF5IGhhdmUgdW53b3VuZCBhCj4gcmVxdWVzdCBhbmQgcGFzc2VkIGl0IGJh Y2sgdG8gdGhlIHZpcnR1YWwgZW5naW5lLCBidXQgaXQgaXMgc3RpbGwKPiBpbmZsaWdodCBvbiB0 aGUgSFcgYW5kIG1heSBldmVuIHJlc3VsdCBpbiBhIEdQVSBoYW5nLiBJZiB3ZSBkZXRlY3QgdGhh dAo+IEdQVSBoYW5nIGFuZCB0cnkgdG8gcmVzZXQsIHRoZSBoYW5naW5nIHJlcXVlc3QtPmVuZ2lu ZSB3aWxsIG5vIGxvbmdlcgo+IG1hdGNoIHRoZSBjdXJyZW50IGVuZ2luZSwgd2hpY2ggbWVhbnMg dGhhdCB0aGUgcmVxdWVzdCBpcyBub3Qgb24gdGhlCj4gZXhlY2xpc3RzIGFjdGl2ZSBsaXN0IGFu ZCB3ZSBzaG91bGQgbm90IHRyeSB0byBmaW5kIGFuIG9sZGVyIGluY29tcGxldGUKPiByZXF1ZXN0 LiBHaXZlbiB0aGF0IHdlIGhhdmUgZGVkdWNlZCB0aGlzIG11c3QgYmUgYSByZXF1ZXN0IG9uIGEg dmlydHVhbAo+IGVuZ2luZSwgaXQgaXMgdGhlIHNpbmdsZSBhY3RpdmUgcmVxdWVzdCBpbiB0aGUg Y29udGV4dCBhbmQgc28gbXVzdCBiZQo+IGd1aWx0eSAoYXMgdGhlIGNvbnRleHQgaXMgc3RpbGwg aW5mbGlnaHQsIGl0IGlzIHByZXZlbnRlZCBmcm9tIGJlaW5nCj4gZXhlY3V0ZWQgb24gYW5vdGhl ciBlbmdpbmUgYXMgd2UgcHJvY2VzcyB0aGUgcmVzZXQpLgo+IAo+IEZpeGVzOiAyMmI3YTQyNmJi ZTEgKCJkcm0vaTkxNS9leGVjbGlzdHM6IFByZWVtcHQtdG8tYnVzeSIpCj4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3Vv cHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfbHJjLmMgICB8IDcgKysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfcmVzZXQuYyB8IDQgKy0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2d0L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMK PiBpbmRleCAxYjJiYWNjNjAzMDAuLjNlYWRkMjk0YmNkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2d0L2ludGVsX2xyYy5jCj4gQEAgLTIzMjYsMTEgKzIzMjYsMTQgQEAgc3RhdGljIHZvaWQgcmVz ZXRfY3NiX3BvaW50ZXJzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAo+ICAg c3RhdGljIHN0cnVjdCBpOTE1X3JlcXVlc3QgKmFjdGl2ZV9yZXF1ZXN0KHN0cnVjdCBpOTE1X3Jl cXVlc3QgKnJxKQo+ICAgewo+IC0JY29uc3Qgc3RydWN0IGxpc3RfaGVhZCAqIGNvbnN0IGxpc3Qg PQo+IC0JCSZpOTE1X3JlcXVlc3RfYWN0aXZlX3RpbWVsaW5lKHJxKS0+cmVxdWVzdHM7Cj4gICAJ Y29uc3Qgc3RydWN0IGludGVsX2NvbnRleHQgKiBjb25zdCBjZSA9IHJxLT5od19jb250ZXh0Owo+ ICAgCXN0cnVjdCBpOTE1X3JlcXVlc3QgKmFjdGl2ZSA9IE5VTEw7Cj4gKwlzdHJ1Y3QgbGlzdF9o ZWFkICpsaXN0Owo+ICAgCj4gKwlpZiAoIWk5MTVfcmVxdWVzdF9pc19hY3RpdmUocnEpKSAvKiB1 bndvdW5kLCBidXQgaW5jb21wbGV0ZSEgKi8KCklzIGl0IHRpbWUgdG8gc3RvcmUgdGhlIHZlbmcg cG9pbnRlciBzZXBhcmF0ZWx5IGluIHRoZSByZXF1ZXN0IHNvIHdlIGNhbiAKYWRkIHRoZSBhc3Nl cnQgaGVyZT8gTGlrZSAKR0VNX0JVR19PTighLi4uZW5naW5lX2lzX3ZpcnR1YWwocnEtPm9yaWdf ZW5naW5lKSkgPwoKPiArCQlyZXR1cm4gcnE7Cj4gKwo+ICsJbGlzdCA9ICZpOTE1X3JlcXVlc3Rf YWN0aXZlX3RpbWVsaW5lKHJxKS0+cmVxdWVzdHM7Cj4gICAJbGlzdF9mb3JfZWFjaF9lbnRyeV9m cm9tX3JldmVyc2UocnEsIGxpc3QsIGxpbmspIHsKPiAgIAkJaWYgKGk5MTVfcmVxdWVzdF9jb21w bGV0ZWQocnEpKQo+ICAgCQkJYnJlYWs7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2d0L2ludGVsX3Jlc2V0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9yZXNl dC5jCj4gaW5kZXggODkwNDhjYTg5MjRjLi5hZTY4YzM3ODZmNjMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmVzZXQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2d0L2ludGVsX3Jlc2V0LmMKPiBAQCAtNDIsMTEgKzQyLDEwIEBAIHN0YXRpYyB2b2lk IGVuZ2luZV9za2lwX2NvbnRleHQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICAJc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcnEtPmVuZ2luZTsKPiAgIAlzdHJ1Y3QgaTkxNV9n ZW1fY29udGV4dCAqaHVuZ19jdHggPSBycS0+Z2VtX2NvbnRleHQ7Cj4gICAKPiAtCWxvY2tkZXBf YXNzZXJ0X2hlbGQoJmVuZ2luZS0+YWN0aXZlLmxvY2spOwo+IC0KPiAgIAlpZiAoIWk5MTVfcmVx dWVzdF9pc19hY3RpdmUocnEpKQo+ICAgCQlyZXR1cm47Cj4gICAKPiArCWxvY2tkZXBfYXNzZXJ0 X2hlbGQoJmVuZ2luZS0+YWN0aXZlLmxvY2spOwo+ICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfY29u dGludWUocnEsICZlbmdpbmUtPmFjdGl2ZS5yZXF1ZXN0cywgc2NoZWQubGluaykKPiAgIAkJaWYg KHJxLT5nZW1fY29udGV4dCA9PSBodW5nX2N0eCkKPiAgIAkJCWk5MTVfcmVxdWVzdF9za2lwKHJx LCAtRUlPKTsKPiBAQCAtMTIzLDcgKzEyMiw2IEBAIHZvaWQgX19pOTE1X3JlcXVlc3RfcmVzZXQo c3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsIGJvb2wgZ3VpbHR5KQo+ICAgCQkgIHJxLT5mZW5jZS5z ZXFubywKPiAgIAkJICB5ZXNubyhndWlsdHkpKTsKPiAgIAo+IC0JbG9ja2RlcF9hc3NlcnRfaGVs ZCgmcnEtPmVuZ2luZS0+YWN0aXZlLmxvY2spOwo+ICAgCUdFTV9CVUdfT04oaTkxNV9yZXF1ZXN0 X2NvbXBsZXRlZChycSkpOwo+ICAgCj4gICAJaWYgKGd1aWx0eSkgewo+IAoKUmV2aWV3ZWQtYnk6 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZy dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==