From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4] drm/i915: Handle RC6 counter wrap Date: Thu, 8 Feb 2018 15:49:05 +0000 Message-ID: References: <20180208081842.6190-1-tvrtko.ursulin@linux.intel.com> <20180208154638.23839-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E102389873 for ; Thu, 8 Feb 2018 15:49:08 +0000 (UTC) In-Reply-To: <20180208154638.23839-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzAyLzIwMTggMTU6NDYsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gCj4gV2UgY2FuIGltcGxlbWVu dCBsaW1pdGVkIFJDNiBjb3VudGVyIHdyYXAtYXJvdW5kIHByb3RlY3Rpb24gdW5kZXIgdGhlCj4g YXNzdW1wdGlvbiB0aGF0IGNsaWVudHMgd2lsbCBiZSByZWFkaW5nIHRoaXMgdmFsdWUgbW9yZSBm cmVxdWVudGx5IHRoYW4KPiB0aGUgd3JhcCBwZXJpb2Qgb24gYSBnaXZlbiBwbGF0Zm9ybS4KPiAK PiBXaXRoIHRoZSB0eXBpY2FsIHdyYXAtYXJvdW5kIHBlcmlvZCBiZWluZyB+OTAgbWludXRlcywg ZXZlbiB3aXRoIHRoZQo+IGV4Y2VwdGlvbiBvZiBCYXl0cmFpbCB3aGljaCB3cmFwcyBldmVyeSAx MyBzZWNvbmRzLCB0aGlzIHNvdW5kcyBsaWtlIGEKPiByZWFzb25hYmxlIGFzc3VtcHRpb24uCj4g Cj4gSW1wbGVtZW50YXRpb24gd29ya3MgYnkgc3RvcmluZyBhIDY0LWJpdCBzb2Z0d2FyZSBjb3B5 IG9mIGEgaGFyZHdhcmUgUkM2Cj4gY291bnRlciwgYWxvbmcgd2l0aCB0aGUgcHJldmlvdXMgSFcg Y291bnRlciBzbmFwc2hvdC4gVGhpcyBlbmFibGVzIGl0IHRvCj4gZGV0ZWN0IHdyYXAgaXMgcG9s bGVkIGZyZXF1ZW50bHkgZW5vdWdoIGFuZCBrZWVwIHRoZSBzb2Z0d2FyZSBjb3B5Cj4gbW9ub3Rv bmljYWxseSBpbmNyZW1lbnRpbmcuCj4gCj4gdjI6Cj4gICAqIE1pc3NlZCBHRU42X0dUX0dGWF9S QzZfTE9DS0VEIHdoZW4gY29uc2lkZXJpbmcgc2xvdCBzaXppbmcgYW5kCj4gICAgIGluZGV4aW5n Lgo+ICAgKiBGaXhlZCBvZmYtYnktb25lIGluIHdyYXAtYXJvdW5kIGhhbmRsaW5nLiAoQ2hyaXMg V2lsc29uKQo+IAo+IHYzOgo+ICAgKiBTaW1wbGlmeSBpbmRleCBjaGVja2luZyBieSB1c2luZyB1 bnNpZ25lZCBpbnQuIChDaHJpcyBXaWxzb24pCj4gICAqIEV4cGFuZCB0aGUgY29tbWVudCB0byBl eHBsYWluIHdoeSBpbmRleGluZyB3b3Jrcy4KPiAKPiB2NDoKPiAgICogVXNlIF9faW50MTI4IGlm IHN1cHBvcnRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3Jn L3Nob3dfYnVnLmNnaT9pZD05NDg1Mgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+ICMgdjMKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAg MiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDcyICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDY0IGlu c2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ IGluZGV4IGFkMWZjODQ1Y2QxYi4uMjhhMjY3MWEyNmM3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oCj4gQEAgLTk0Niw2ICs5NDYsOCBAQCBzdHJ1Y3QgaW50ZWxfcnBzIHsKPiAgIAo+ICAg c3RydWN0IGludGVsX3JjNiB7Cj4gICAJYm9vbCBlbmFibGVkOwo+ICsJdTY0IHByZXZfaHdfcmVz aWRlbmN5WzRdOwo+ICsJdTY0IGN1cl9yZXNpZGVuY3lbNF07Cj4gICB9Owo+ICAgCj4gICBzdHJ1 Y3QgaW50ZWxfbGxjX3BzdGF0ZSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXggNDFm MjZhYjQ2NTAxLi4yNGQ5NDIzYzVmOWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBA QCAtOTQxNywxNSArOTQxNywxNiBAQCBzdGF0aWMgdTY0IHZsdl9yZXNpZGVuY3lfcmF3KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkJCSAgICAgY29uc3QgaTkxNV9yZWdf dCByZWcpCj4gICB7Cj4gICAJdTMyIGxvd2VyLCB1cHBlciwgdG1wOwo+IC0JdW5zaWduZWQgbG9u ZyBmbGFnczsKPiAgIAlpbnQgbG9vcCA9IDI7Cj4gICAKPiAtCS8qIFRoZSByZWdpc3RlciBhY2Nl c3NlZCBkbyBub3QgbmVlZCBmb3JjZXdha2UuIFdlIGJvcnJvdwo+ICsJLyoKPiArCSAqIFRoZSBy ZWdpc3RlciBhY2Nlc3NlZCBkbyBub3QgbmVlZCBmb3JjZXdha2UuIFdlIGJvcnJvdwo+ICAgCSAq IHVuY29yZSBsb2NrIHRvIHByZXZlbnQgY29uY3VycmVudCBhY2Nlc3MgdG8gcmFuZ2UgcmVnLgo+ ICAgCSAqLwo+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgZmxh Z3MpOwo+ICsJbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiAg IAo+IC0JLyogdmx2IGFuZCBjaHYgcmVzaWRlbmN5IGNvdW50ZXJzIGFyZSA0MCBiaXRzIGluIHdp ZHRoLgo+ICsJLyoKPiArCSAqIHZsdiBhbmQgY2h2IHJlc2lkZW5jeSBjb3VudGVycyBhcmUgNDAg Yml0cyBpbiB3aWR0aC4KPiAgIAkgKiBXaXRoIGEgY29udHJvbCBiaXQsIHdlIGNhbiBjaG9vc2Ug YmV0d2VlbiB1cHBlciBvciBsb3dlcgo+ICAgCSAqIDMyYml0IHdpbmRvdyBpbnRvIHRoaXMgY291 bnRlci4KPiAgIAkgKgo+IEBAIC05NDQ5LDI5ICs5NDUwLDU0IEBAIHN0YXRpYyB1NjQgdmx2X3Jl c2lkZW5jeV9yYXcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQl1cHBl ciA9IEk5MTVfUkVBRF9GVyhyZWcpOwo+ICAgCX0gd2hpbGUgKHVwcGVyICE9IHRtcCAmJiAtLWxv b3ApOwo+ICAgCj4gLQkvKiBFdmVyeXdoZXJlIGVsc2Ugd2UgYWx3YXlzIHVzZSBWTFZfQ09VTlRF Ul9DT05UUk9MIHdpdGggdGhlCj4gKwkvKgo+ICsJICogRXZlcnl3aGVyZSBlbHNlIHdlIGFsd2F5 cyB1c2UgVkxWX0NPVU5URVJfQ09OVFJPTCB3aXRoIHRoZQo+ICAgCSAqIFZMVl9DT1VOVF9SQU5H RV9ISUdIIGJpdCBzZXQgLSBzbyBpdCBpcyBzYWZlIHRvIGxlYXZlIGl0IHNldAo+ICAgCSAqIG5v dy4KPiAgIAkgKi8KPiAgIAo+IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPnVu Y29yZS5sb2NrLCBmbGFncyk7Cj4gLQo+ICAgCXJldHVybiBsb3dlciB8ICh1NjQpdXBwZXIgPDwg ODsKPiAgIH0KPiAgIAo+ICAgdTY0IGludGVsX3JjNl9yZXNpZGVuY3lfbnMoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJICAgY29uc3QgaTkxNV9yZWdfdCByZWcpCj4g ICB7Cj4gLQl1NjQgdGltZV9odzsKPiArI2lmIElTX0VOQUJMRUQoQ09ORklHX0FSQ0hfU1VQUE9S VFNfSU5UMTI4KQo+ICsJdW5zaWduZWQgX19pbnQxMjggYWNjOwo+ICsjZWxzZQo+ICsJdTY0IGFj YzsKPiArI2VuZGlmCj4gKwl1NjQgdGltZV9odywgcHJldl9odywgb3ZlcmZsb3dfaHc7Cj4gKwl1 bnNpZ25lZCBpbnQgZndfZG9tYWluczsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwl1bnNp Z25lZCBpbnQgaTsKPiAgIAl1MzIgbXVsLCBkaXY7Cj4gICAKPiAgIAlpZiAoIUhBU19SQzYoZGV2 X3ByaXYpKQo+ICAgCQlyZXR1cm4gMDsKPiAgIAo+ICsJLyoKPiArCSAqIFN0b3JlIHByZXZpb3Vz IGh3IGNvdW50ZXIgdmFsdWVzIGZvciBjb3VudGVyIHdyYXAtYXJvdW5kIGhhbmRsaW5nLgo+ICsJ ICoKPiArCSAqIFRoZXJlIGFyZSBvbmx5IGZvdXIgaW50ZXJlc3RpbmcgcmVnaXN0ZXJzIGFuZCB0 aGV5IGxpdmUgbmV4dCB0byBlYWNoCj4gKwkgKiBvdGhlciBzbyB3ZSBjYW4gdXNlIHRoZSByZWxh dGl2ZSBhZGRyZXNzLCBjb21wYXJlZCB0byB0aGUgc21hbGxlc3QKPiArCSAqIG9uZSBhcyB0aGUg aW5kZXggaW50byBkcml2ZXIgc3RvcmFnZS4KPiArCSAqLwo+ICsJaSA9IChpOTE1X21taW9fcmVn X29mZnNldChyZWcpIC0KPiArCSAgICAgaTkxNV9tbWlvX3JlZ19vZmZzZXQoR0VONl9HVF9HRlhf UkM2X0xPQ0tFRCkpIC8gc2l6ZW9mKHUzMik7Cj4gKwlpZiAoV0FSTl9PTl9PTkNFKGkgPj0gQVJS QVlfU0laRShkZXZfcHJpdi0+Z3RfcG0ucmM2LmN1cl9yZXNpZGVuY3kpKSkKPiArCQlyZXR1cm4g MDsKPiArCj4gKwlmd19kb21haW5zID0gaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9mb3JfcmVnKGRl dl9wcml2LCByZWcsIEZXX1JFR19SRUFEKTsKPiArCj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2 X3ByaXYtPnVuY29yZS5sb2NrLCBmbGFncyk7Cj4gKwlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX2dl dF9fbG9ja2VkKGRldl9wcml2LCBmd19kb21haW5zKTsKPiArCj4gICAJLyogT24gVkxWIGFuZCBD SFYsIHJlc2lkZW5jeSB0aW1lIGlzIGluIENaIHVuaXRzIHJhdGhlciB0aGFuIDEuMjh1cyAqLwo+ ICAgCWlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2 KSkgewo+ICAgCQltdWwgPSAxMDAwMDAwOwo+ICAgCQlkaXYgPSBkZXZfcHJpdi0+Y3pjbGtfZnJl cTsKPiArCQlvdmVyZmxvd19odyA9IEJJVF9VTEwoNDApOwo+ICAgCQl0aW1lX2h3ID0gdmx2X3Jl c2lkZW5jeV9yYXcoZGV2X3ByaXYsIHJlZyk7Cj4gICAJfSBlbHNlIHsKPiAgIAkJLyogODMzLjMz bnMgdW5pdHMgb24gR2VuOUxQLCAxLjI4dXMgZWxzZXdoZXJlLiAqLwo+IEBAIC05NDgzLDEwICs5 NTA5LDM2IEBAIHU2NCBpbnRlbF9yYzZfcmVzaWRlbmN5X25zKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAgIAkJCWRpdiA9IDE7Cj4gICAJCX0KPiAgIAo+IC0JCXRpbWVfaHcg PSBJOTE1X1JFQUQocmVnKTsKPiArCQlvdmVyZmxvd19odyA9IEJJVF9VTEwoMzIpOwo+ICsJCXRp bWVfaHcgPSBJOTE1X1JFQURfRlcocmVnKTsKPiAgIAl9Cj4gICAKPiAtCXJldHVybiBESVZfUk9V TkRfVVBfVUxMKHRpbWVfaHcgKiBtdWwsIGRpdik7Cj4gKwkvKgo+ICsJICogQ291bnRlciB3cmFw IGhhbmRsaW5nLgo+ICsJICoKPiArCSAqIEJ1dCByZWx5aW5nIG9uIGEgc3VmZmljaWVudCBmcmVx dWVuY3kgb2YgcXVlcmllcyBvdGhlcndpc2UgY291bnRlcnMKPiArCSAqIGNhbiBzdGlsbCB3cmFw Lgo+ICsJICovCj4gKwlwcmV2X2h3ID0gZGV2X3ByaXYtPmd0X3BtLnJjNi5wcmV2X2h3X3Jlc2lk ZW5jeVtpXTsKPiArCWRldl9wcml2LT5ndF9wbS5yYzYucHJldl9od19yZXNpZGVuY3lbaV0gPSB0 aW1lX2h3Owo+ICsKPiArCS8qIFJDNiBkZWx0YSBmcm9tIGxhc3Qgc2FtcGxlLiAqLwo+ICsJaWYg KHRpbWVfaHcgPj0gcHJldl9odykKPiArCQl0aW1lX2h3IC09IHByZXZfaHc7Cj4gKwllbHNlCj4g KwkJdGltZV9odyArPSBvdmVyZmxvd19odyAtIHByZXZfaHc7Cj4gKwo+ICsJLyogQWRkIGRlbHRh IHRvIFJDNiBleHRlbmRlZCByYXcgZHJpdmVyIGNvcHkuICovCj4gKwl0aW1lX2h3ICs9IGRldl9w cml2LT5ndF9wbS5yYzYuY3VyX3Jlc2lkZW5jeVtpXTsKPiArCWRldl9wcml2LT5ndF9wbS5yYzYu Y3VyX3Jlc2lkZW5jeVtpXSA9IHRpbWVfaHc7Cj4gKwo+ICsJaW50ZWxfdW5jb3JlX2ZvcmNld2Fr ZV9wdXRfX2xvY2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7Cj4gKwlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGZsYWdzKTsKPiArCj4gKwlhY2MgPSB0aW1l X2h3Owo+ICsJYWNjICo9IG11bDsKPiArCj4gKwlyZXR1cm4gRElWX1JPVU5EX1VQX1VMTChhY2Ms IGRpdik7CgpOb3BlLCB0aGlzIGNhc3RzIHRvIDY0LWJpdCBiZWZvcmUgZGl2aXNpb24uLgoKUmVn YXJkcywKClR2cnRrbwoKPiAgIH0KPiAgIAo+ICAgdTMyIGludGVsX2dldF9jYWdmKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIHJwc3RhdCkKPiAKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==