From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A2FC00454 for ; Wed, 11 Dec 2019 16:13:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4428C206A5 for ; Wed, 11 Dec 2019 16:13:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4428C206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7AFF6EB7A; Wed, 11 Dec 2019 16:13:33 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB6A86EB7A for ; Wed, 11 Dec 2019 16:13:32 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:13:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="414906142" Received: from vbacanux-wtg.ger.corp.intel.com (HELO [10.249.32.158]) ([10.249.32.158]) by fmsmga006.fm.intel.com with ESMTP; 11 Dec 2019 08:13:31 -0800 To: Venkata Sandeep Dhanalakota , intel-gfx@lists.freedesktop.org References: <20191211160724.26467-1-venkata.s.dhanalakota@intel.com> From: Lionel Landwerlin Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: Date: Wed, 11 Dec 2019 18:13:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191211160724.26467-1-venkata.s.dhanalakota@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/perf: Register sysctl path globally X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chris.p.wilson@intel.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/12/2019 18:07, Venkata Sandeep Dhanalakota wrote: > We do not require to register the sysctl paths per instance, > so making registration global. > > Cc: Sudeep Dutt > Cc: Rodrigo Vivi > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Jani Nikula > Signed-off-by: Venkata Sandeep Dhanalakota Not sure what the pattern should be like for global settings like this one. Anyway it's definitely required going forward : Reviewed-by: Lionel Landwerlin Thanks! > --- > drivers/gpu/drm/i915/i915_perf.c | 10 ++++++++-- > drivers/gpu/drm/i915/i915_perf_types.h | 1 - > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index 8d2e37949f46..426d04214a5d 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -387,6 +387,8 @@ struct i915_oa_config_bo { > struct i915_vma *vma; > }; > > +static struct ctl_table_header *sysctl_header; > + > static enum hrtimer_restart oa_poll_check_timer_cb(struct hrtimer *hrtimer); > > void i915_oa_config_release(struct kref *ref) > @@ -4345,7 +4347,8 @@ void i915_perf_init(struct drm_i915_private *i915) > > oa_sample_rate_hard_limit = 1000 * > (RUNTIME_INFO(i915)->cs_timestamp_frequency_khz / 2); > - perf->sysctl_header = register_sysctl_table(dev_root); > + if (!sysctl_header) > + sysctl_header = register_sysctl_table(dev_root); > > mutex_init(&perf->metrics_lock); > idr_init(&perf->metrics_idr); > @@ -4395,7 +4398,10 @@ void i915_perf_fini(struct drm_i915_private *i915) > idr_for_each(&perf->metrics_idr, destroy_config, perf); > idr_destroy(&perf->metrics_idr); > > - unregister_sysctl_table(perf->sysctl_header); > + if (sysctl_header) { > + unregister_sysctl_table(sysctl_header); > + sysctl_header = NULL; > + } > > memset(&perf->ops, 0, sizeof(perf->ops)); > perf->i915 = NULL; > diff --git a/drivers/gpu/drm/i915/i915_perf_types.h b/drivers/gpu/drm/i915/i915_perf_types.h > index 74ddc20a0d37..45e581455f5d 100644 > --- a/drivers/gpu/drm/i915/i915_perf_types.h > +++ b/drivers/gpu/drm/i915/i915_perf_types.h > @@ -380,7 +380,6 @@ struct i915_perf { > struct drm_i915_private *i915; > > struct kobject *metrics_kobj; > - struct ctl_table_header *sysctl_header; > > /* > * Lock associated with adding/modifying/removing OA configs _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx