From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 1/5] drm/i915: Report both waiters and success from intel_engine_wakeup() Date: Mon, 27 Feb 2017 10:03:32 +0000 Message-ID: References: <20170224180149.8737-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E65296E01C for ; Mon, 27 Feb 2017 10:03:55 +0000 (UTC) In-Reply-To: <20170224180149.8737-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzAyLzIwMTcgMTg6MDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgdHdvIHVzZXJz IG9mIHRoZSByZXR1cm4gdmFsdWUgZnJvbSBpbnRlbF9lbmdpbmVfd2FrZXVwKCkgYXJlCj4gZXhw ZWN0aW5nIGRpZmZlcmVudCByZXN1bHRzLiBJbiB0aGUgYnJlYWRjcnVtYnMgaGFuZ2NoZWNrLCB3 ZSBhcmUgdXNpbmcKPiBpdCB0byBkZXRlcm1pbmUgd2hldGhlciB3YWtlX3VwX3Byb2Nlc3MoKSBk ZXRlY3RlZCB0aGUgd2FpdGVyIHdhcwo+IGN1cnJlbnRseSBydW5uaW5nIChhbmQgaWYgc28gd2Ug cHJlc3VtZSB0aGF0IGl0IGhhc24ndCB5ZXQgbWlzc2VkIHRoZQo+IGludGVycnVwdCkuIEhvd2V2 ZXIsIGluIHRoZSBmYWtlX2lycSBwYXRoLCB3ZSBhcmUgdXNpbmcgdGhlIHJldHVybiB2YWx1ZQo+ IGFzIGEgY2hlY2sgYXMgdG8gd2hldGhlciB0aGVyZSBhcmUgYW55IHdhaXRlcnMsIGFuZCBzbyB3 ZSBtYXkKPiBpbmNvcnJlY3RseSBzdG9wIHRoZSBmYWtlLWlycSBpZiB0aGF0IHdhaXRlciB3YXMg Y3VycmVudGx5IHJ1bm5pbmcuCj4KPiBUbyBoYW5kbGUgdGhlIHR3byBkaWZmZXJlbnQgbmVlZHMs IHJldHVybiBib3RoIGJpdHMgb2YgaW5mb3JtYXRpb24hCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9w cGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2JyZWFkY3J1bWJzLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCAgfCAyNiArKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDI0IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFk Y3J1bWJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5k ZXggMDI3YzkzZTM0Yzk3Li42NGUxYjBjMmQ4YjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtMjYsNiArMjYsMzIgQEAKPgo+ICAjaW5jbHVkZSAi aTkxNV9kcnYuaCIKPgo+ICt1bnNpZ25lZCBpbnQgaW50ZWxfZW5naW5lX3dha2V1cChzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCgpIb3cgY29tZSB5b3UgZGVjaWRlZCB0byB1bi1pbmxp bmUgaXQ/IENoYW5nZXMgc2hvdWxkbid0IGhhdmUgbWFkZSBhIGJpZyAKZGlmZmVyZW5jZSB0byBp dHMgc2l6ZSBJIHdvdWxkIGhhdmUgdGhvdWdodC4KCj4gK3sKPiArCXVuc2lnbmVkIGludCByZXQg PSAwOwoKT3B0aW9uYWwgYmlrZXNoZWQgLSBtYXliZSBjYWxsIGl0IHJlcyBvciBzb21ldGhpbmcs IHNpbmNlIHJldCBpcyB1c3VhbGx5IAp1c2VkIGZvciA8IDAgfHwgMC4KCj4gKwo+ICsJLyogTm90 ZSB0aGF0IGZvciB0aGlzIG5vdCB0byBkYW5nZXJvdXNseSBjaGFzZSBhIGRhbmdsaW5nIHBvaW50 ZXIsCj4gKwkgKiB3ZSBtdXN0IGhvbGQgdGhlIHJjdV9yZWFkX2xvY2sgaGVyZS4KPiArCSAqCj4g KwkgKiBBbHNvIG5vdGUgdGhhdCB0c2sgaXMgbGlrZWx5IHRvIGJlIGluICFUQVNLX1JVTk5JTkcg c3RhdGUgc28gYW4KPiArCSAqIGVhcmx5IHRlc3QgZm9yIHRzay0+c3RhdGUgIT0gVEFTS19SVU5O SU5HIGJlZm9yZSB3YWtlX3VwX3Byb2Nlc3MoKQo+ICsJICogaXMgdW5saWtlbHkgdG8gYmUgYmVu ZWZpY2lhbC4KPiArCSAqLwo+ICsJaWYgKGludGVsX2VuZ2luZV9oYXNfd2FpdGVyKGVuZ2luZSkp IHsKPiArCQlzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRzazsKPiArCj4gKwkJcmV0ID0gRU5HSU5FX1dB S0VVUF9XQUlURVI7Cj4gKwo+ICsJCXJjdV9yZWFkX2xvY2soKTsKPiArCQl0c2sgPSByY3VfZGVy ZWZlcmVuY2UoZW5naW5lLT5icmVhZGNydW1icy5pcnFfc2Vxbm9fYmgpOwo+ICsJCWlmICh0c2sg JiYgIXdha2VfdXBfcHJvY2Vzcyh0c2spKQo+ICsJCQlyZXQgfD0gRU5HSU5FX1dBS0VVUF9BQ1RJ VkU7Cj4gKwkJcmN1X3JlYWRfdW5sb2NrKCk7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiAr fQo+ICsKPiAgc3RhdGljIHVuc2lnbmVkIGxvbmcgd2FpdF90aW1lb3V0KHZvaWQpCj4gIHsKPiAg CXJldHVybiByb3VuZF9qaWZmaWVzX3VwKGppZmZpZXMgKyBEUk1fSTkxNV9IQU5HQ0hFQ0tfSklG RklFUyk7Cj4gQEAgLTQ5LDcgKzc1LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfYnJlYWRjcnVtYnNf aGFuZ2NoZWNrKHVuc2lnbmVkIGxvbmcgZGF0YSkKPiAgCSAqIHRvIHByb2Nlc3MgdGhlIHBlbmRp bmcgaW50ZXJydXB0IChlLmcsIGxvdyBwcmlvcml0eSB0YXNrIG9uIGEgbG9hZGVkCj4gIAkgKiBz eXN0ZW0pIGFuZCB3YWl0IHVudGlsIGl0IHNsZWVwcyBiZWZvcmUgZGVjbGFyaW5nIGEgbWlzc2Vk IGludGVycnVwdC4KPiAgCSAqLwo+IC0JaWYgKCFpbnRlbF9lbmdpbmVfd2FrZXVwKGVuZ2luZSkp IHsKPiArCWlmIChpbnRlbF9lbmdpbmVfd2FrZXVwKGVuZ2luZSkgJiBFTkdJTkVfV0FLRVVQX0FD VElWRSkgewo+ICAJCW1vZF90aW1lcigmYi0+aGFuZ2NoZWNrLCB3YWl0X3RpbWVvdXQoKSk7Cj4g IAkJcmV0dXJuOwo+ICAJfQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgK PiBpbmRleCAwZjI5ZTA3YTk1ODEuLjdkNzUzZGMxYjg5ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtNjQyLDI5ICs2NDIsOSBAQCBzdGF0aWMgaW5s aW5lIGJvb2wgaW50ZWxfZW5naW5lX2hhc193YWl0ZXIoY29uc3Qgc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+ICAJcmV0dXJuIHJjdV9hY2Nlc3NfcG9pbnRlcihlbmdpbmUtPmJyZWFk Y3J1bWJzLmlycV9zZXFub19iaCk7Cj4gIH0KPgo+IC1zdGF0aWMgaW5saW5lIGJvb2wgaW50ZWxf ZW5naW5lX3dha2V1cChjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gLXsK PiAtCWJvb2wgd2FrZXVwID0gZmFsc2U7Cj4gLQo+IC0JLyogTm90ZSB0aGF0IGZvciB0aGlzIG5v dCB0byBkYW5nZXJvdXNseSBjaGFzZSBhIGRhbmdsaW5nIHBvaW50ZXIsCj4gLQkgKiB3ZSBtdXN0 IGhvbGQgdGhlIHJjdV9yZWFkX2xvY2sgaGVyZS4KPiAtCSAqCj4gLQkgKiBBbHNvIG5vdGUgdGhh dCB0c2sgaXMgbGlrZWx5IHRvIGJlIGluICFUQVNLX1JVTk5JTkcgc3RhdGUgc28gYW4KPiAtCSAq IGVhcmx5IHRlc3QgZm9yIHRzay0+c3RhdGUgIT0gVEFTS19SVU5OSU5HIGJlZm9yZSB3YWtlX3Vw X3Byb2Nlc3MoKQo+IC0JICogaXMgdW5saWtlbHkgdG8gYmUgYmVuZWZpY2lhbC4KPiAtCSAqLwo+ IC0JaWYgKGludGVsX2VuZ2luZV9oYXNfd2FpdGVyKGVuZ2luZSkpIHsKPiAtCQlzdHJ1Y3QgdGFz a19zdHJ1Y3QgKnRzazsKPiAtCj4gLQkJcmN1X3JlYWRfbG9jaygpOwo+IC0JCXRzayA9IHJjdV9k ZXJlZmVyZW5jZShlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9zZXFub19iaCk7Cj4gLQkJaWYgKHRz aykKPiAtCQkJd2FrZXVwID0gd2FrZV91cF9wcm9jZXNzKHRzayk7Cj4gLQkJcmN1X3JlYWRfdW5s b2NrKCk7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIHdha2V1cDsKPiAtfQo+ICt1bnNpZ25lZCBpbnQg aW50ZWxfZW5naW5lX3dha2V1cChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICsj ZGVmaW5lIEVOR0lORV9XQUtFVVBfV0FJVEVSIEJJVCgwKQo+ICsjZGVmaW5lIEVOR0lORV9XQUtF VVBfQUNUSVZFIEJJVCgxKQo+Cj4gIHZvaWQgaW50ZWxfZW5naW5lX3Jlc2V0X2JyZWFkY3J1bWJz KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4gIHZvaWQgaW50ZWxfZW5naW5lX2Zp bmlfYnJlYWRjcnVtYnMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKTsKPgoKUmV2aWV3 ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRz LAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK