On Tue, 30 Sep 2025, Hogander, Jouni wrote: > On Mon, 2025-09-15 at 16:19 +0200, Grzelak, Michal wrote: >> There is no reason in debugfs why PSR has been disabled. Currently, >> without this information, IGT tests cannot decide whether PSR has >> been disabled on purpose or was it abnormal behavior. Because of it, >> the status of the test cannot be decided correctly. >> >> Add no_psr_reason field into struct intel_psr. Add no_psr_reason >> into struct intel_crtc_state to prevent staying out of sync when >> _psr_compute_config is not using computed state. Write the reason, >> e.g. PSR setup timing not met, into proper PSR debugfs file. Update >> the reason from new_crtc_state in intel_psr_pre_plane_update. Extend >> format of debugfs file to have reason when it is non-NULL. Clean the >> reason when PSR is activated. >> >> Refactor intel_psr_post_plane_update to use no_psr_reason along >> keep_disabled. >> >> Changelog: >> v10->v11 >> - update the reason from new_crtc_state instead of old_crtc_state >> [Jouni] >> >> v9->v10 >> - log reason into intel_crtc_state instead of intel_dp->psr [Jouni] >> - remove clearing no_psr_reason in intel_psr_compute_config [Jouni] >> - change update of no_psr_reason into more readable form [Jouni] >> >> v8->v9 >> - add no_psr_reason into struct intel_crtc_state [Jouni] >> - update the reason in intel_psr_pre_plane_update [Jouni] >> - elaborate on motivation of the feature in commit message >> [Sebastian] >> - copy changelog to commit message [Sebastian] >> >> v7->v8 >> - reset no_psr_reason at the begin of intel_psr_compute_config >> [Jouni] >> - restore keep_disabled [Jouni] >> - drop setting "Sink not reliable" [Jouni] >> - add WA number [Jouni] >> - if non-NULL, write no_psr_reason after PSR mode [Jouni] >> >> v6->v7 >> - rebase onto new drm-tip >> >> v5->v6 >> - move setting no_psr_reason to intel_psr_post_plane_update [Jouni] >> - remove setting no_psr_reason when disabling PSR is temporary >> [Jouni] >> >> v4->v5 >> - fix indentation errors from checkpatch >> >> v3->v4 >> - change format of logging workaround #1136 >> >> v2->v3 >> - change reason description to be more specific [Mika] >> - remove BSpecs number & WA number from being written into >> no_psr_reason >> - replace spaces with tabs >> >> v1->v2 >> - set other reasons than "PSR setup timing not met" >> - clear no_psr_reason when activating PSR. >> >> Reviewed-by: Sebastian Brzezinka >> Signed-off-by: Michał Grzelak > > Hopefully you have time and interest to extend this. Anyways this one > together with your igt patch is already solving one problem for us: > > Reviewed-by: Jouni Högander > Thanks Jouni for your review and all the comments throughout the series. Certainly there is more work to do, e.g. adding reason for no PSR2, or maybe even creating separate debugfs interface for no_psr_reason. For now, I will just stick to resending the patch with your R-B; this is also in order to retrigger CI run, because apparently since the IGT got merged, the Test-with: tag tripped Patchwork and no testing has been done. BR, Michał