From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: fix noderef.cocci warnings Date: Fri, 12 Jan 2018 14:28:01 +0000 Message-ID: References: <201801122113.PamSF4io%fengguang.wu@intel.com> <20180112133116.GA14498@lkp-ib03> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180112133116.GA14498@lkp-ib03> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: kbuild test robot , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@01.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org On 12/01/2018 13:31, kbuild test robot wrote: > From: Fengguang Wu > > drivers/gpu/drm/i915/i915_pmu.c:795:34-40: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > Fixes: 109ec558370f ("drm/i915/pmu: Only enumerate available counters in sysfs") > Signed-off-by: Fengguang Wu > --- > > i915_pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -792,7 +792,7 @@ create_event_attributes(struct drm_i915_ > goto err_alloc; > > /* Max one pointer of each attribute type plus a termination entry. */ > - attr = kzalloc((count * 2 + 1) * sizeof(attr), GFP_KERNEL); > + attr = kzalloc((count * 2 + 1) * sizeof(*attr), GFP_KERNEL); > if (!attr) > goto err_alloc; > Luckily it is the same size so no actual bug, but fix is still valid. Will merge it once it passes CI, thanks! Reviewed-by: Tvrtko Ursulin Regards, Tvrtko