From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33B8C4338F for ; Thu, 12 Aug 2021 06:29:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D15160F91 for ; Thu, 12 Aug 2021 06:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D15160F91 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACDAF6E24E; Thu, 12 Aug 2021 06:29:18 +0000 (UTC) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 725FA6E24E for ; Thu, 12 Aug 2021 06:29:16 +0000 (UTC) Received: from [192.168.50.13] (mobile-user-2e84bb-128.dhcp.inet.fi [46.132.187.128]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 7DA9E40C9B; Thu, 12 Aug 2021 06:29:14 +0000 (UTC) From: Timo Aaltonen To: =?UTF-8?Q?Jos=c3=a9_Roberto_de_Souza?= , intel-gfx@lists.freedesktop.org References: <20210708211827.288601-1-jose.souza@intel.com> <20210708211827.288601-2-jose.souza@intel.com> Message-ID: Date: Thu, 12 Aug 2021 09:29:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12.8.2021 6.27, Timo Aaltonen wrote: > On 9.7.2021 0.18, José Roberto de Souza wrote: >> Same bit was required for Wa_14012131227 in DG1 now it is also >> required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. >> >> Cc: Gwan-gyeong Mun >> Signed-off-by: José Roberto de Souza >> --- >>   drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++++++ >>   1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c >> b/drivers/gpu/drm/i915/gt/intel_workarounds.c >> index e5e3f820074a9..c346229e2be00 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c >> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c >> @@ -670,6 +670,13 @@ static void gen12_ctx_workarounds_init(struct >> intel_engine_cs *engine, >>              FF_MODE2_GS_TIMER_MASK, >>              FF_MODE2_GS_TIMER_224, >>              0); >> + >> +    /* >> +     * Wa_14012131227:dg1 >> +     * Wa_1508744258:tgl,rkl,dg1,adl-s,adl-p >> +     */ >> +    wa_masked_en(wal, GEN7_COMMON_SLICE_CHICKEN1, >> +             GEN9_RHWO_OPTIMIZATION_DISABLE); >>   } >>   static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine, >> > > Hi, I don't see this (or patches 3, 4) in drm-intel-next, are they not > needed anymore? but is in drm-intel-gt-next.. -- t