From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E905CC433DB for ; Wed, 6 Jan 2021 17:22:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C2423106 for ; Wed, 6 Jan 2021 17:22:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C2423106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EA7F89C83; Wed, 6 Jan 2021 17:22:29 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BF7589C83 for ; Wed, 6 Jan 2021 17:22:27 +0000 (UTC) IronPort-SDR: X0FgwuHK+qZB/JRHQJ47d7pCCnbg0TjkujiJyfTrH0sEHf0lVenDBnY2XHLFrjmpcJs3cX44QJ u+5cw2WCuzxA== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="238856376" X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="238856376" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 09:22:26 -0800 IronPort-SDR: T6iU9JhueIcbhf2SWsItyhCzHCaJzQzC0fFesHWLaoFTw0snhME0rZw6Cp/d39AMQ+9UngCgTf C5kwUMXZtDmw== X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="497215797" Received: from dceraolo-mobl.amr.corp.intel.com (HELO [10.212.178.138]) ([10.212.178.138]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 09:22:26 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210105231947.31235-1-daniele.ceraolospurio@intel.com> <20210105231947.31235-5-daniele.ceraolospurio@intel.com> <160989494374.14894.15158476900955777220@build.alporthouse.com> <8010f48e-94cf-699b-b3f2-b3eae3753cdf@intel.com> <160990259521.22606.5618391021082649871@build.alporthouse.com> From: Daniele Ceraolo Spurio Message-ID: Date: Wed, 6 Jan 2021 09:22:26 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <160990259521.22606.5618391021082649871@build.alporthouse.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: stop calling execlists_set_default_submission X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 1/5/2021 7:09 PM, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio (2021-01-06 02:38:09) >> >> On 1/5/2021 5:02 PM, Chris Wilson wrote: >>> Quoting Daniele Ceraolo Spurio (2021-01-05 23:19:46) >>>> Initialize all required entries from guc_set_default_submission, instead >>>> of calling the execlists function. The previously inherited setup has >>>> been copied over from the execlist code and simplified by removing the >>>> execlists submission-specific parts. >>>> >>>> Signed-off-by: Daniele Ceraolo Spurio >>>> Cc: Matthew Brost >>>> Cc: John Harrison >>>> --- >>>> + if (INTEL_GEN(engine->i915) >= 12) >>>> + engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO; >>> We should probably lift this to intel_engine_setup(). >> GuC requires a more extensive usage of the relative mmio stuff, given >> that it picks which engine to submit to when using virtual engines, so >> I'm not sure if the support is going to look exactly the same for both >> back-ends. There is an old patch from John H to rework the relative mmio >> (https://patchwork.freedesktop.org/patch/332558/), which will have to >> land in some form as part of the GuC submission re-enabling. I'd prefer >> to wait for that to land before moving this flag. > Whether or not LR* take the flag is independent of the submission > backend. As to when to use the flag, I think that patch needs a lot more > refinement. it definitely does. I'll lift this up for now, we can reconsider later if needed. Daniele > I915_ENGINE_HAS_RELATIVE_MMIO is the odd-one-out in the flags atm as it > reflects HW capability. > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx