From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Check whether the output is running after completing the modeswitch Date: Tue, 29 Mar 2011 18:17:57 +0100 Message-ID: References: <1301406226-13396-1-git-send-email-chris@chris-wilson.co.uk> <87pqp93lem.fsf@pollan.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 42CF49EF22 for ; Tue, 29 Mar 2011 10:18:01 -0700 (PDT) In-Reply-To: <87pqp93lem.fsf@pollan.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 29 Mar 2011 10:07:45 -0700, Eric Anholt wrote: > On Tue, 29 Mar 2011 14:43:46 +0100, Chris Wilson wrote: > > Proof-of-concept sanity check to see if we did successfully enable the > > pipe. Without a means of report back the error and forcibly reverting back > > to the previous configuration, the error message is a little useless. > > I still like it -- it's something that could be watched for in testing, > at least. Did you find that some failures to successfully program modes > not incrementing scanlines? The external DP at least seems to take some time before it is up and running. Of course, that could also be an artefact of a bug within our modesetting... -Chris -- Chris Wilson, Intel Open Source Technology Centre