Re: [PATCH 2/2] drm/i915/crt: Explicitly return false if connected to a digital monitor

[Chris Wilson <chris@chris-wilson.co.uk>]

On Mon, 04 Apr 2011 08:09:42 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Mon,  4 Apr 2011 07:26:45 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> > Rather than proceed on to the next test, return the result from
> > detecting a connection but to a digital panel and include some debug
> > output as to why.
> 
> I'm worried that this will falsely reject some monitors with broken EDID
> information.

This doesn't change the nature of the test, just adds a debug
message so that we explain why it was rejected. Vital information should
anyone report a bug with a connected VGA monitor.

This is another case where we are damned if we do and damned if we don't.
Some hardware requires us to differentiate between VGA/DVI connections on
the same i2c wire and the rejection here was originally added to enable us
to function correctly on such a machine.

As far as broken EDIDs go, there are plenty of bugs to go around.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre