From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915/crt: Explicitly return false if connected to a digital monitor Date: Mon, 04 Apr 2011 16:25:27 +0100 Message-ID: References: <1301898405-6999-1-git-send-email-chris@chris-wilson.co.uk> <1301898405-6999-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A09E99E8C0 for ; Mon, 4 Apr 2011 08:25:34 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 04 Apr 2011 08:09:42 -0700, Keith Packard wrote: > On Mon, 4 Apr 2011 07:26:45 +0100, Chris Wilson wrote: > > > Rather than proceed on to the next test, return the result from > > detecting a connection but to a digital panel and include some debug > > output as to why. > > I'm worried that this will falsely reject some monitors with broken EDID > information. This doesn't change the nature of the test, just adds a debug message so that we explain why it was rejected. Vital information should anyone report a bug with a connected VGA monitor. This is another case where we are damned if we do and damned if we don't. Some hardware requires us to differentiate between VGA/DVI connections on the same i2c wire and the rejection here was originally added to enable us to function correctly on such a machine. As far as broken EDIDs go, there are plenty of bugs to go around. -Chris -- Chris Wilson, Intel Open Source Technology Centre