Re: [PATCH 07/15] drm/i915: Remove unused loop from intel_dp_mst_compute_config

Daniel Vetter
2016-08-22T14:33:22Z

On Mon, Aug 22, 2016 at 02:43:04PM +0200, Maarten Lankhorst wrote:
> Op 18-08-16 om 15:34 schreef Daniel Vetter:
> > On Tue, Aug 09, 2016 at 05:04:06PM +0200, Maarten Lankhorst wrote:
> >> conn_state is passed as argument now, if anything required conn_state
> >> they can get it without having to look it up.
> > Commit message seems off, this has been dead code before. It seems to be
> > duct-tape from before we had a proper intel_mst_best_encoder.
> What about this?
>
> Now that conn_state is passed in as argument to compute_config, it's guaranteed
> that there is a connector for the argument. The code that looks for the connector
> is now dead, and completely unused. Delete it.

Sounds good. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> with
that.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation