Re: [PATCH 05/15] drm/i915: Pass crtc_state and connector_state to encoder functions

Daniel Vetter
2016-08-22T14:32:23Z

On Mon, Aug 22, 2016 at 10:06:22AM +0200, Maarten Lankhorst wrote:
> Op 18-08-16 om 15:30 schreef Daniel Vetter:
> > On Tue, Aug 09, 2016 at 05:04:04PM +0200, Maarten Lankhorst wrote:
> >> This is mostly code churn, with exception of a few places:
> >> - intel_display.c has changes in intel_sanitize_encoder
> >> - intel_ddi.c has intel_ddi_fdi_disable calling intel_ddi_post_disable,
> >> and required a function change. Also affects intel_display.c
> >> - intel_dp_mst.c passes a NULL crtc_state and conn_state to
> >> intel_ddi_post_disable for shutting down the real encoder.
> > I didn't find this NULL callsite. Outdated commit message?
> intel_dp_mst.c:
>
> + intel_dig_port->base.post_disable(&intel_dig_port->base,
> + old_crtc_state, NULL);
>
> Though it seems I accidentally pass old_crtc_state, that one should be NULL too.

Indeed I somehow missed that one. Still, why do we need to pass NULL
there? We should be able to wire up the state passing completely.

> R-B with that fixed?

There's 2 more review comments from me.

> And did you review 4/15? I don't see it in my inbox.

Sorry, must have missed it. Now with r-b.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation